michaeluno / admin-page-framework

development/factory/admin_page/form/AdminPageFramework_Form_admin_page.php

Doc Comments +1 added lines

@@ -458,6 +458,7 @@
      * @internal
      * @since       3.5.3
      * @since       3.7.0      Moved from `AdminPageFramework_FormDefinition_Page`.
+     * @param string $sTabSlug
      * @return      boolean
      */
     private function _isThisSectionSetToThisTab( $sSectionPath, $sPageSlug, $sTabSlug ) {

Spacing +19 added lines, -19 removed lines

@@ -51,16 +51,16 @@ 
     public function getPageOnlyOptions( $aOptions, $sPageSlug ) {
 
         $_aStoredOptionsOfThePage = array();
-        foreach( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
+        foreach ( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
 
             // Check the section
-            if ( ! $this->_isThisSectionSetToThisPage( $_sSectionID, $sPageSlug ) ) {
+            if ( !$this->_isThisSectionSetToThisPage( $_sSectionID, $sPageSlug ) ) {
                 continue;
             }
 
             // At this point, the element belongs the given page slug as the section is of the given page slug's.
             $this->_setPageOnlyOptions(
-                $_aStoredOptionsOfThePage,  // by reference - gets updated in the method.
+                $_aStoredOptionsOfThePage, // by reference - gets updated in the method.
                 $aOptions,
                 $_aSubSectionsOrFields,
                 $sPageSlug,
@@ -80,7 +80,7 @@ 
          * @internal
          */
         private function _setPageOnlyOptions( array &$_aStoredOptionsOfThePage, array $aOptions, array $_aSubSectionsOrFields, $sPageSlug, $_sSectionID ) {
-            foreach( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
+            foreach ( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
 
                 // If it's a sub-section array,
                 if ( $this->isNumericInteger( $_sFieldID ) ) {
@@ -152,7 +152,7 @@ 
     public function getOtherPageOptions( $aOptions, $sPageSlug ) {
 
         $_aStoredOptionsNotOfThePage = array();
-        foreach( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
+        foreach ( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
 
             // Check the section
             if ( $this->_isThisSectionSetToThisPage( $_sSectionID, $sPageSlug ) ) {
@@ -181,7 +181,7 @@ 
          * @internal
          */
         private function _setOtherPageOptions( array &$_aStoredOptionsNotOfThePage, array $aOptions, array $_aSubSectionsOrFields, $sPageSlug ) {
-            foreach( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
+            foreach ( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
 
                 // It's a sub-section array.
                 if ( $this->isNumericInteger( $_sFieldID ) ) {
@@ -244,7 +244,7 @@ 
     public function getOtherTabOptions( $aOptions, $sPageSlug, $sTabSlug ) {
 
         $_aStoredOptionsNotOfTheTab = array();
-        foreach( $this->aFieldsets as $_sSectionPath => $_aSubSectionsOrFields ) {
+        foreach ( $this->aFieldsets as $_sSectionPath => $_aSubSectionsOrFields ) {
 
             // If the section is of the given page and the given tab, skip.
             if ( $this->_isThisSectionSetToThisTab( $_sSectionPath, $sPageSlug, $sTabSlug ) ) {
@@ -275,7 +275,7 @@ 
         private function _setOtherTabOptions( array &$_aStoredOptionsNotOfTheTab, array $aOptions, array $_aSubSectionsOrFields, $sSectionPath ) {
 
             // At this point, the passed element belongs to the other tabs since the section of the given tab is skipped.
-            foreach ( $_aSubSectionsOrFields as $_isSubSectionIndexOrFieldID => $_aSubSectionOrField  ) {
+            foreach ( $_aSubSectionsOrFields as $_isSubSectionIndexOrFieldID => $_aSubSectionOrField ) {
 
                 // If it's a sub section
                 if ( $this->isNumericInteger( $_isSubSectionIndexOrFieldID ) ) {
@@ -333,7 +333,7 @@ 
      * @since       3.7.0      Moved from `AdminPageFramework_FormDefinition_Page`.
      * @return      array
      */
-    public function getTabOptions( $aOptions, $sPageSlug, $sTabSlug='' ) {
+    public function getTabOptions( $aOptions, $sPageSlug, $sTabSlug = '' ) {
 
         $_aOtherTabOptions = $this->getOtherTabOptions( $aOptions, $sPageSlug, $sTabSlug );
         $_aTabOptions      = $this->invertCastArrayContents( $aOptions, $_aOtherTabOptions );
@@ -351,17 +351,17 @@ 
      * @since       3.7.0      Moved from `AdminPageFramework_FormDefinition_Page`.
      * @return      array
      */
-    public function getTabOnlyOptions( array $aOptions, $sPageSlug, $sTabSlug='' ) {
+    public function getTabOnlyOptions( array $aOptions, $sPageSlug, $sTabSlug = '' ) {
 
         $_aStoredOptionsOfTheTab = array();
-        if ( ! $sTabSlug ) {
+        if ( !$sTabSlug ) {
             return $_aStoredOptionsOfTheTab;
         }
 
-        foreach( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
+        foreach ( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
 
             // Check the section
-            if ( ! $this->_isThisSectionSetToThisTab( $_sSectionID, $sPageSlug, $sTabSlug ) ) {
+            if ( !$this->_isThisSectionSetToThisTab( $_sSectionID, $sPageSlug, $sTabSlug ) ) {
                 continue;
             }
 
@@ -387,7 +387,7 @@ 
          */
         private function _setTabOnlyOptions( array &$_aStoredOptionsOfTheTab, array $aOptions, array $_aSubSectionsOrFields, $_sSectionID ) {
 
-            foreach( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
+            foreach ( $_aSubSectionsOrFields as $_sFieldID => $_aFieldset ) {
 
                 // if it's a sub-section array.
                 if ( $this->isNumericInteger( $_sFieldID ) ) {
@@ -444,7 +444,7 @@ 
      */
     private function _isThisSectionSetToThisPage( $sSectionPath, $sPageSlug ) {
 
-        if ( ! isset( $this->aSectionsets[ $sSectionPath ][ 'page_slug' ] ) ) {
+        if ( !isset( $this->aSectionsets[ $sSectionPath ][ 'page_slug' ] ) ) {
             return false;
         }
         return (
@@ -462,10 +462,10 @@ 
      */
     private function _isThisSectionSetToThisTab( $sSectionPath, $sPageSlug, $sTabSlug ) {
 
-        if ( ! $this->_isThisSectionSetToThisPage( $sSectionPath, $sPageSlug ) ) {
+        if ( !$this->_isThisSectionSetToThisPage( $sSectionPath, $sPageSlug ) ) {
             return false;
         }
-        if ( ! isset( $this->aSectionsets[ $sSectionPath ][ 'tab_slug' ] ) ) {
+        if ( !isset( $this->aSectionsets[ $sSectionPath ][ 'tab_slug' ] ) ) {
             return false;
         }
         return (
@@ -482,9 +482,9 @@ 
      */
     private function _setOptionValue( &$aSubject, $asDimensionalPath, $aOptions ) {
         $_aDimensionalPath = $this->getAsArray( $asDimensionalPath );
-        $_mValue     = $this->getElement(
+        $_mValue = $this->getElement(
             $aOptions,
-            $_aDimensionalPath,    // as of 3.7.0, it can be an array or string
+            $_aDimensionalPath, // as of 3.7.0, it can be an array or string
             null
         );
         if ( isset( $_mValue ) ) {

development/factory/post_type/_view/AdminPageFramework_PageLoadInfo_post_type.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
         if ( in_array( $oProp->sClassName, self::$aClassNames ) )
             return self::$_oInstance;
         
-        self::$aClassNames[] = $oProp->sClassName;
+        self::$aClassNames[ ] = $oProp->sClassName;
         self::$_oInstance = new AdminPageFramework_PageLoadInfo_post_type( $oProp, $oMsg );
         
         return self::$_oInstance;
@@ -43,7 +43,7 @@ 
     public function _replyToSetPageLoadInfoInFooter() {
 
         // Some users sets $_GET['post_type'] element even in regular admin pages. In that case, do not load the style to avoid duplicates.
-        if ( isset( $_GET['page'] ) && $_GET['page'] ) { return; }
+        if ( isset( $_GET[ 'page' ] ) && $_GET[ 'page' ] ) { return; }
     
         // For post type pages
         if ( 

Braces +3 added lines, -2 removed lines

@@ -26,8 +26,9 @@
      */
     public static function instantiate( $oProp, $oMsg ) {
         
-        if ( in_array( $oProp->sClassName, self::$aClassNames ) )
-            return self::$_oInstance;
+        if ( in_array( $oProp->sClassName, self::$aClassNames ) ) {
+                    return self::$_oInstance;
+        }
         
         self::$aClassNames[] = $oProp->sClassName;
         self::$_oInstance = new AdminPageFramework_PageLoadInfo_post_type( $oProp, $oMsg );

development/factory/_common/form/_view/css/AdminPageFramework_Form_View___CSS_FieldError.php

Braces +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
      * @since       3.7.0
      * @return      string
      */
-    protected function _get() {        
+    protected function _get() {
         return $this->_getFieldErrorRules();
     }
         /**

development/factory/_common/form/_view/css/AdminPageFramework_Form_View___CSS_Base.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
      * @since   3.7.0
      */
     public function add( $sCSSRules ) {
-        $this->aAdded[] = $sCSSRules;
+        $this->aAdded[ ] = $sCSSRules;
     }
     
     /**
@@ -39,7 +39,7 @@ 
      */
     public function get() {
         
-        $_sCSSRules  = $this->_get() . PHP_EOL;
+        $_sCSSRules  = $this->_get().PHP_EOL;
         $_sCSSRules .= $this->_getVersionSpecific();
         $_sCSSRules .= implode( PHP_EOL, $this->aAdded );
         return $_sCSSRules;

development/factory/_common/form/_view/css/AdminPageFramework_Form_View___CSS_Form.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      */
     protected function _get() {
 
-        $_sSpinnerURL  = esc_url( admin_url( '/images/wpspin_light-2x.gif' ) );
+        $_sSpinnerURL = esc_url( admin_url( '/images/wpspin_light-2x.gif' ) );
         return <<<CSSRULES
 .admin-page-framework-form-warning {
     font-size: 1em;

development/factory/_common/form/_view/generator/field/AdminPageFramework_Form_View___Generate_FieldAddress.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
      * @return      string      The generated field name model.
      */
     public function getModel() {
-        return $this->get() . '|' . $this->sIndexMark;
+        return $this->get().'|'.$this->sIndexMark;
     }
  
 }

development/factory/_common/form/_view/generator/field/AdminPageFramework_Form_View___Generate_FieldName.php

Braces +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
         return $_sResult;
     }
         
-    public function getModel()     {
+    public function getModel() {
         return $this->get() . '[' . $this->sIndexMark . ']';
     }
         

Spacing +5 added lines, -5 removed lines

@@ -25,8 +25,8 @@ 
         return $_sResult;
     }
 
-    public function getModel()     {
-        return $this->get() . '[' . $this->sIndexMark . ']';
+    public function getModel() {
+        return $this->get().'['.$this->sIndexMark.']';
     }
 
         /**
@@ -34,14 +34,14 @@ 
          */
         protected function _getFieldName() {
 
-            $_aFieldPath   = $this->aArguments[ '_field_path_array' ];
-            if ( ! $this->_isSectionSet() ) {
+            $_aFieldPath = $this->aArguments[ '_field_path_array' ];
+            if ( !$this->_isSectionSet() ) {
                 return $this->_getInputNameConstructed( $_aFieldPath );
             }
 
             $_aSectionPath = $this->aArguments[ '_section_path_array' ];
             if ( $this->_isSectionSet() && isset( $this->aArguments[ '_section_index' ] ) ) {
-                $_aSectionPath[] = $this->aArguments[ '_section_index' ];
+                $_aSectionPath[ ] = $this->aArguments[ '_section_index' ];
             }
             $_sFieldName = $this->_getInputNameConstructed(
                 array_merge( $_aSectionPath, $_aFieldPath )

development/factory/_common/form/_view/sectionset/AdminPageFramework_Form_View___SectionTitle.php

Braces +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
  * @since       3.7.0      Changed the name from `AdminPageFramework_FormPart_SectionTitle`.
  * @internal
  */
-class AdminPageFramework_Form_View___SectionTitle extends AdminPageFramework_Form_View___Section_Base {            
+class AdminPageFramework_Form_View___SectionTitle extends AdminPageFramework_Form_View___Section_Base {
   
     public $aArguments      = array(
         'title'         => null,
@@ -194,11 +194,11 @@ 
              * @since       3.8.0
              * @internal
              */
-            private function _getFieldsetsOutputInSectionTitleArea( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {   
+            private function _getFieldsetsOutputInSectionTitleArea( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {
 
                 $_sOutput = '';
                 foreach( $this->_getFieldsetsInSectionTitleArea( $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) as $_aFieldset ) {
-                    if ( empty( $_aFieldset ) )  {
+                    if ( empty( $_aFieldset ) ) {
                         continue;
                     }
                     $_sOutput .= $this->getFieldsetOutput( $_aFieldset );
@@ -242,7 +242,7 @@ 
                  * @since       3.7.0       Moved from `AdminPageFramework_FormPart_SectionTitle`.
                  * @return      array|void
                  */
-                private function _getSectionTitleField( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {   
+                private function _getSectionTitleField( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {
                 
                     foreach( $aFieldsets as $_aFieldset ) {
                         

Spacing +10 added lines, -10 removed lines

@@ -17,14 +17,14 @@ 
  */
 class AdminPageFramework_Form_View___SectionTitle extends AdminPageFramework_Form_View___Section_Base {            
   
-    public $aArguments      = array(
+    public $aArguments = array(
         'title'         => null,
         'tag'           => null,
         'section_index' => null,
         
         'sectionset'    => array(),
     );
-    public $aFieldsets               = array();
+    public $aFieldsets = array();
     public $aSavedData              = array();
     public $aFieldErrors            = array();
     public $aFieldTypeDefinitions   = array();
@@ -90,7 +90,7 @@ 
          * @since       3.7.0      Moved from `AdminPageFramework_FormPart_SectionTitle`.
          * @return      string      The section title output. 
          */
-        protected function _getSectionTitle( $sTitle, $sTag, $aFieldsets, $iSectionIndex=null, $aFieldTypeDefinitions=array(), $aCollapsible=array() ) {
+        protected function _getSectionTitle( $sTitle, $sTag, $aFieldsets, $iSectionIndex = null, $aFieldTypeDefinitions = array(), $aCollapsible = array() ) {
 
             $_aSectionTitleFieldset = $this->_getSectionTitleField( $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions );
             $_sFieldsInSectionTitle = $this->_getFieldsetsOutputInSectionTitleArea( $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions );
@@ -100,7 +100,7 @@ 
             $_bHasOtherFields       = $_sFieldsInSectionTitle
                 ? ' has-fields'
                 : '';
-            $_sOutput               = $_sTitle . $_sFieldsInSectionTitle;
+            $_sOutput               = $_sTitle.$_sFieldsInSectionTitle;
             return $_sOutput
                 ? "<div class='section-title-height-fixer'></div>"
                 . "<div class='section-title-outer-container'>" // 3.8.13+ For vertical alignment
@@ -128,7 +128,7 @@ 
                  * @return      string
                  */
                 private function _getToolTip( $_aSectionset ) {
-                    $_sSectionTitleTagID = str_replace( '|', '_', $_aSectionset[ '_section_path' ]  ) . '_' . $this->aArguments[ 'section_index' ];
+                    $_sSectionTitleTagID = str_replace( '|', '_', $_aSectionset[ '_section_path' ] ).'_'.$this->aArguments[ 'section_index' ];
                     $_oToolTip           = new AdminPageFramework_Form_View___ToolTip(
                         $_aSectionset[ 'tip' ],
                         $_sSectionTitleTagID
@@ -160,8 +160,8 @@ 
             private function _getFieldsetsOutputInSectionTitleArea( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {   
 
                 $_sOutput = '';
-                foreach( $this->_getFieldsetsInSectionTitleArea( $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) as $_aFieldset ) {
-                    if ( empty( $_aFieldset ) )  {
+                foreach ( $this->_getFieldsetsInSectionTitleArea( $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) as $_aFieldset ) {
+                    if ( empty( $_aFieldset ) ) {
                         continue;
                     }
                     $_sOutput .= $this->getFieldsetOutput( $_aFieldset );
@@ -177,7 +177,7 @@ 
                 private function _getFieldsetsInSectionTitleArea( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {
                     
                     $_aFieldsetsInSectionTitle = array();
-                    foreach( $aFieldsets as $_aFieldset ) {
+                    foreach ( $aFieldsets as $_aFieldset ) {
                         
                         if ( 'section_title' !== $_aFieldset[ 'placement' ] ) {
                             continue;
@@ -188,7 +188,7 @@ 
                             $iSectionIndex,
                             $aFieldTypeDefinitions
                         );         
-                        $_aFieldsetsInSectionTitle[] = $_oFieldsetOutputFormatter->get();
+                        $_aFieldsetsInSectionTitle[ ] = $_oFieldsetOutputFormatter->get();
                         
                     }
                     return $_aFieldsetsInSectionTitle;
@@ -207,7 +207,7 @@ 
                  */
                 private function _getSectionTitleField( array $aFieldsets, $iSectionIndex, $aFieldTypeDefinitions ) {   
                 
-                    foreach( $aFieldsets as $_aFieldset ) {
+                    foreach ( $aFieldsets as $_aFieldset ) {
                         
                         if ( 'section_title' !== $_aFieldset[ 'type' ] ) {
                             continue;

development/factory/_common/form/_model/AdminPageFramework_Form_Model___SetFieldResources.php

Braces +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
             private function ___setFieldResourcesBySection( $_aFieldsets ) {
 
                 $_bIsSubSectionLoaded = false;
-                foreach( $_aFieldsets as $_iSubSectionIndexOrFieldID => $_aSubSectionOrField )  {
+                foreach( $_aFieldsets as $_iSubSectionIndexOrFieldID => $_aSubSectionOrField ) {
 // @todo Examine if this structure is correct or not.
 // It may not be necessary to check the sub-section dimensions as this is not the saved options array.
                     // if it's a sub-section

Spacing +13 added lines, -13 removed lines

@@ -90,16 +90,16 @@ 
                 'AdminPageFramework_Form_View___CSS_FieldError',
                 'AdminPageFramework_Form_View___CSS_ToolTip',
             );
-            foreach( $_aClassNames as $_sClassName ) {
+            foreach ( $_aClassNames as $_sClassName ) {
                 $_oCSS = new $_sClassName;
-                $this->aResources[ 'internal_styles' ][] = $_oCSS->get();
+                $this->aResources[ 'internal_styles' ][ ] = $_oCSS->get();
             }
             $_aClassNamesForIE = array(
                 'AdminPageFramework_Form_View___CSS_CollapsibleSectionIE',
             );
-            foreach( $_aClassNamesForIE as $_sClassName ) {
+            foreach ( $_aClassNamesForIE as $_sClassName ) {
                 $_oCSS = new $_sClassName;
-                $this->aResources[ 'internal_styles_ie' ][] = $_oCSS->get();
+                $this->aResources[ 'internal_styles_ie' ][ ] = $_oCSS->get();
             }
 
         }
@@ -117,7 +117,7 @@ 
          * @return      void
          */
         private function ___set( $aAllFieldsets ) {
-            foreach( $aAllFieldsets as $_sSecitonID => $_aFieldsets ) {
+            foreach ( $aAllFieldsets as $_sSecitonID => $_aFieldsets ) {
                 $this->___setFieldResourcesBySection( $_aFieldsets );
             }
         }
@@ -129,7 +129,7 @@ 
             private function ___setFieldResourcesBySection( $_aFieldsets ) {
 
                 $_bIsSubSectionLoaded = false;
-                foreach( $_aFieldsets as $_iSubSectionIndexOrFieldID => $_aSubSectionOrField )  {
+                foreach ( $_aFieldsets as $_iSubSectionIndexOrFieldID => $_aSubSectionOrField ) {
 // @todo Examine if this structure is correct or not.
 // It may not be necessary to check the sub-section dimensions as this is not the saved options array.
                     // if it's a sub-section
@@ -140,7 +140,7 @@ 
                             continue;
                         }
                         $_bIsSubSectionLoaded = true;
-                        foreach( $_aSubSectionOrField as $_aField ) {
+                        foreach ( $_aSubSectionOrField as $_aField ) {
                             $this->___setFieldResources( $_aField );
                         }
                         continue;
@@ -165,7 +165,7 @@ 
                 private function ___setFieldResources( $aFieldset ) {
 
                     // Check the field conditions.
-                    if ( ! $this->___isFieldsetAllowed( $aFieldset ) ) {
+                    if ( !$this->___isFieldsetAllowed( $aFieldset ) ) {
                         return;
                     }
 
@@ -196,7 +196,7 @@ 
                         return $this->callBack(
                             $this->aCallbacks[ 'is_fieldset_registration_allowed' ],
                             array(
-                                true,   // 1st parameter
+                                true, // 1st parameter
                                 $aFieldset, // 2nd parameter
                             )
                         );
@@ -208,7 +208,7 @@ 
                      */
                     private function ___setResourcesOfNestedFields( $aFieldset ) {
 
-                        if ( ! $this->hasFieldDefinitionsInContent( $aFieldset ) ) {
+                        if ( !$this->hasFieldDefinitionsInContent( $aFieldset ) ) {
                             return;
                         }
                         foreach ( $aFieldset[ 'content' ] as $_asNestedFieldset ) {
@@ -248,7 +248,7 @@ 
                         $this->callBack(
                             $this->aCallbacks[ 'load_fieldset_resource' ],
                             array(
-                                $aFieldset,   // 1st parameter
+                                $aFieldset, // 1st parameter
                             )
                         );
 
@@ -256,7 +256,7 @@ 
         // Be careful not to add duplicate items as currently the sub-field items are parsed.
 
                         // Is already registered?
-                        if ( $this->hasBeenCalled( 'registered_' . $_sFieldtype . '_' . $this->aArguments[ 'structure_type' ] ) ) {
+                        if ( $this->hasBeenCalled( 'registered_'.$_sFieldtype.'_'.$this->aArguments[ 'structure_type' ] ) ) {
                             return;
                         }
 
@@ -271,7 +271,7 @@ 
                             $_aFieldTypeDefinition,
                             $this->aResources
                         );
-                        $this->aResources     = $_oFieldTypeResources->get();
+                        $this->aResources = $_oFieldTypeResources->get();
 
                     }