michaeluno / admin-page-framework

development/factory/_common/utility/base_utility/AdminPageFramework_Utility_Path.php

Spacing +7 added lines, -7 removed lines

@@ -29,8 +29,8 @@ 
     static public function getRelativePath( $from, $to ) {
         
         // some compatibility fixes for Windows paths
-        $from = is_dir( $from ) ? rtrim( $from, '\/') . '/' : $from;
-        $to   = is_dir( $to )   ? rtrim( $to, '\/') . '/'   : $to;
+        $from = is_dir( $from ) ? rtrim( $from, '\/' ).'/' : $from;
+        $to   = is_dir( $to ) ? rtrim( $to, '\/' ).'/' : $to;
         $from = str_replace( '\\', '/', $from );
         $to   = str_replace( '\\', '/', $to );
 
@@ -38,21 +38,21 @@ 
         $to       = explode( '/', $to );
         $relPath  = $to;
 
-        foreach( $from as $depth => $dir ) {
+        foreach ( $from as $depth => $dir ) {
             // find first non-matching dir
-            if( $dir === $to[ $depth ] ) {
+            if ( $dir === $to[ $depth ] ) {
                 // ignore this directory
                 array_shift( $relPath );
             } else {
                 // get number of remaining dirs to $from
                 $remaining = count( $from ) - $depth;
-                if( $remaining > 1 ) {
+                if ( $remaining > 1 ) {
                     // add traversals up to first matching dir
                     $padLength = ( count( $relPath ) + $remaining - 1 ) * -1;
                     $relPath = array_pad( $relPath, $padLength, '..' );
                     break;
                 } else {
-                    $relPath[ 0 ] = './' . $relPath[ 0 ];
+                    $relPath[ 0 ] = './'.$relPath[ 0 ];
                 }
             }
         }
@@ -81,7 +81,7 @@ 
                 6, // the second parameter: limit
             )
         );
-        foreach( $_aBackTrace as $_aDebugInfo )  {     
+        foreach ( $_aBackTrace as $_aDebugInfo ) {     
             $_sCallerFilePath = $_aDebugInfo[ 'file' ];
             if ( in_array( $_sCallerFilePath, $_aRedirectedFilePaths ) ) { 
                 continue; 

Braces +2 added lines, -2 removed lines

@@ -81,9 +81,9 @@
                 6, // the second parameter: limit
             )
         );
-        foreach( $_aBackTrace as $_aDebugInfo )  {     
+        foreach( $_aBackTrace as $_aDebugInfo ) {
             $_sCallerFilePath = $_aDebugInfo[ 'file' ];
-            if ( in_array( $_sCallerFilePath, $_aRedirectedFilePaths ) ) { 
+            if ( in_array( $_sCallerFilePath, $_aRedirectedFilePaths ) ) {
                 continue; 
             }
             break; // catch the first found item.

development/factory/_common/_abstract/AdminPageFramework_Factory_Model.php

Doc Comments +1 added lines, -2 removed lines

@@ -203,6 +203,7 @@ 
          * Constructs a WordPress filter hook name.
          * @internal
          * @since       3.8.4
+         * @param string $sPrefix
          * @return      string
          */
         private function _getHookNameByFieldsetAndPrefix( $sPrefix, $aFieldset ) {
@@ -339,8 +340,6 @@ 
      * @since       3.7.0      Changed back the visibility scope to protected as there is the `getFieldErrors()` public method.
      * @access      protected
      * @internal
-     * @param       string      $sID        deprecated
-     * @param       boolean     $bDelete    whether or not the transient should be deleted after retrieving it. 
      * @return      array
      * @deprecated  3.7.0      Use `getFieldErrors()` instead. Kept for backward compatibility.
      */

Spacing +13 added lines, -13 removed lines

@@ -32,7 +32,7 @@ 
         
         add_filter(
             // 'field_types_admin_page_framework',
-            'field_types_' . $oProp->sClassName,
+            'field_types_'.$oProp->sClassName,
             array( $this, '_replyToFilterFieldTypeDefinitions' )
         );
         
@@ -65,7 +65,7 @@ 
             'title'      => null,
             'help_aside' => null,
         );
-        if ( ! $aFieldset[ 'help' ] ) {
+        if ( !$aFieldset[ 'help' ] ) {
             return;
         }
         $this->oHelpPane->_addHelpTextForFormFields( 
@@ -85,9 +85,9 @@ 
     public function _replyToFilterFieldTypeDefinitions( $aFieldTypeDefinitions ) {
         
         // Not triggering `__call()` as the filter is fired manually in the form class.
-        if ( method_exists( $this, 'field_types_' . $this->oProp->sClassName ) ) {
+        if ( method_exists( $this, 'field_types_'.$this->oProp->sClassName ) ) {
             return call_user_func_array(
-                array( $this, 'field_types_' . $this->oProp->sClassName ),
+                array( $this, 'field_types_'.$this->oProp->sClassName ),
                 array( $aFieldTypeDefinitions )
             );
         }
@@ -108,7 +108,7 @@ 
     public function _replyToModifySectionsets( $aSectionsets ) {    
         
         return $this->oUtil->addAndApplyFilter( 
-            $this,  // caller factory object
+            $this, // caller factory object
             "sections_{$this->oProp->sClassName}", 
             $aSectionsets
         );
@@ -128,7 +128,7 @@ 
     public function _replyToModifyFieldsets( $aFieldsets, $aSectionsets ) {
 
         // Apply filters to added fieldsets
-        foreach( $aFieldsets as $_sSectionPath => $_aFields ) {
+        foreach ( $aFieldsets as $_sSectionPath => $_aFields ) {
             $_aSectionPath  = explode( '|', $_sSectionPath );
             $_sFilterSuffix = implode( '_', $_aSectionPath );
             $aFieldsets[ $_sSectionPath ] = $this->oUtil->addAndApplyFilter(
@@ -137,7 +137,7 @@ 
                 $_aFields
             ); 
         }
-        $aFieldsets =  $this->oUtil->addAndApplyFilter( 
+        $aFieldsets = $this->oUtil->addAndApplyFilter( 
             $this,
             "fields_{$this->oProp->sClassName}",
             $aFieldsets
@@ -207,14 +207,14 @@ 
          */
         private function _getHookNameByFieldsetAndPrefix( $sPrefix, $aFieldset ) {
             
-            $_sFieldPart    = '_' . implode( '_', $aFieldset[ '_field_path_array' ] );
+            $_sFieldPart    = '_'.implode( '_', $aFieldset[ '_field_path_array' ] );
             $_sSectionPart  = implode( '_', $aFieldset[ '_section_path_array' ] );
             $_sSectionPart  = $this->oUtil->getAOrB(
                 '_default' === $_sSectionPart,
                 '',
-                '_' . $_sSectionPart
+                '_'.$_sSectionPart
             );
-            return $sPrefix . $this->oProp->sClassName . $_sSectionPart . $_sFieldPart;
+            return $sPrefix.$this->oProp->sClassName.$_sSectionPart.$_sFieldPart;
             
         }
                
@@ -284,9 +284,9 @@ 
     public function _replyToGetSavedFormData() {
         
         // Must update the property with the filtered value.
-        $this->oProp->aOptions =  $this->oUtil->addAndApplyFilter(
+        $this->oProp->aOptions = $this->oUtil->addAndApplyFilter(
             $this, // the caller factory object
-            'options_' . $this->oProp->sClassName,
+            'options_'.$this->oProp->sClassName,
             $this->oProp->aOptions      // subject value to be filtered
         );
         return $this->oProp->aOptions;
@@ -366,7 +366,7 @@ 
          * An alias of `_setLastInputs()`.
          * @deprecated      3.7.0
          */
-        public function _setLastInput( $aLastInputs )  {
+        public function _setLastInput( $aLastInputs ) {
             return $this->setLastInputs( $aLastInputs );
         }    
 

Braces +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
      * but it requires to call the setUp() method in the overridden method so it's not that useful.
      * @internal
      */
-    protected function _setUp() { 
+    protected function _setUp() {
         $this->setUp();
     }    
     
@@ -105,7 +105,7 @@ 
      * @since       3.7.0
      * @return      array       The modified sectionsets definition array.
      */    
-    public function _replyToModifySectionsets( $aSectionsets ) {    
+    public function _replyToModifySectionsets( $aSectionsets ) {
         
         return $this->oUtil->addAndApplyFilter( 
             $this,  // caller factory object
@@ -366,7 +366,7 @@ 
          * An alias of `_setLastInputs()`.
          * @deprecated      3.7.0
          */
-        public function _setLastInput( $aLastInputs )  {
+        public function _setLastInput( $aLastInputs ) {
             return $this->setLastInputs( $aLastInputs );
         }    
 

development/factory/_common/form/_view/sectionset/AdminPageFramework_Form_View___FieldsetTableRow.php

Spacing +8 added lines, -8 removed lines

@@ -33,7 +33,7 @@ 
 
         $_aParameters = func_get_args() + array( 
             $this->aFieldset, 
-            $this->aSavedData,    // passed by reference. @todo: examine why it needs to be passed by reference.
+            $this->aSavedData, // passed by reference. @todo: examine why it needs to be passed by reference.
             $this->aFieldErrors, 
             $this->aFieldTypeDefinitions, 
             $this->aCallbacks, // field output element callables.        
@@ -61,14 +61,14 @@ 
         
         $aFieldset = $this->aFieldset;
 
-        if ( ! $this->isNormalPlacement( $aFieldset ) ) {
+        if ( !$this->isNormalPlacement( $aFieldset ) ) {
             return '';
         }
 
-        $_oFieldrowAttribute   = new AdminPageFramework_Form_View___Attribute_Fieldrow( 
+        $_oFieldrowAttribute = new AdminPageFramework_Form_View___Attribute_Fieldrow( 
             $aFieldset,
             array( 
-                'id'        => 'fieldrow-' . $aFieldset[ 'tag_id' ],
+                'id'        => 'fieldrow-'.$aFieldset[ 'tag_id' ],
                 'valign'    => 'top',
                 'class'     => 'admin-page-framework-fieldrow',
             )                
@@ -77,7 +77,7 @@ 
         return $this->_getFieldByContainer( 
             $aFieldset, 
             array(
-                'open_container'    => "<tr " . $_oFieldrowAttribute->get() . ">",
+                'open_container'    => "<tr ".$_oFieldrowAttribute->get().">",
                 'close_container'   => "</tr>",
                 'open_title'        => "<th>",
                 'close_title'       => "</th>",
@@ -126,13 +126,13 @@ 
                 $this->aCallbacks,
                 $this->oMsg
             );
-            $_aOutput   = array();
+            $_aOutput = array();
             if ( $aFieldset[ 'show_title_column' ] ) {
-                $_aOutput[] = $aOpenCloseTags[ 'open_title' ]
+                $_aOutput[ ] = $aOpenCloseTags[ 'open_title' ]
                         . $_oFieldTitle->get()
                     . $aOpenCloseTags[ 'close_title' ];
             }
-            $_aOutput[] = $aOpenCloseTags[ 'open_main' ]
+            $_aOutput[ ] = $aOpenCloseTags[ 'open_main' ]
                     // . call_user_func_array( $hfCallback, array( $aFieldset ) )
                     . $this->getFieldsetOutput( $aFieldset )
                 . $aOpenCloseTags[ 'close_main' ];