michaeluno / admin-page-framework

development/factory/admin_page/_model/delegate/AdminPageFramework_Model__FormEmailHandler.php

Doc Comments +1 added lines

@@ -25,6 +25,7 @@
     /**
      * Sets up properties.
      * @since       3.6.3
+     * @param AdminPageFramework_Model_Form $oFactory
      */
     public function __construct( $oFactory ) {
        

Spacing +4 added lines, -4 removed lines

@@ -28,10 +28,10 @@ 
      */
     public function __construct( $oFactory ) {
        
-        $this->oFactory         = $oFactory;        
+        $this->oFactory = $oFactory;        
 
         // Form emails.
-        if ( ! isset( $_GET[ 'apf_action' ], $_GET[ 'transient' ] ) ) {
+        if ( !isset( $_GET[ 'apf_action' ], $_GET[ 'transient' ] ) ) {
             return;
         }
         if ( 'email' !== $_GET[ 'apf_action' ] ) {
@@ -73,12 +73,12 @@ 
             self::$_bDoneEmail = true;
 
             $_sTransient = $this->getElement( $_GET, 'transient', '' );
-            if ( ! $_sTransient ) {
+            if ( !$_sTransient ) {
                 return;
             }
             $_aFormEmail = $this->getTransient( $_sTransient );
             $this->deleteTransient( $_sTransient );
-            if ( ! is_array( $_aFormEmail ) ) {
+            if ( !is_array( $_aFormEmail ) ) {
                 return;
             }
 

development/factory/admin_page/_model/delegate/AdminPageFramework_Model__FormSubmission.php

Doc Comments +6 added lines

@@ -26,6 +26,7 @@ 
     /**
      * Sets up hooks and properties.
      * @since       3.6.3
+     * @param AdminPageFramework_Model_Form $oFactory
      */
     public function __construct( $oFactory, $aSavedData, $aArguments, $aSectionsets, $aFieldsets ) {
        
@@ -250,6 +251,9 @@ 
          * Do the 'submit_...' actions.
          * 
          * @internal
+         * @param null|string $_sSubmitSectionID
+         * @param null|string $_sPressedFieldID
+         * @param null|string $_sPressedInputID
          * @return      void
          * @since       3.5.3
          * @since       3.6.3       Moved from `AdminPageFramework_Validation`.
@@ -296,6 +300,8 @@ 
          * Do the 'submit_after_...' actions.
          * 
          * @internal
+         * @param null|string $_sSubmitSectionID
+         * @param null|string $_sPressedFieldID
          * @return      void
          * @since       3.5.3
          * @since       3.6.3       Moved from `AdminPageFramework_Validation`.

Spacing +13 added lines, -13 removed lines

@@ -29,7 +29,7 @@ 
      */
     public function __construct( $oFactory, $aSavedData, $aArguments, $aSectionsets, $aFieldsets ) {
        
-        $this->oFactory         = $oFactory;        
+        $this->oFactory = $oFactory;        
                 
         // add_action
         // @deprecated      DEVVER
@@ -72,7 +72,7 @@ 
      */    
     public function _handleFormData() {
         
-        if ( ! $this->_shouldProceed() ) {
+        if ( !$this->_shouldProceed() ) {
             return;
         }
 
@@ -127,7 +127,7 @@ 
         new AdminPageFramework_Model__FormSubmission__Validator( $this->oFactory );
         
         // [3.6.3+] Apply filters. All the sub-routines of handling form submit data use this filter hook.
-        $_aInputs    = $this->addAndApplyFilters(    
+        $_aInputs = $this->addAndApplyFilters(    
             $this->oFactory, 
             "validation_pre_{$this->oFactory->oProp->sClassName}", 
             $_aInputs,
@@ -138,7 +138,7 @@ 
         
         // Save the data.
         $_bUpdated = false;
-        if ( ! $this->oFactory->oProp->_bDisableSavingOptions ) {  
+        if ( !$this->oFactory->oProp->_bDisableSavingOptions ) {  
             $_bUpdated = $this->oFactory->oProp->updateOption( $_aInputs );
         }
 
@@ -177,7 +177,7 @@ 
         private function _shouldProceed() {
             
             if ( 
-                ! isset( 
+                !isset( 
                     $_POST[ 'admin_page_framework_start' ], // indicates the framework form is started
                     $_POST[ '_wp_http_referer' ]
                 ) 
@@ -194,7 +194,7 @@ 
             
             // Check if all the form fields are sent. 
             if (
-                ! isset(
+                !isset(
                     // these keys are supposed to be embedded at the end of the form.
                     // if the server truncates the form input values for `max_input_vars`, these will be lost in PHP 5.3.9 or above.
                     $_POST[ '_is_admin_page_framework' ], // holds the form nonce
@@ -214,7 +214,7 @@ 
                 return false;
             }
                         
-            $_sNonceTransientKey = 'form_' . md5( $this->oFactory->oProp->sClassName . get_current_user_id() );
+            $_sNonceTransientKey = 'form_'.md5( $this->oFactory->oProp->sClassName.get_current_user_id() );
             if ( $_POST[ '_is_admin_page_framework' ] !== $this->getTransient( $_sNonceTransientKey ) ) {
                 $this->oFactory->setAdminNotice( $this->oFactory->oMsg->get( 'nonce_verification_failed' ) );
                 return false;
@@ -232,7 +232,7 @@ 
          */
         private function _getUserInputsFromPOST() {
 
-            $_aInputs     = $this->getElementAsArray( 
+            $_aInputs = $this->getElementAsArray( 
                 $_POST, 
                 $this->oFactory->oProp->sOptionKey, 
                 array() 
@@ -259,7 +259,7 @@ 
             // Warnings for deprecated hooks.
             if ( has_action( "submit_{$this->oFactory->oProp->sClassName}_{$_sPressedInputID}" ) ) {
                 trigger_error( 
-                    'Admin Page Framework: ' . ' : ' 
+                    'Admin Page Framework: '.' : ' 
                         . sprintf( 
                             __( 'The hook <code>%1$s</code>is deprecated. Use <code>%2$s</code> instead.', $this->oFactory->oProp->sTextDomain ), 
                             "submit_{instantiated class name}_{pressed input id}", 
@@ -272,7 +272,7 @@ 
                 $this->oFactory,
                 array( 
                     // @todo deprecate the hook with the input ID
-                    "submit_{$this->oFactory->oProp->sClassName}_{$_sPressedInputID}",  // will be deprecated in near future release
+                    "submit_{$this->oFactory->oProp->sClassName}_{$_sPressedInputID}", // will be deprecated in near future release
                     $_sSubmitSectionID 
                         ? "submit_{$this->oFactory->oProp->sClassName}_{$_sSubmitSectionID}_{$_sPressedFieldID}" 
                         : "submit_{$this->oFactory->oProp->sClassName}_{$_sPressedFieldID}",
@@ -355,9 +355,9 @@ 
             
             // Drop the 'field_errors' key.
             $_aRemoveQueries = array();
-            if ( ! isset( $aStatus[ 'field_errors' ] ) || ! $aStatus[ 'field_errors' ] ) {
+            if ( !isset( $aStatus[ 'field_errors' ] ) || !$aStatus[ 'field_errors' ] ) {
                 unset( $aStatus[ 'field_errors' ] );
-                $_aRemoveQueries[] = 'field_errors';
+                $_aRemoveQueries[ ] = 'field_errors';
             }        
          
             return $this->addAndApplyFilters(    // 3.4.4+
@@ -382,7 +382,7 @@ 
          */
         private function _removePageElements( $aOptions, $sPageSlug, $sTabSlug ) {
             
-            if ( ! $sPageSlug && ! $sTabSlug ) {
+            if ( !$sPageSlug && !$sTabSlug ) {
                 return $aOptions;
             }
             

Braces +4 added lines, -3 removed lines

@@ -138,7 +138,7 @@ 
         
         // Save the data.
         $_bUpdated = false;
-        if ( ! $this->oFactory->oProp->_bDisableSavingOptions ) {  
+        if ( ! $this->oFactory->oProp->_bDisableSavingOptions ) {
             $_bUpdated = $this->oFactory->oProp->updateOption( $_aInputs );
         }
 
@@ -181,14 +181,15 @@ 
                     $_POST[ 'admin_page_framework_start' ], // indicates the framework form is started
                     $_POST[ '_wp_http_referer' ]
                 ) 
-            ) {     
+            ) {
                 return false;
             }
             
             // Referrer
             $_sRequestURI   = remove_query_arg( array( 'settings-updated', 'confirmation', 'field_errors' ), wp_unslash( $_SERVER[ 'REQUEST_URI' ] ) );
             $_sReffererURI  = remove_query_arg( array( 'settings-updated', 'confirmation', 'field_errors' ), $_POST[ '_wp_http_referer' ] );
-            if ( $_sRequestURI != $_sReffererURI ) { // see the function definition of wp_referer_field() in functions.php.
+            if ( $_sRequestURI != $_sReffererURI ) {
+// see the function definition of wp_referer_field() in functions.php.
                 return false;
             }
             

development/factory/admin_page/_model/delegate/AdminPageFramework_Model__FormSubmission_Base.php

Doc Comments +1 added lines

@@ -79,6 +79,7 @@
      * @since       3.5.3
      * @since       3.6.3       Moved from `AdminPageFramework_Form_Model_Validation_Option`.
      * @internal
+     * @param boolean $bIsInputEmtpy
      * @return      void
      * @remark      Accessed from some of the parent/child classes.
      */

Spacing +3 added lines, -3 removed lines

@@ -46,12 +46,12 @@
      * @return      null|string     Returns `null` if no value is found and the associated link url if found. 
      * Otherwise, the found value.
      */ 
-    protected function _getPressedSubmitButtonData( array $aPostElements, $sTargetKey='field_id' ) {    
+    protected function _getPressedSubmitButtonData( array $aPostElements, $sTargetKey = 'field_id' ) {    
 
-        foreach( $aPostElements as $_sInputID => $_aSubElements ) {
+        foreach ( $aPostElements as $_sInputID => $_aSubElements ) {
             
             // The 'name' key must be set.
-            if ( ! isset( $_aSubElements[ 'name' ] ) ) {
+            if ( !isset( $_aSubElements[ 'name' ] ) ) {
                 continue;
             }
             $_aNameKeys = explode( '|', $_aSubElements[ 'name' ] ); 

Braces +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
      * @return      null|string     Returns `null` if no value is found and the associated link url if found. 
      * Otherwise, the found value.
      */ 
-    protected function _getPressedSubmitButtonData( array $aPostElements, $sTargetKey='field_id' ) {    
+    protected function _getPressedSubmitButtonData( array $aPostElements, $sTargetKey='field_id' ) {
 
         foreach( $aPostElements as $_sInputID => $_aSubElements ) {
             
@@ -84,7 +84,7 @@ 
      */
     protected function _setSettingNoticeAfterValidation( $bIsInputEmtpy ) {
      
-        if ( $this->oFactory->hasSettingNotice() ) {     
+        if ( $this->oFactory->hasSettingNotice() ) {
             return;
         }
         $this->oFactory->setSettingNotice(  

development/factory/admin_page/_model/delegate/validaor/AdminPageFramework_Model__FormSubmission__Validator__Export.php

Doc Comments +2 added lines

@@ -92,6 +92,7 @@ 
              * 
              * @since       3.5.4
              * @since       3.6.3       Moved from `AdminPageFramework_Form_Model_Export`.
+             * @param string $sFileName
              * @return      array
              */
             private function _getExportHeaderArray( array $aArguments, $sFileName, $mData ) {
@@ -132,6 +133,7 @@ 
              * @since       3.5.3
              * @since       3.6.3       Moved from `AdminPageFramework_Form_Model_Export`.
              * @internal   
+             * @param string $mData
              * @return      string      The export file name.
              */        
             private function _getExportFileName( array $aArguments, $sExportFileName, $mData ) {        

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * Admin Page Framework
- * 
- * http://en.michaeluno.jp/admin-page-framework/
- * Copyright (c) 2013-2015 Michael Uno; Licensed MIT
- * 
- */
+         * Admin Page Framework
+         * 
+         * http://en.michaeluno.jp/admin-page-framework/
+         * Copyright (c) 2013-2015 Michael Uno; Licensed MIT
+         * 
+         */
 
 /**
  * Provides methods to handle importing options.

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function _replyToCallback( $aInputs, $aRawInputs, array $aSubmits, $aSubmitInformation, $oFactory ) {
         
-        if ( ! $this->_shouldProceed() ) {
+        if ( !$this->_shouldProceed() ) {
             return;
         }        
         $this->_exportOptions(
@@ -65,11 +65,11 @@ 
          */
         protected function _exportOptions( $mData, $sPageSlug, $sTabSlug ) {
 
-            $_oExport           = new AdminPageFramework_ExportOptions( 
+            $_oExport = new AdminPageFramework_ExportOptions( 
                 $_POST[ '__export' ], 
                 $this->oFactory->oProp->sClassName 
             );
-            $_aArguments        = array(
+            $_aArguments = array(
                 'class_name'        => $this->oFactory->oProp->sClassName,
                 'page_slug'         => $sPageSlug,
                 'tab_slug'          => $sTabSlug,
@@ -141,7 +141,7 @@ 
                     $sExportFileName, 
                     $aArguments[ 'pressed_field_id' ],
                     $aArguments[ 'pressed_input_id' ],
-                    $mData,     // 3.4.6+
+                    $mData, // 3.4.6+
                     $this->oFactory       // 3.4.6+
                 );    
             }

Braces +3 added lines, -3 removed lines

@@ -120,7 +120,7 @@ 
              * @internal   
              * @return      string      the filtered export data.
              */
-            private function _getFilteredExportingData( array $aArguments, $mData ) {                   
+            private function _getFilteredExportingData( array $aArguments, $mData ) {
                 return $this->_getFilteredItemForPortByPrefix(
                     'export_',
                     $mData,    
@@ -134,7 +134,7 @@ 
              * @internal   
              * @return      string      The export file name.
              */        
-            private function _getExportFileName( array $aArguments, $sExportFileName, $mData ) {        
+            private function _getExportFileName( array $aArguments, $sExportFileName, $mData ) {
                 return $this->addAndApplyFilters(
                     $this->oFactory,
                     $this->_getPortFilterHookNames( 'export_name_', $aArguments ),
@@ -152,7 +152,7 @@ 
              * @internal   
              * @return      string      The export format type.
              */        
-            private function _getExportFormatType( array $aArguments, $sExportFileFormat ) {  
+            private function _getExportFormatType( array $aArguments, $sExportFileFormat ) {
                 return $this->_getFilteredItemForPortByPrefix(
                     'export_format_',
                     $sExportFileFormat,    

development/factory/admin_page/_model/delegate/validaor/AdminPageFramework_Model__FormSubmission__Validator__Import.php

Doc Comments +4 added lines

@@ -143,6 +143,7 @@ 
                 /**
                  * Sets update admin notice.
                  * @since       3.5.3
+                 * @param boolean $bEmpty
                  * @return      void
                  */
                 private function _setImportAdminNotice( $bEmpty ) {
@@ -204,6 +205,8 @@ 
                  * @since       3.5.3
                  * @since       3.6.3       Moved from `AdminPageFramework_Form_Model_Import`.
                  * @internal   
+                 * @param string $sFormatType
+                 * @param string $sImportOptionKey
                  * @return      string      The filtered import data.
                  */    
                 private function _getFilteredImportData( array $aArguments, $mData, $aStoredOptions, $sFormatType, $sImportOptionKey ) {
@@ -232,6 +235,7 @@ 
      * @param       string      The filter prefix.
      * @param       mixed       The subject filtering value.
      * @param       array       An argument array holding submit information. Part of this will be passed to the filter callbacks but this itself does not mean is for the filter callbacks.
+     * @param string $sPrefix
      */
     protected function _getFilteredItemForPortByPrefix( $sPrefix, $mFilteringValue, array $aArguments ) {
         return $this->addAndApplyFilters(

Spacing +10 added lines, -10 removed lines

@@ -32,7 +32,7 @@ 
      * @callback    action      try_validation_after_{class name}
      */
     public function _replyToCallback( $aInputs, $aRawInputs, array $aSubmits, $aSubmitInformation, $oFactory ) {
-        if ( ! $this->_shouldProceed() ) {
+        if ( !$this->_shouldProceed() ) {
             return;
         }
         $this->_doImportOptions(
@@ -102,9 +102,9 @@ 
                 // Check the uploaded file MIME type.
                 $_aMIMEType = $this->_getImportMIMEType( $_aArguments );
                 $_sType     = $_oImport->getType();
-                if ( ! in_array( $_sType, $_aMIMEType ) ) {        
+                if ( !in_array( $_sType, $_aMIMEType ) ) {        
                     $this->oFactory->setSettingNotice( sprintf( $this->oFactory->oMsg->get( 'uploaded_file_type_not_supported' ), $_sType ) );
-                    return $aStoredOptions;        // do not change the framework's options.
+                    return $aStoredOptions; // do not change the framework's options.
                 }
 
                 // Retrieve the importing data.
@@ -254,18 +254,18 @@ 
     protected function _getPortFilterHookNames( $sPrefix, array $aArguments ) {
         
         return array(
-            $sPrefix . $aArguments[ 'class_name' ] . '_' . $aArguments[ 'pressed_input_id' ],
+            $sPrefix.$aArguments[ 'class_name' ].'_'.$aArguments[ 'pressed_input_id' ],
             $aArguments[ 'section_id' ] 
-                ? $sPrefix . $aArguments[ 'class_name' ] . '_' . $aArguments[ 'section_id' ] .'_' . $aArguments[ 'pressed_field_id' ]
-                : $sPrefix . $aArguments[ 'class_name' ] . '_' . $aArguments[ 'pressed_field_id' ],
+                ? $sPrefix.$aArguments[ 'class_name' ].'_'.$aArguments[ 'section_id' ].'_'.$aArguments[ 'pressed_field_id' ]
+                : $sPrefix.$aArguments[ 'class_name' ].'_'.$aArguments[ 'pressed_field_id' ],
             $aArguments[ 'section_id' ] 
-                ? $sPrefix . $aArguments[ 'class_name' ] . '_' . $aArguments[ 'section_id' ] 
+                ? $sPrefix.$aArguments[ 'class_name' ].'_'.$aArguments[ 'section_id' ] 
                 : null,
             $aArguments[ 'tab_slug' ] 
-                ? $sPrefix . $aArguments[ 'page_slug' ] . '_' . $aArguments[ 'tab_slug' ]
+                ? $sPrefix.$aArguments[ 'page_slug' ].'_'.$aArguments[ 'tab_slug' ]
                 : null,
-            $sPrefix . $aArguments[ 'page_slug' ],
-            $sPrefix . $aArguments[ 'class_name' ]
+            $sPrefix.$aArguments[ 'page_slug' ],
+            $sPrefix.$aArguments[ 'class_name' ]
         );            
         
     }        

Braces +2 added lines, -2 removed lines

@@ -102,7 +102,7 @@ 
                 // Check the uploaded file MIME type.
                 $_aMIMEType = $this->_getImportMIMEType( $_aArguments );
                 $_sType     = $_oImport->getType();
-                if ( ! in_array( $_sType, $_aMIMEType ) ) {        
+                if ( ! in_array( $_sType, $_aMIMEType ) ) {
                     $this->oFactory->setSettingNotice( sprintf( $this->oFactory->oMsg->get( 'uploaded_file_type_not_supported' ), $_sType ) );
                     return $aStoredOptions;        // do not change the framework's options.
                 }
@@ -163,7 +163,7 @@ 
                  * @since       3.5.3
                  * @return      array       An array holding processable MIME types.       
                  */
-                private function _getImportMIMEType( array $aArguments ) {  
+                private function _getImportMIMEType( array $aArguments ) {
                     return $this->_getFilteredItemForPortByPrefix(
                         'import_mime_types_',
                         array( 'text/plain', 'application/octet-stream' ), // .json file is dealt as a binary file.

development/factory/admin_page/_model/delegate/validaor/AdminPageFramework_Model__FormSubmission__Validator__Redirect.php

Doc Comments +1 added lines

@@ -66,6 +66,7 @@
          * Sets the given URL's transient.
          * @since       unknown
          * @since       3.6.3       Moved from `AdminPageFramework_Validation`.
+         * @param string $sURL
          */
         private function _setRedirectTransients( $sURL, $sPageSlug ) {
             if ( empty( $sURL ) ) { 

Spacing +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
             $aSubmits, 
             'redirect_url' 
         );
-        if ( ! $_sRedirectURL ) {
+        if ( !$_sRedirectURL ) {
             return;
         }
         
@@ -71,8 +71,8 @@ 
             if ( empty( $sURL ) ) { 
                 return; 
             }
-            $_sTransient = 'apf_rurl' . md5( trim( "redirect_{$this->oFactory->oProp->sClassName}_{$sPageSlug}" ) );
-            return $this->setTransient( $_sTransient, $sURL , 60*2 );
+            $_sTransient = 'apf_rurl'.md5( trim( "redirect_{$this->oFactory->oProp->sClassName}_{$sPageSlug}" ) );
+            return $this->setTransient( $_sTransient, $sURL, 60 * 2 );
         }
  
 }
\ No newline at end of file

Braces +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
          * @since       3.6.3       Moved from `AdminPageFramework_Validation`.
          */
         private function _setRedirectTransients( $sURL, $sPageSlug ) {
-            if ( empty( $sURL ) ) { 
+            if ( empty( $sURL ) ) {
                 return; 
             }
             $_sTransient = 'apf_rurl' . md5( trim( "redirect_{$this->oFactory->oProp->sClassName}_{$sPageSlug}" ) );

development/factory/admin_page/_model/delegate/validaor/AdminPageFramework_Model__FormSubmission__Validator__Reset.php

Doc Comments +1 added lines

@@ -60,6 +60,7 @@
          * @since       3.6.3       Moved from `AdminPageFramework_Validation`.
          * @remark      `$aInputs` has only the page elements that called the validation callback. 
          * In other words, it does not hold other pages' option keys.
+         * @param string $sKeyToReset
          * @return      array       The modified input array.
          */
         private function _resetOptions( $sKeyToReset, array $aInputs, array $aSubmitInformation ) {

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
             'reset_key' 
         );
         $_sKeyToReset = trim( $_sKeyToReset );
-        if ( ! $_sKeyToReset ) {
+        if ( !$_sKeyToReset ) {
             return;
         }            
         $_oException = new Exception( 'aReturn' );
@@ -68,12 +68,12 @@ 
             $this->_doResetActions( $sKeyToReset, $aInputs, $aSubmitInformation );
             
             // As of 3.1.0, an empty value is accepted for the option key.
-            if ( ! $this->oFactory->oProp->sOptionKey ) {
+            if ( !$this->oFactory->oProp->sOptionKey ) {
                 return array();
             }
             
             // The key to delete is not specified, 1 is sent from the form input.
-            if ( in_array( $sKeyToReset, array( '1', ), true ) ) {
+            if ( in_array( $sKeyToReset, array( '1',), true ) ) {
                 delete_option( $this->oFactory->oProp->sOptionKey );
                 return array();
             }

development/factory/admin_page/_view/AdminPageFramework_View__PageRenderer.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
     /**
      * Sets up properties.
      * @since       3.6.3
+     * @param AdminPageFramework_View_Page $oFactory
      */
     public function __construct( $oFactory, $sPageSlug, $sTabSlug ) {
        

Spacing +21 added lines, -21 removed lines

@@ -47,7 +47,7 @@ 
     
         // Do actions before rendering the page. In this order, global -> page -> in-page tab
         $this->addAndDoActions( 
-            $this->oFactory,  // the caller object
+            $this->oFactory, // the caller object
             $this->getFilterArrayByPrefix( 'do_before_', $this->oFactory->oProp->sClassName, $_sPageSlug, $_sTabSlug, true ), // the action hooks
             $this->oFactory   // the argument 1
         );
@@ -72,7 +72,7 @@ 
                     </div><!-- #post-body -->    
                 </div><!-- #poststuff -->
                 
-            <?php echo $this->_printFormClosingTag( $_sPageSlug, $_sTabSlug, $this->oFactory->oProp->bEnableForm );  // </form> ?>
+            <?php echo $this->_printFormClosingTag( $_sPageSlug, $_sTabSlug, $this->oFactory->oProp->bEnableForm ); // </form> ?>
             </div><!-- .admin-page-framework-container -->
                 
             <?php    
@@ -83,7 +83,7 @@ 
         <?php
         // Do actions after rendering the page.
         $this->addAndDoActions( 
-            $this->oFactory,  // the caller object
+            $this->oFactory, // the caller object
             $this->getFilterArrayByPrefix( 'do_after_', $this->oFactory->oProp->sClassName, $_sPageSlug, $_sTabSlug, true ), // the action hooks
             $this->oFactory   // the argument 1
         );        
@@ -100,14 +100,14 @@ 
          */
         private function _getNumberOfColumns() {
             
-            if ( ! $this->doesMetaBoxExist( 'side' ) ) {
+            if ( !$this->doesMetaBoxExist( 'side' ) ) {
                 return 1;
             }
             
             $_iColumns = $this->getNumberOfScreenColumns();
             return $_iColumns
                 ? $_iColumns
-                : 1;    // default - this is because generic pages do not have meta boxes.
+                : 1; // default - this is because generic pages do not have meta boxes.
         } 
             // @deprecated
             // Make sure if no side meta box exists, set it 1.
@@ -126,7 +126,7 @@ 
         private function _getContentTop() {
 
             // Screen icon, page heading tabs(page title), and in-page tabs.
-            $_oScreenIcon       = new AdminPageFramework_View__PageRenderer__ScreenIcon( 
+            $_oScreenIcon = new AdminPageFramework_View__PageRenderer__ScreenIcon( 
                 $this->oFactory, 
                 $this->sPageSlug,
                 $this->sTabSlug
@@ -142,7 +142,7 @@ 
                 $this->oFactory,  
                 $this->sPageSlug            
             );
-            $_sContentTop      .= $_oInPageTabs->get();
+            $_sContentTop .= $_oInPageTabs->get();
 
             // Apply filters in this order, in-page tab -> page -> global.
             return $this->addAndApplyFilters( 
@@ -214,7 +214,7 @@ 
              */
             private function _getFormOutput( $sPageSlug ) {
 
-                if ( ! $this->oFactory->oProp->bEnableForm ) {
+                if ( !$this->oFactory->oProp->bEnableForm ) {
                     return '';
                 }
                 return $this->oFactory->oForm->get();
@@ -244,9 +244,9 @@ 
          * @internal
          * @return      void
          */ 
-        private function _printFormOpeningTag( $fEnableForm=true ) {    
+        private function _printFormOpeningTag( $fEnableForm = true ) {    
             
-            if ( ! $fEnableForm ) {
+            if ( !$fEnableForm ) {
                 return;
             }
     
@@ -259,12 +259,12 @@ 
                             'action'    => wp_unslash( remove_query_arg( 'settings-updated', $this->oFactory->oProp->sTargetFormPage ) ),
                         )    
                     ) 
-                . " >" . PHP_EOL;
+                . " >".PHP_EOL;
             
             // [3.5.11+] Insert a mark that indicates the framework form has started.
             // This will be checked in the validation method with the `is_admin_page_framework` input value which gets inserted at the end of the form
             // in order to determine all the fields are sent for the PHP max_input_vars limitation set in the server configuration.
-            echo "<input type='hidden' name='admin_page_framework_start' value='1' />" . PHP_EOL;
+            echo "<input type='hidden' name='admin_page_framework_start' value='1' />".PHP_EOL;
             
             // Embed the '_wp_http_referer' hidden field that is checked in the submit data processing method.
             settings_fields( $this->oFactory->oProp->sOptionKey );
@@ -280,19 +280,19 @@ 
          * @internal
          * @return      void
          */     
-        private function _printFormClosingTag( $sPageSlug, $sTabSlug, $fEnableForm=true ) {
+        private function _printFormClosingTag( $sPageSlug, $sTabSlug, $fEnableForm = true ) {
             
-            if ( ! $fEnableForm ) {
+            if ( !$fEnableForm ) {
                 return;
             }
             
-            $_sNonceTransientKey    = 'form_' . md5( $this->oFactory->oProp->sClassName . get_current_user_id() );
-            $_sNonce                = $this->getTransient( $_sNonceTransientKey, '_admin_page_framework_form_nonce_' . uniqid() );
-            $this->setTransient( $_sNonceTransientKey, $_sNonce, 60*60 ); // 60 minutes
-            echo "<input type='hidden' name='page_slug' value='{$sPageSlug}' />" . PHP_EOL
-                . "<input type='hidden' name='tab_slug' value='{$sTabSlug}' />" . PHP_EOL     
-                . "<input type='hidden' name='_is_admin_page_framework' value='{$_sNonce}' />" . PHP_EOL
-                . "</form><!-- End Form -->" . PHP_EOL;
+            $_sNonceTransientKey    = 'form_'.md5( $this->oFactory->oProp->sClassName.get_current_user_id() );
+            $_sNonce                = $this->getTransient( $_sNonceTransientKey, '_admin_page_framework_form_nonce_'.uniqid() );
+            $this->setTransient( $_sNonceTransientKey, $_sNonce, 60 * 60 ); // 60 minutes
+            echo "<input type='hidden' name='page_slug' value='{$sPageSlug}' />".PHP_EOL
+                . "<input type='hidden' name='tab_slug' value='{$sTabSlug}' />".PHP_EOL     
+                . "<input type='hidden' name='_is_admin_page_framework' value='{$_sNonce}' />".PHP_EOL
+                . "</form><!-- End Form -->".PHP_EOL;
             
         }    
                 

Braces +1 added lines, -1 removed lines

@@ -244,7 +244,7 @@
          * @internal
          * @return      void
          */ 
-        private function _printFormOpeningTag( $fEnableForm=true ) {    
+        private function _printFormOpeningTag( $fEnableForm=true ) {
             
             if ( ! $fEnableForm ) {
                 return;

development/factory/admin_page/_view/AdminPageFramework_View__PageRenderer__PageHeadingTabs.php

Doc Comments +2 added lines

@@ -60,6 +60,7 @@ 
          * @since       3.3.1       Moved from `AdminPageFramework_Page`.
          * @since       3.5.3       Deprecated the `$aOutput` parameter.
          * @since       3.6.3       Moved from `AdminPageFramework_Page_View`. Changed the name from `_getPageHeadingTabs()`.
+         * @param string $sTag
          * @return      string      the output of page heading tabs.
          */
         private function _getOutput( $aPage, $sTag ) {
@@ -100,6 +101,7 @@ 
              * @internal
              * @since       3.5.3
              * @since       3.6.3       Moved from `AdminPageFramework_Page_View`.
+             * @param string $sTag
              * @return      string      the HTML page heading tab navigation bar output.
              */
             private function _getPageHeadingtabNavigationBar( array $aPages, $sTag, $sCurrentPageSlug ) {

Spacing +12 added lines, -12 removed lines

@@ -45,7 +45,7 @@ 
         $_aPage = $this->oFactory->oProp->aPages[ $this->sPageSlug ];
         
         // If the page title is disabled, return an empty string.
-        if ( ! $_aPage[ 'show_page_title' ] ) { 
+        if ( !$_aPage[ 'show_page_title' ] ) { 
             return ""; 
         }
 
@@ -64,10 +64,10 @@ 
          */
         private function _getOutput( $aPage, $sTag ) {
    
-            $sTag  = $this->_getPageHeadingTabTag( $sTag, $aPage );
+            $sTag = $this->_getPageHeadingTabTag( $sTag, $aPage );
             
             // If the page heading tab visibility is disabled, or only one page is registered, return the title.
-            if ( ! $aPage[ 'show_page_heading_tabs' ] || count( $this->oFactory->oProp->aPages ) == 1 ) {
+            if ( !$aPage[ 'show_page_heading_tabs' ] || count( $this->oFactory->oProp->aPages ) == 1 ) {
                 return "<{$sTag}>" 
                         . $aPage[ 'title' ]  
                     . "</{$sTag}>";     
@@ -105,9 +105,9 @@ 
             private function _getPageHeadingtabNavigationBar( array $aPages, $sTag, $sCurrentPageSlug ) {
                 
                 $_oTabBar = new AdminPageFramework_TabNavigationBar(
-                    $aPages,     // tab items
+                    $aPages, // tab items
                     $sCurrentPageSlug, // active tab slug
-                    $sTag,       // container tag
+                    $sTag, // container tag
                     array(       // container attributes
                         // 'class' => '...',
                     ),
@@ -130,8 +130,8 @@ 
                  * @since           3.5.10
                  * @since       3.6.3       Moved from `AdminPageFramework_Page_View`.
                  */            
-                public function _replyToFormatNavigationTabItem_PageHeadingTab( $aSubPage, $aStructure, $aPages, $aArguments=array() ) {                    
-                    switch( $aSubPage['type'] ) {
+                public function _replyToFormatNavigationTabItem_PageHeadingTab( $aSubPage, $aStructure, $aPages, $aArguments = array() ) {                    
+                    switch ( $aSubPage[ 'type' ] ) {
                         case 'link':
                             return $this->_getFormattedPageHeadingtabNavigationBarLinkItem( $aSubPage, $aStructure );
                         default:
@@ -148,10 +148,10 @@ 
                      */
                     private function _getFormattedPageHeadingtabNavigationBarPageItem( array $aSubPage, $aStructure ) {
                         
-                        if ( ! isset( $aSubPage[ 'page_slug' ] ) ) {
+                        if ( !isset( $aSubPage[ 'page_slug' ] ) ) {
                             return array();
                         }
-                        if ( ! $aSubPage[ 'show_page_heading_tab' ] ) {
+                        if ( !$aSubPage[ 'show_page_heading_tab' ] ) {
                             return array();
                         }
                         return array(
@@ -182,10 +182,10 @@ 
                      */                    
                     private function _getFormattedPageHeadingtabNavigationBarLinkItem( array $aSubPage, $aStructure ) {
                         
-                        if ( ! isset( $aSubPage[ 'href' ] ) ) {
+                        if ( !isset( $aSubPage[ 'href' ] ) ) {
                             return array();
                         }
-                        if ( ! $aSubPage[ 'show_page_heading_tab' ] ) {
+                        if ( !$aSubPage[ 'show_page_heading_tab' ] ) {
                             return array();
                         }                        
                         $aSubPage = array(
@@ -197,7 +197,7 @@ 
                             + array( 'class' => null )
                             + $aStructure;
                             
-                        $aSubPage[ 'class' ] = trim( $aSubPage[ 'class' ] . ' link' );
+                        $aSubPage[ 'class' ] = trim( $aSubPage[ 'class' ].' link' );
                         return $aSubPage;
                     }                      
                 

Braces +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
         $_aPage = $this->oFactory->oProp->aPages[ $this->sPageSlug ];
         
         // If the page title is disabled, return an empty string.
-        if ( ! $_aPage[ 'show_page_title' ] ) { 
+        if ( ! $_aPage[ 'show_page_title' ] ) {
             return ""; 
         }
 
@@ -130,7 +130,7 @@ 
                  * @since           3.5.10
                  * @since       3.6.3       Moved from `AdminPageFramework_Page_View`.
                  */            
-                public function _replyToFormatNavigationTabItem_PageHeadingTab( $aSubPage, $aStructure, $aPages, $aArguments=array() ) {                    
+                public function _replyToFormatNavigationTabItem_PageHeadingTab( $aSubPage, $aStructure, $aPages, $aArguments=array() ) {
                     switch( $aSubPage['type'] ) {
                         case 'link':
                             return $this->_getFormattedPageHeadingtabNavigationBarLinkItem( $aSubPage, $aStructure );