michaeluno / admin-page-framework

development/factory/post_type/_model/AdminPageFramework_Property_post_type.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         'title'     => 'Title', // Post title. Includes "edit", "quick edit", "trash" and "view" links. If $mode (set from `$_REQUEST[ 'mode' ]`) is 'excerpt', a post excerpt is included between the title and links.
         'author'    => 'Author', // Post author.
         'comments'  => '<div class="comment-grey-bubble"></div>', // Number of pending comments.
-        'date'      => 'Date',     // The date and publish status of the post.
+        'date'      => 'Date', // The date and publish status of the post.
     );
 
     /**

development/factory/post_type/_view/AdminPageFramework_PageLoadInfo_post_type.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
         if ( in_array( $oProp->sClassName, self::$aClassNames ) )
             return self::$_oInstance;
         
-        self::$aClassNames[] = $oProp->sClassName;
+        self::$aClassNames[ ] = $oProp->sClassName;
         self::$_oInstance = new AdminPageFramework_PageLoadInfo_post_type( $oProp, $oMsg );
         
         return self::$_oInstance;

Braces +5 added lines, -3 removed lines

@@ -26,8 +26,9 @@ 
      */
     public static function instantiate( $oProp, $oMsg ) {
         
-        if ( in_array( $oProp->sClassName, self::$aClassNames ) )
-            return self::$_oInstance;
+        if ( in_array( $oProp->sClassName, self::$aClassNames ) ) {
+                    return self::$_oInstance;
+        }
         
         self::$aClassNames[] = $oProp->sClassName;
         self::$_oInstance = new AdminPageFramework_PageLoadInfo_post_type( $oProp, $oMsg );
@@ -43,7 +44,8 @@ 
     public function _replyToSetPageLoadInfoInFooter() {
 
         // Some users set `$_GET[ 'post_type' ]` element even in regular admin pages. In that case, do not load the style to avoid duplicates.
-        if ( isset( $_GET[ 'page' ] ) && $_GET[ 'page' ] ) {    // sanitization unnecessary
+        if ( isset( $_GET[ 'page' ] ) && $_GET[ 'page' ] ) {
+// sanitization unnecessary
             return;
         }
     

development/factory/post_type/_controller/AdminPageFramework_Link_post_type.php

Spacing +8 added lines, -8 removed lines

@@ -21,7 +21,7 @@ 
      * Sets up hooks and properties.
      *
      */
-    public function __construct( $oProp, $oMsg=null ) {
+    public function __construct( $oProp, $oMsg = null ) {
 
         parent::__construct( $oProp, $oMsg );
 
@@ -59,7 +59,7 @@ 
         );
 
         // If the user explicitly sets an empty string to the label key, do not insert a link.
-        if ( ! $_sLinkLabel ) {
+        if ( !$_sLinkLabel ) {
             return $aLinks;
         }
 
@@ -67,13 +67,13 @@ 
         array_unshift(
             $aLinks,
             // "<a href='" . esc_url( "edit.php?post_type={$this->oProp->sPostType}" ) . "'>"
-            '<a ' . $this->getAttributes(
+            '<a '.$this->getAttributes(
                 array(
                     'href'      => esc_url( "edit.php?post_type={$this->oProp->sPostType}" ),
                     // 3.5.7+ Added for acceptance testing
                     'class'     => 'apf-plugin-title-action-link apf-admin-page',
                 )
-            ) . '>'
+            ).'>'
                 . $_sLinkLabel
             . "</a>"
         );
@@ -89,9 +89,9 @@ 
     public function _replyToSetFooterInfo() {
 
         if (
-            ! $this->isPostDefinitionPage( $this->oProp->sPostType )
-            && ! $this->isPostListingPage( $this->oProp->sPostType )
-            && ! $this->isCustomTaxonomyPage( $this->oProp->sPostType )
+            !$this->isPostDefinitionPage( $this->oProp->sPostType )
+            && !$this->isPostListingPage( $this->oProp->sPostType )
+            && !$this->isCustomTaxonomyPage( $this->oProp->sPostType )
         ) {
             return;
         }
@@ -109,7 +109,7 @@ 
      * @remark      e.g. `http://.../wp-admin/post.php?post=180&action=edit` -> `http://.../wp-admin/post.php?post=180&action=edit&post_type=[...]`
      * @callback    filter      get_edit_post_link
      */
-    public function _replyToAddPostTypeQueryInEditPostLink( $sURL, $iPostID=null, $sContext=null ) {
+    public function _replyToAddPostTypeQueryInEditPostLink( $sURL, $iPostID = null, $sContext = null ) {
         return add_query_arg(
             array(
                 'post'      => $iPostID,

Braces +2 added lines, -1 removed lines

@@ -26,7 +26,8 @@
         parent::__construct( $oProp, $oMsg );
 
         // For post type posts listing table page ( edit.php )
-        if ( isset( $_GET[ 'post_type' ] ) && $_GET[ 'post_type' ] === $this->oProp->sPostType ) {  // sanitization unnecessary
+        if ( isset( $_GET[ 'post_type' ] ) && $_GET[ 'post_type' ] === $this->oProp->sPostType ) {
+// sanitization unnecessary
             add_action(
                 'get_edit_post_link',
                 array( $this, '_replyToAddPostTypeQueryInEditPostLink' ),

development/factory/meta_box/AdminPageFramework_MetaBox_Model.php

Spacing +21 added lines, -21 removed lines

@@ -28,12 +28,12 @@ 
      * @param       string $sTextDomain
      * @since       3.7.9
      */
-    public function __construct( $sMetaBoxID, $sTitle, $asPostTypeOrScreenID=array( 'post' ), $sContext='normal', $sPriority='default', $sCapability='edit_posts', $sTextDomain='admin-page-framework' ) {
+    public function __construct( $sMetaBoxID, $sTitle, $asPostTypeOrScreenID = array( 'post' ), $sContext = 'normal', $sPriority = 'default', $sCapability = 'edit_posts', $sTextDomain = 'admin-page-framework' ) {
 
         // This is important to set the hooks before the parent constructor
         // as the setUp wil be called in there if the default action hook (current_screen) is already triggered.
-        add_action( 'set_up_' . $this->oProp->sClassName, array( $this, '_replyToSetUpHooks' ) );
-        add_action( 'set_up_' . $this->oProp->sClassName, array( $this, '_replyToSetUpValidationHooks' ) );
+        add_action( 'set_up_'.$this->oProp->sClassName, array( $this, '_replyToSetUpHooks' ) );
+        add_action( 'set_up_'.$this->oProp->sClassName, array( $this, '_replyToSetUpValidationHooks' ) );
 
         parent::__construct(
             $sMetaBoxID,
@@ -115,14 +115,14 @@ 
      * @callback    add_meta_boxes
      */
     public function _replyToRegisterMetaBoxes() {
-        foreach( $this->oProp->aPostTypes as $_sPostType ) {
+        foreach ( $this->oProp->aPostTypes as $_sPostType ) {
             add_meta_box(
-                $this->oProp->sMetaBoxID,                       // id
-                $this->oProp->sTitle,                           // title
+                $this->oProp->sMetaBoxID, // id
+                $this->oProp->sTitle, // title
                 array( $this, '_replyToPrintMetaBoxContents' ), // callback
-                $_sPostType,                                    // post type
-                $this->oProp->sContext,                         // context
-                $this->oProp->sPriority,                        // priority
+                $_sPostType, // post type
+                $this->oProp->sContext, // context
+                $this->oProp->sPriority, // priority
                 null                                            // argument - deprecated $this->oForm->aFields
             );
         }
@@ -154,18 +154,18 @@ 
          * @internal
          * @return      integer     The found post ID. `0` if not found.
          */
-        private function ___getPostID()  {
+        private function ___getPostID() {
 
             // for an editing post page.
             if ( isset( $GLOBALS[ 'post' ]->ID ) ) {
                 return $GLOBALS[ 'post' ]->ID;
             }
             if ( isset( $_GET[ 'post' ] ) ) {   // sanitization unnecessary
-                return absint( $_GET[ 'post' ] );   // sanitization done
+                return absint( $_GET[ 'post' ] ); // sanitization done
             }
             // for post.php without any query key-values.
             if ( isset( $_POST[ 'post_ID' ] ) ) {       // sanitization unnecessary
-                return absint( $_POST[ 'post_ID' ] );   // sanitization done
+                return absint( $_POST[ 'post_ID' ] ); // sanitization done
             }
             return 0;
 
@@ -186,14 +186,14 @@ 
     public function _replyToFilterSavingData( $aPostData, $aUnmodified ) {
 
         // Perform initial checks.
-        if ( ! $this->_shouldProceedValidation( $aUnmodified ) ) {
+        if ( !$this->_shouldProceedValidation( $aUnmodified ) ) {
             return $aPostData;
         }
 
         // Retrieve the submitted data.
-        $_aInputs       = $this->oForm->getSubmittedData(
-            $this->oForm->getHTTPRequestSanitized( $_POST, false ),     // subject data to be parsed. Will be sanitized in the method  // sanitization done
-            true,       // extract data with the fieldset structure
+        $_aInputs = $this->oForm->getSubmittedData(
+            $this->oForm->getHTTPRequestSanitized( $_POST, false ), // subject data to be parsed. Will be sanitized in the method  // sanitization done
+            true, // extract data with the fieldset structure
             false       // strip slashes
         );
         $_aInputsRaw    = $_aInputs; // store one for the last input array.
@@ -228,8 +228,8 @@ 
         }
 
         $this->oForm->updateMetaDataByType(
-            $_iPostID,   // object id
-            $_aInputs,   // user submit form data
+            $_iPostID, // object id
+            $_aInputs, // user submit form data
             $this->oForm->dropRepeatableElements( $_aSavedMeta ), // Drop repeatable section elements from the saved meta array.
             $this->oForm->sStructureType   // fields type
         );
@@ -288,14 +288,14 @@ 
             }
 
             // If our nonce isn't there, or we can't verify it, bail
-            if ( ! isset( $_POST[ $this->oProp->sMetaBoxID ] ) ) {  // sanitization unnecessary
+            if ( !isset( $_POST[ $this->oProp->sMetaBoxID ] ) ) {  // sanitization unnecessary
                 return false;
             }
-            if ( ! wp_verify_nonce( $_POST[ $this->oProp->sMetaBoxID ], $this->oProp->sMetaBoxID ) ) {  // sanitization unnecessary
+            if ( !wp_verify_nonce( $_POST[ $this->oProp->sMetaBoxID ], $this->oProp->sMetaBoxID ) ) {  // sanitization unnecessary
                 return false;
             }
 
-            if ( ! in_array( $aUnmodified[ 'post_type' ], $this->oProp->aPostTypes, true ) ) {
+            if ( !in_array( $aUnmodified[ 'post_type' ], $this->oProp->aPostTypes, true ) ) {
                 return false;
             }
 

Braces +9 added lines, -5 removed lines

@@ -154,17 +154,19 @@ 
          * @internal
          * @return      integer     The found post ID. `0` if not found.
          */
-        private function ___getPostID()  {
+        private function ___getPostID() {
 
             // for an editing post page.
             if ( isset( $GLOBALS[ 'post' ]->ID ) ) {
                 return $GLOBALS[ 'post' ]->ID;
             }
-            if ( isset( $_GET[ 'post' ] ) ) {   // sanitization unnecessary
+            if ( isset( $_GET[ 'post' ] ) ) {
+// sanitization unnecessary
                 return absint( $_GET[ 'post' ] );   // sanitization done
             }
             // for post.php without any query key-values.
-            if ( isset( $_POST[ 'post_ID' ] ) ) {       // sanitization unnecessary
+            if ( isset( $_POST[ 'post_ID' ] ) ) {
+// sanitization unnecessary
                 return absint( $_POST[ 'post_ID' ] );   // sanitization done
             }
             return 0;
@@ -288,10 +290,12 @@ 
             }
 
             // If our nonce isn't there, or we can't verify it, bail
-            if ( ! isset( $_POST[ $this->oProp->sMetaBoxID ] ) ) {  // sanitization unnecessary
+            if ( ! isset( $_POST[ $this->oProp->sMetaBoxID ] ) ) {
+// sanitization unnecessary
                 return false;
             }
-            if ( ! wp_verify_nonce( $_POST[ $this->oProp->sMetaBoxID ], $this->oProp->sMetaBoxID ) ) {  // sanitization unnecessary
+            if ( ! wp_verify_nonce( $_POST[ $this->oProp->sMetaBoxID ], $this->oProp->sMetaBoxID ) ) {
+// sanitization unnecessary
                 return false;
             }
 

development/factory/_common/_abstract/AdminPageFramework_Factory_Router.php

Spacing +20 added lines, -20 removed lines

@@ -169,8 +169,8 @@ 
         }
 
         // Call the user constructor.
-        $this->start();     // defined in the controller class.
-        $this->oUtil->addAndDoAction( $this, 'start_' . $this->oProp->sClassName, $this );
+        $this->start(); // defined in the controller class.
+        $this->oUtil->addAndDoAction( $this, 'start_'.$this->oProp->sClassName, $this );
 
     }
         /**
@@ -179,8 +179,8 @@ 
          * @return      array
          */
         private function ___getSubClassNames() {
-            foreach( $this->_aSubClassPrefixes as $_sObjectVariableName => $_sPrefix ) {
-                $this->aSubClassNames[ $_sObjectVariableName ] = $_sPrefix . $this->_sStructureType;
+            foreach ( $this->_aSubClassPrefixes as $_sObjectVariableName => $_sPrefix ) {
+                $this->aSubClassNames[ $_sObjectVariableName ] = $_sPrefix.$this->_sStructureType;
             }
             return $this->aSubClassNames + $this->_aSubClassNames;
         }
@@ -194,15 +194,15 @@ 
      */
     public function _replyToLoadComponents( /* $oScreen */ ) {
 
-        if ( ! $this->_isInThePage() ) {
+        if ( !$this->_isInThePage() ) {
             return;
         }
 
-        if ( ! isset( $this->oResource ) ) {
+        if ( !isset( $this->oResource ) ) {
             $this->oResource = $this->_replyTpSetAndGetInstance_oResource();
         }
 
-        if ( ! isset(  $this->oLink ) ) {
+        if ( !isset( $this->oLink ) ) {
             $this->oLink = $this->_replyTpSetAndGetInstance_oLink();
         }
 
@@ -216,10 +216,10 @@ 
      * Calls the load method and callbacks.
      * @since       3.8.14
      */
-    protected function _load( $aActions=array() ) {
+    protected function _load( $aActions = array() ) {
         $aActions = empty( $aActions )
             ? array(
-                'load_' . $this->oProp->sClassName,
+                'load_'.$this->oProp->sClassName,
             )
             : $aActions;
         $this->load();
@@ -231,7 +231,7 @@ 
      */
     protected function _setUp() {
         $aActions = array(
-            'set_up_' . $this->oProp->sClassName,
+            'set_up_'.$this->oProp->sClassName,
         );
         $this->setUp();
         $this->oUtil->addAndDoActions( $this, $aActions, $this );
@@ -258,14 +258,14 @@ 
          * @since   3.8.19
          */
         protected function _isWordPressCoreAjaxRequest() {
-            if ( ! isset( $GLOBALS[ 'pagenow' ] ) ) {
+            if ( !isset( $GLOBALS[ 'pagenow' ] ) ) {
                 return false;
             }
             if ( 'admin-ajax.php' !== $GLOBALS[ 'pagenow' ] ) {
                 return false;
             }
             return in_array(
-                isset( $_POST[ 'action' ] ) ? $_POST[ 'action' ] : '',  // sanitization unnecessary as just checking
+                isset( $_POST[ 'action' ] ) ? $_POST[ 'action' ] : '', // sanitization unnecessary as just checking
                 array( 'heartbeat', 'closed-postboxes', 'meta-box-order' ),
                 true
             );
@@ -293,7 +293,7 @@ 
      * @return  boolean
      */
     protected function _isValidAjaxReferrer() {
-        if ( ! $this->oProp->bIsAdminAjax ) {
+        if ( !$this->oProp->bIsAdminAjax ) {
             return false;
         }
         return true;
@@ -309,7 +309,7 @@ 
      */
     public function _replyToDetermineToLoad() {
 
-        if ( ! $this->_isInThePage() ) {
+        if ( !$this->_isInThePage() ) {
             return;
         }
 
@@ -375,7 +375,7 @@ 
         // Set and return the sub class object instance.
         if ( isset( $this->aSubClassNames[ $sPropertyName ] ) ) {
             return call_user_func(
-                array( $this, "_replyTpSetAndGetInstance_{$sPropertyName}"  )
+                array( $this, "_replyTpSetAndGetInstance_{$sPropertyName}" )
             );
         }
 
@@ -409,7 +409,7 @@ 
          */
         public function _replyTpSetAndGetInstance_oMsg() {
             $this->oMsg = call_user_func_array(
-                array( $this->aSubClassNames[ 'oMsg' ], 'getInstance'),
+                array( $this->aSubClassNames[ 'oMsg' ], 'getInstance' ),
                 array( $this->oProp->sTextDomain )  // parameters
             );
             return $this->oMsg;
@@ -474,7 +474,7 @@ 
      *
      * @internal
      */
-    public function __call( $sMethodName, $aArguments=null ) {
+    public function __call( $sMethodName, $aArguments = null ) {
 
         $_mFirstArg = $this->oUtil->getElement( $aArguments, 0 );
 
@@ -504,7 +504,7 @@ 
 
             // Check if the method name does not contain a backslash.
             if ( false === strpos( $sMethodName, "\\" ) ) {
-                return $this->oUtil->getElement( $aArguments, 0 );  // the first element - the filter value
+                return $this->oUtil->getElement( $aArguments, 0 ); // the first element - the filter value
             }
 
             // If the method name contains a backslash, the user may be using a name space.
@@ -515,7 +515,7 @@ 
                     array( $this, $_sAutoCallbackMethodName ),
                     $aArguments
                 )
-                : $this->oUtil->getElement( $aArguments, 0 );   // the first argument
+                : $this->oUtil->getElement( $aArguments, 0 ); // the first argument
 
         }
 
@@ -525,7 +525,7 @@ 
          */
         private function _triggerUndefinedMethodWarning( $sMethodName ) {
             trigger_error(
-                AdminPageFramework_Registry::NAME . ': '
+                AdminPageFramework_Registry::NAME.': '
                     . sprintf(
                         __( 'The method is not defined: %1$s', $this->oProp->sTextDomain ),
                         $sMethodName

development/factory/_common/_abstract/_model/AdminPageFramework_Property_Base.php

Spacing +16 added lines, -16 removed lines

@@ -320,7 +320,7 @@ 
         'caller_id'                         => '',
         'structure_type'                    => '',
         'action_hook_form_registration'     => '',
-        'autoload_min_resource'             => true,    // will be overridden by the $bAutoloadMinifiedResource property.
+        'autoload_min_resource'             => true, // will be overridden by the $bAutoloadMinifiedResource property.
     );
 
     /**
@@ -328,14 +328,14 @@ 
      * @since       3.7.0
      */
     public $aFormCallbacks = array(
-        'hfID'              => null,    // the input id attribute
-        'hfTagID'           => null,    // the field container id attribute
-        'hfName'            => null,    // the field name attribute
-        'hfNameFlat'        => null,    // the flat field name attribute
+        'hfID'              => null, // the input id attribute
+        'hfTagID'           => null, // the field container id attribute
+        'hfName'            => null, // the field name attribute
+        'hfNameFlat'        => null, // the flat field name attribute
         // @todo Document the differences between `hfName` and `hfInputName`
-        'hfInputName'       => null,    // 3.6.0+   the field input name attribute
-        'hfInputNameFlat'   => null,    // 3.6.0+   the flat field input name
-        'hfClass'           => null,    // the class attribute
+        'hfInputName'       => null, // 3.6.0+   the field input name attribute
+        'hfInputNameFlat'   => null, // 3.6.0+   the flat field input name
+        'hfClass'           => null, // the class attribute
     );
 
     /**
@@ -468,7 +468,7 @@ 
              * @internal
              */
             private function ___getURLQuery() {
-                if ( ! $this->bIsAdminAjax ) {
+                if ( !$this->bIsAdminAjax ) {
                     return $this->getHTTPQueryGET( array(), array() );
                 }
                 parse_str(
@@ -483,7 +483,7 @@ 
          * @since       3.7.9
          */
         private function ___setGlobals() {
-            if ( ! isset( $GLOBALS[ 'aAdminPageFramework' ] ) ) {
+            if ( !isset( $GLOBALS[ 'aAdminPageFramework' ] ) ) {
                 $GLOBALS[ 'aAdminPageFramework' ] = array(
                     'aFieldFlags' => array()
                 );
@@ -511,7 +511,7 @@ 
             'action_hook_form_registration'     => $this->bIsAdminAjax
                 ? 'admin_init'  // 3.8.14
                 : $this->_sFormRegistrationHook,
-            'autoload_min_resource'             => $this->bAutoloadMinifiedResource,    // [3.8.31]
+            'autoload_min_resource'             => $this->bAutoloadMinifiedResource, // [3.8.31]
         ) + $this->aFormArguments;
     }
     /**
@@ -555,8 +555,8 @@ 
             'hfTagID'                           => array( $this->oCaller, '_replyToGetInputTagIDAttribute' ), // the fields & fieldset & field row container id attribute
             'hfName'                            => array( $this->oCaller, '_replyToGetFieldNameAttribute' ), // the input name attribute
             'hfNameFlat'                        => array( $this->oCaller, '_replyToGetFlatFieldName' ), // the flat input name attribute
-            'hfInputName'                       => array( $this->oCaller, '_replyToGetInputNameAttribute' ),    // 3.6.0+   the field input name attribute
-            'hfInputNameFlat'                   => array( $this->oCaller, '_replyToGetFlatInputName' ),    // 3.6.0+   the flat field input name
+            'hfInputName'                       => array( $this->oCaller, '_replyToGetInputNameAttribute' ), // 3.6.0+   the field input name attribute
+            'hfInputNameFlat'                   => array( $this->oCaller, '_replyToGetFlatInputName' ), // 3.6.0+   the flat field input name
             'hfClass'                           => array( $this->oCaller, '_replyToGetInputClassAttribute' ), // the class attribute
             'hfSectionName'                     => array( $this->oCaller, '_replyToGetSectionName' ), // 3.6.0+
         ) + $this->aFormCallbacks;
@@ -630,7 +630,7 @@ 
      * @remark      The information can be used to embed into the footer etc.
      * @return      array       The information of the script.
      */
-    protected function getCallerInfo( $sCallerPath='' ) {
+    protected function getCallerInfo( $sCallerPath = '' ) {
 
         if ( isset( self::$_aScriptDataCaches[ $sCallerPath ] ) ) {
             return self::$_aScriptDataCaches[ $sCallerPath ];
@@ -748,11 +748,11 @@ 
 
         // 3.7.9 Moved from the constructor to make it lighter.
         if ( 'sClassHash' === $sName ) {
-            $this->sClassHash       = md5( $this->sClassName );
+            $this->sClassHash = md5( $this->sClassName );
             return $this->sClassHash;
         }
         if ( 'sScriptType' === $sName ) {
-            $this->sScriptType      = $this->_getCallerType( $this->sCallerPath );    // 3.7.6+
+            $this->sScriptType = $this->_getCallerType( $this->sCallerPath ); // 3.7.6+
             return $this->sScriptType;
         }
         if ( 'oUtil' === $sName ) {

development/factory/_common/_abstract/_model/AdminPageFramework_Message.php

Spacing +17 added lines, -17 removed lines

@@ -83,11 +83,11 @@ 
         'nonce_verification_failed'             => 'A problem occurred while processing the form data. Please try again.',
         'check_max_input_vars'                  => 'Not all form fields could not be sent. '
             . 'Please check your server settings of PHP <code>max_input_vars</code> and consult the server administrator to increase the value. '
-            . '<code>max input vars</code>: %1$s. <code>$_POST</code> count: %2$s',  // 3.5.11+ // sanitization unnecessary as it is just a literal string
-        'send_email'                            => 'Is it okay to send the email?',     // 3.3.0+
-        'email_sent'                            => 'The email has been sent.',  // 3.3.0+, 3.3.5+ deprecated, 3.8.32 Re-added
+            . '<code>max input vars</code>: %1$s. <code>$_POST</code> count: %2$s', // 3.5.11+ // sanitization unnecessary as it is just a literal string
+        'send_email'                            => 'Is it okay to send the email?', // 3.3.0+
+        'email_sent'                            => 'The email has been sent.', // 3.3.0+, 3.3.5+ deprecated, 3.8.32 Re-added
         'email_scheduled'                       => 'The email has been scheduled.', // 3.3.5+, 3.8.32 deprecated
-        'email_could_not_send'                  => 'There was a problem sending the email',     // 3.3.0+
+        'email_could_not_send'                  => 'There was a problem sending the email', // 3.3.0+
 
         // AdminPageFramework_PostType
         'title'                                 => 'Title',
@@ -114,14 +114,14 @@ 
         'upload_file'                           => 'Upload File',
         'use_this_file'                         => 'Use This File',
         'select_file'                           => 'Select File',
-        'remove_value'                          => 'Remove Value',  // 3.2.0+
-        'select_all'                            => 'Select All',    // 3.3.0+
-        'select_none'                           => 'Select None',   // 3.3.0+
+        'remove_value'                          => 'Remove Value', // 3.2.0+
+        'select_all'                            => 'Select All', // 3.3.0+
+        'select_none'                           => 'Select None', // 3.3.0+
         'no_term_found'                         => 'No term found.', // 3.3.2+
 
         // AdminPageFramework_Form_View___Script_{...}
         'select'                                => 'Select', // 3.4.2+
-        'insert'                                => 'Insert',  // 3.4.2+
+        'insert'                                => 'Insert', // 3.4.2+
         'use_this'                              => 'Use This', // 3.4.2+
         'return_to_library'                     => 'Return to Library', // 3.4.2+
 
@@ -133,8 +133,8 @@ 
 
         // Repeatable sections & fields
         'repeatable_section_is_disabled'        => 'The ability to repeat sections is disabled.', // 3.8.13+
-        'repeatable_field_is_disabled'          => 'The ability to repeat fields is disabled.',   // 3.8.13+
-        'warning_caption'                       => 'Warning',   // 3.8.13+
+        'repeatable_field_is_disabled'          => 'The ability to repeat fields is disabled.', // 3.8.13+
+        'warning_caption'                       => 'Warning', // 3.8.13+
 
         // AdminPageFramework_FormField
         'allowed_maximum_number_of_fields'      => 'The allowed maximum number of fields is {0}.',
@@ -216,7 +216,7 @@ 
      * @remark      This class should be instantiated via this method.
      * @return      AdminPageFramework_Message
      */
-    public static function getInstance( $sTextDomain='admin-page-framework' ) {
+    public static function getInstance( $sTextDomain = 'admin-page-framework' ) {
 
         $_oInstance = isset( self::$_aInstancesByTextDomain[ $sTextDomain ] ) && ( self::$_aInstancesByTextDomain[ $sTextDomain ] instanceof AdminPageFramework_Message )
             ? self::$_aInstancesByTextDomain[ $sTextDomain ]
@@ -229,7 +229,7 @@ 
          * Ensures that only one instance of this class object exists. ( no multiple instances of this object )
          * @deprecated  3.2.0
          */
-        public static function instantiate( $sTextDomain='admin-page-framework' ) {
+        public static function instantiate( $sTextDomain = 'admin-page-framework' ) {
             return self::getInstance( $sTextDomain );
         }
 
@@ -237,14 +237,14 @@ 
      * Sets up properties.
      * @param string $sTextDomain
      */
-    public function __construct( $sTextDomain='admin-page-framework' ) {
+    public function __construct( $sTextDomain = 'admin-page-framework' ) {
 
         $this->_sTextDomain = $sTextDomain;
 
         // Fill the $aMessages property with the keys extracted from the $aDefaults property
         // with the value of null.  The null is set to let it trigger the __get() method
         // so that each translation item gets processed individually.
-        $this->aMessages    = array_fill_keys(
+        $this->aMessages = array_fill_keys(
             array_keys( $this->aDefaults ),
             null
         );
@@ -279,13 +279,13 @@ 
      * @param       string       $sKey
      * @return      string|array
      */
-    public function get( $sKey='' ) {
-        if ( ! $sKey ) {
+    public function get( $sKey = '' ) {
+        if ( !$sKey ) {
             return $this->_getAllMessages();
         }
         return isset( $this->aMessages[ $sKey ] )
             ? __( $this->aMessages[ $sKey ], $this->_sTextDomain )
-            : __( $this->{$sKey}, $this->_sTextDomain );     // triggers __get()
+            : __( $this->{$sKey}, $this->_sTextDomain ); // triggers __get()
     }
         /**
          * Returns the all registered messag items.

development/factory/_common/form/AdminPageFramework_Form_Utility.php

Spacing +20 added lines, -20 removed lines

@@ -43,16 +43,16 @@ 
      * For the `admin_page` fields type, an option key is prepended.
      * For `page_meta_box`, no prepended element and it starts with the section or field ID.
      */
-    static public function getInputsUnset( array $aInputs, $sFieldsType, $iSkipDepth=0 ) {
+    static public function getInputsUnset( array $aInputs, $sFieldsType, $iSkipDepth = 0 ) {
 
-        $_sUnsetKey = '__unset_' . $sFieldsType;
-        if ( ! isset( $_POST[ $_sUnsetKey ] ) ) { // sanitization unnecessary
+        $_sUnsetKey = '__unset_'.$sFieldsType;
+        if ( !isset( $_POST[ $_sUnsetKey ] ) ) { // sanitization unnecessary
             return $aInputs;
         }
 
-        $_aUnsetElements = self::getHTTPRequestSanitized( self::getElementAsArray( $_POST, array( $_sUnsetKey ) ) );    // sanitization done
+        $_aUnsetElements = self::getHTTPRequestSanitized( self::getElementAsArray( $_POST, array( $_sUnsetKey ) ) ); // sanitization done
         $_aUnsetElements = array_unique( $_aUnsetElements );
-        foreach( $_aUnsetElements as $_sFlatInputName ) {
+        foreach ( $_aUnsetElements as $_sFlatInputName ) {
 
             $_aDimensionalKeys = explode( '|', $_sFlatInputName );
 
@@ -62,7 +62,7 @@ 
             }
 
             // The first element is the option key for the `admin_page` field type and section or field dimensional keys follow.
-            for ( $_i = 0; $_i < $iSkipDepth; $_i++) {
+            for ( $_i = 0; $_i < $iSkipDepth; $_i++ ) {
                 unset( $_aDimensionalKeys[ $_i ] );
             }
 
@@ -119,7 +119,7 @@ 
      */
     static public function hasNestedFields( $aFieldset ) {
         
-        if ( ! self::hasFieldDefinitionsInContent( $aFieldset ) ) {
+        if ( !self::hasFieldDefinitionsInContent( $aFieldset ) ) {
             return false;
         }
         // At this point, the `content` argument contains either the definition of nested fields or inline-mixed fields.
@@ -141,7 +141,7 @@ 
      */
     static public function hasFieldDefinitionsInContent( $aFieldset ) {
         
-        if ( ! isset( $aFieldset[ 'content' ] ) ) {
+        if ( !isset( $aFieldset[ 'content' ] ) ) {
             return false;
         }
         if ( empty( $aFieldset[ 'content' ] ) ) {
@@ -176,10 +176,10 @@ 
      * @since       3.8.13
      */
     static public function isDynamicField( $aField ) {
-        if ( ! empty( $aField[ 'repeatable' ] ) ) {
+        if ( !empty( $aField[ 'repeatable' ] ) ) {
             return true;
         }
-        if ( ! empty( $aField[ 'sortable' ] ) ) {
+        if ( !empty( $aField[ 'sortable' ] ) ) {
             return true;
         }
         return false;
@@ -208,7 +208,7 @@ 
         if ( empty( $sString ) ) {
             return $sString;
         }
-        return $sString . '|';
+        return $sString.'|';
     }
 
     /**
@@ -224,17 +224,17 @@ 
      */
     static public function getFieldsetReformattedBySubFieldIndex( $aFieldset, $iSubFieldIndex, $bHasSubFields, $aParentFieldset ) {
 
-        $_oCallerForm   = $aFieldset[ '_caller_object' ];
+        $_oCallerForm = $aFieldset[ '_caller_object' ];
 
         // Add sub-field index to the parent field path for repeated nested items.
-        $aFieldset[ '_parent_field_path' ]   = self::getAOrB(
+        $aFieldset[ '_parent_field_path' ] = self::getAOrB(
             $bHasSubFields,
-            $aFieldset[ '_parent_field_path' ] . '|' . $iSubFieldIndex,
+            $aFieldset[ '_parent_field_path' ].'|'.$iSubFieldIndex,
             $aFieldset[ '_parent_field_path' ]
         );
-        $aFieldset[ '_parent_tag_id' ]       = self::getAOrB(
+        $aFieldset[ '_parent_tag_id' ] = self::getAOrB(
             $bHasSubFields,
-            $aParentFieldset[ 'tag_id' ] . '__' . $iSubFieldIndex,
+            $aParentFieldset[ 'tag_id' ].'__'.$iSubFieldIndex,
             $aParentFieldset[ 'tag_id' ]
         );
 
@@ -243,7 +243,7 @@ 
             $aFieldset,
             $aFieldset[ '_structure_type' ],
             $aFieldset[ 'capability' ],
-            ( integer ) $iSubFieldIndex + 1,   // 1-based count (not index)
+            ( integer ) $iSubFieldIndex + 1, // 1-based count (not index)
             $aFieldset[ '_subsection_index' ],
             $aFieldset[ '_is_section_repeatable' ],
             $aFieldset[ '_caller_object' ]
@@ -252,7 +252,7 @@ 
 
         $_oFieldsetOutputFormatter = new AdminPageFramework_Form_Model___Format_FieldsetOutput(
             $aFieldset,
-            $aFieldset[ '_section_index' ],    // `_section_index` is defined in the ...FieldsetOutput class. Since this is a nested item, it should be already set.
+            $aFieldset[ '_section_index' ], // `_section_index` is defined in the ...FieldsetOutput class. Since this is a nested item, it should be already set.
             $_oCallerForm->aFieldTypeDefinitions
         );
         return $_oFieldsetOutputFormatter->get();
@@ -289,12 +289,12 @@ 
         if ( empty( $aArguments ) ) {
             return '';
         }
-        if ( self::hasBeenCalled( 'disabled_repeatable_elements_modal_' . $sBoxElementID ) ) {
+        if ( self::hasBeenCalled( 'disabled_repeatable_elements_modal_'.$sBoxElementID ) ) {
             return '';
         }
         add_thickbox(); // to display a message to the user.
         return "<div id='{$sBoxElementID}' style='display:none'>"
-                . "<p>" . $aArguments[ 'message' ] . "</p>"
+                . "<p>".$aArguments[ 'message' ]."</p>"
             . "</div>";
 
     }

Braces +2 added lines, -1 removed lines

@@ -46,7 +46,8 @@
     static public function getInputsUnset( array $aInputs, $sFieldsType, $iSkipDepth=0 ) {
 
         $_sUnsetKey = '__unset_' . $sFieldsType;
-        if ( ! isset( $_POST[ $_sUnsetKey ] ) ) { // sanitization unnecessary
+        if ( ! isset( $_POST[ $_sUnsetKey ] ) ) {
+// sanitization unnecessary
             return $aInputs;
         }
 

development/factory/_common/form/notice/AdminPageFramework_Form___SubmitNotice.php

Spacing +9 added lines, -9 removed lines

@@ -40,7 +40,7 @@ 
          * @return      string
          */
         private function _getTransientKey() {
-            return 'apf_ntc_' . get_current_user_id();
+            return 'apf_ntc_'.get_current_user_id();
         }
     
     /**
@@ -52,14 +52,14 @@ 
      * @param       string      $sType If empty, the method will check if a message exists in all types. Otherwise, it checks the existence of a message of the specified type.
      * @return      boolean     True if a setting notice is set; otherwise, false.
      */
-    public function hasNotice( $sType='' ) {
+    public function hasNotice( $sType = '' ) {
                 
-        if ( ! $sType ) {
+        if ( !$sType ) {
             return ( boolean ) count( self::$_aNotices );
         }
         
         // Check if there is a message of the type.
-        foreach( self::$_aNotices as $_aNotice ) {
+        foreach ( self::$_aNotices as $_aNotice ) {
             $_sClassAttribute = $this->getElement( 
                 $_aNotice, 
                 array( 
@@ -98,7 +98,7 @@ 
      * @param        boolean     $bOverride      (optional) If true, only one message will be shown in the next page load. false: do not override when there is a message of the same id. true: override the previous one.
      * @return       void
      */
-    public function set( $sMessage, $sType='error', $asAttributes=array(), $bOverride=true ) {
+    public function set( $sMessage, $sType = 'error', $asAttributes = array(), $bOverride = true ) {
         
         // If the array is empty, schedule the task of saving the array at shutdown.
         if ( empty( self::$_aNotices ) ) {
@@ -108,7 +108,7 @@ 
         $_sID = md5( trim( $sMessage ) );
             
         // If the override is false and a message is already set, do not add.
-        if ( ! $bOverride && isset( self::$_aNotices[ $_sID ] ) ) {
+        if ( !$bOverride && isset( self::$_aNotices[ $_sID ] ) ) {
             return;
         }
 
@@ -118,14 +118,14 @@ 
         }
         
         $_aAttributes = $this->getAsArray( $asAttributes );
-        if ( is_string( $asAttributes ) && ! empty( $asAttributes ) ) {
+        if ( is_string( $asAttributes ) && !empty( $asAttributes ) ) {
             $_aAttributes[ 'id' ] = $asAttributes;
         }
         self::$_aNotices[ $_sID ] = array(
             'sMessage'      => $sMessage,
             'aAttributes'   => $_aAttributes + array(
                 'class'     => $sType,
-                'id'        => 'form_submit_notice_' . $_sID,
+                'id'        => 'form_submit_notice_'.$_sID,
             ),
         );
 
@@ -166,7 +166,7 @@ 
         }
             
         // By setting false to the 'settings-notice' key, it's possible to disable the notifications set with the framework.
-        if ( isset( $_GET[ 'settings-notice' ] ) && ! $_GET[ 'settings-notice' ] ) {    // sanitization unnecessary
+        if ( isset( $_GET[ 'settings-notice' ] ) && !$_GET[ 'settings-notice' ] ) {    // sanitization unnecessary
             return; 
         }
             

Braces +4 added lines, -3 removed lines

@@ -141,7 +141,7 @@ 
          * @return      void
          */
         public function _replyToSaveNotices() {
-            if ( empty( self::$_aNotices ) ) { 
+            if ( empty( self::$_aNotices ) ) {
                 return; 
             }            
             $_bResult = $this->setTransient( 
@@ -161,12 +161,13 @@ 
         
         // Retrieve the notifications set in a transient.
         $_aNotices = $this->_getNotices();
-        if ( false === $_aNotices ) { 
+        if ( false === $_aNotices ) {
             return; 
         }
             
         // By setting false to the 'settings-notice' key, it's possible to disable the notifications set with the framework.
-        if ( isset( $_GET[ 'settings-notice' ] ) && ! $_GET[ 'settings-notice' ] ) {    // sanitization unnecessary
+        if ( isset( $_GET[ 'settings-notice' ] ) && ! $_GET[ 'settings-notice' ] ) {
+// sanitization unnecessary
             return; 
         }