michaeluno / admin-page-framework

development/factory/_common/form/_view/attribute/AdminPageFramework_Form_View___Attribute_Field.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
      * Returns the field container attribute array.
      * 
      * @remark      Formatting each sub-field should be performed prior to callign this method.
-     * @param       array       $aField     The (sub-)field definition array. This should have been formatted already.
      * @return      array       The generated field container attribute array.
      * @internal   
      * @since       3.5.3

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
      * 
      * @since       3.6.0
      */
-    public $sContext    = 'field'; 
+    public $sContext = 'field'; 
 
     /**
      * Returns the field container attribute array.
@@ -41,10 +41,10 @@ 
 
         return array(
             'id'            => $this->aArguments[ '_field_container_id' ],
-            'data-type'     => $this->aArguments[ 'type' ],   // referred by the repeatable field JavaScript script.
+            'data-type'     => $this->aArguments[ 'type' ], // referred by the repeatable field JavaScript script.
             // @deprecated 3.6.0 
             // 'data-id_model' => $this->aArguments[ '_fields_container_id_model' ], // 3.3.1+
-            'class'         => "admin-page-framework-field admin-page-framework-field-" . $this->aArguments[ 'type' ]
+            'class'         => "admin-page-framework-field admin-page-framework-field-".$this->aArguments[ 'type' ]
                 . $this->getAOrB(
                     $this->aArguments[ 'attributes' ][ 'disabled' ],
                     ' disabled',

development/factory/_common/form/_view/fieldset/AdminPageFramework_Form_View___Fieldset___FieldError.php

Doc Comments +1 added lines

@@ -60,6 +60,7 @@
          * 
          * @since       3.1.0
          * @since       DEVVER      Moved from `AdminPageFramework_Form_View___Fieldset`.
+         * @param string $sHeadingMessage
          * @return      string      The error string message. An empty value if not found.
          */
         private function _getFieldError( $aErrors, $aSectionPath, $aFieldPath, $sHeadingMessage ) {

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
         private function _getFieldError( $aErrors, $aSectionPath, $aFieldPath, $sHeadingMessage ) {
 
             // If this field has a section and the error element is set
-            $_aErrorPath   = array_merge( $aSectionPath, $aFieldPath );
+            $_aErrorPath = array_merge( $aSectionPath, $aFieldPath );
             if ( $this->_hasFieldError( $aErrors, $_aErrorPath ) ) {
                 return "<span class='field-error'>*&nbsp;"
                         . $sHeadingMessage

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * Admin Page Framework
- * 
- * http://en.michaeluno.jp/admin-page-framework/
- * Copyright (c) 2013-2016 Michael Uno; Licensed MIT
- * 
- */
+     * Admin Page Framework
+     * 
+     * http://en.michaeluno.jp/admin-page-framework/
+     * Copyright (c) 2013-2016 Michael Uno; Licensed MIT
+     * 
+     */
 
 /**
  * Provides an abstract base class to create meta boxes in generic admin pages created by the framework.

development/factory/_common/form/_view/fieldset/AdminPageFramework_Form_View___Fieldset_Base.php

Doc Comments +2 added lines

@@ -176,6 +176,7 @@ 
      * Returns the repeatable fields script.
      * 
      * @since 2.1.3
+     * @param string $sFieldsContainerID
      */
     protected function _getRepeaterFieldEnablerScript( $sFieldsContainerID, $iFieldCount, $aSettings ) {
 
@@ -222,6 +223,7 @@ 
      * Returns the sortable fields script.
      * 
      * @since 3.0.0
+     * @param string $sFieldsContainerID
      */    
     protected function _getSortableFieldEnablerScript( $sFieldsContainerID ) {        
     

Indentation +1 added lines, -1 removed lines

@@ -189,7 +189,7 @@
         $_sButtons              = 
             "<div class='admin-page-framework-repeatable-field-buttons' {$_sSettingsAttributes} >"
                 . "<a class='repeatable-field-remove-button button-secondary repeatable-field-button button button-small {$_sDashiconMinus}' href='#' title='{$_sRemove}' {$_sVisibility} data-id='{$sFieldsContainerID}'>"
-                  . ( $_bDashiconSupported ? '' : '-' )
+                    . ( $_bDashiconSupported ? '' : '-' )
                 . "</a>"
                 . "<a class='repeatable-field-add-button button-secondary repeatable-field-button button button-small {$_sDashiconPlus}' href='#' title='{$_sAdd}' data-id='{$sFieldsContainerID}'>" 
                     . ( $_bDashiconSupported ? '' : '+' )

Spacing +10 added lines, -10 removed lines

@@ -68,7 +68,7 @@ 
      * @param       object      $oMsg                   An object storing the system messages.
      * @param       array       $aCallbacks             An array storing the form-field specific callbacks.     
      */
-    public function __construct( &$aField, $aOptions, $aErrors, &$aFieldTypeDefinitions, &$oMsg, array $aCallbacks=array() ) {
+    public function __construct( &$aField, $aOptions, $aErrors, &$aFieldTypeDefinitions, &$oMsg, array $aCallbacks = array() ) {
 
         // @todo Investigate why the first parameter is passed by reference. 
 
@@ -79,13 +79,13 @@ 
         $this->aErrors                  = $this->getAsArray( $aErrors );
         $this->oMsg                     = $oMsg;
         $this->aCallbacks               = $aCallbacks + array(
-            'hfID'              => null,    // the input id attribute
-            'hfTagID'           => null,    // the fieldset/field row container id attribute
-            'hfName'            => null,    // the input name attribute
-            'hfNameFlat'        => null,    // the flat input name attribute                
+            'hfID'              => null, // the input id attribute
+            'hfTagID'           => null, // the fieldset/field row container id attribute
+            'hfName'            => null, // the input name attribute
+            'hfNameFlat'        => null, // the flat input name attribute                
             'hfInputName'       => null,
             'hfInputNameFlat'   => null,
-            'hfClass'           => null,    // the class attribute
+            'hfClass'           => null, // the class attribute
         );        
         
         // 2. Load necessary JavaScript scripts.
@@ -152,9 +152,9 @@ 
          * @since   3.2.0   Added the `$sFieldsType` parameter.
          * @internal
          */
-        private function _loadScripts( $sStructureType='' ) {
+        private function _loadScripts( $sStructureType = '' ) {
 
-            if ( 'widget' === $sStructureType && ! self::$_bIsLoadedSScripts_Widget ) {
+            if ( 'widget' === $sStructureType && !self::$_bIsLoadedSScripts_Widget ) {
                 new AdminPageFramework_Form_View___Script_Widget;
                 self::$_bIsLoadedSScripts_Widget = true;
             }
@@ -183,7 +183,7 @@ 
         $_sRemove               = $this->oMsg->get( 'remove' );
         $_sVisibility           = $iFieldCount <= 1 ? " style='visibility: hidden;'" : "";
         $_sSettingsAttributes   = $this->generateDataAttributes( ( array ) $aSettings );
-        $_bDashiconSupported    = false;     // version_compare( $GLOBALS['wp_version'], '3.8', '>=' );
+        $_bDashiconSupported    = false; // version_compare( $GLOBALS['wp_version'], '3.8', '>=' );
         $_sDashiconPlus         = $_bDashiconSupported ? 'dashicons dashicons-plus' : '';
         $_sDashiconMinus        = $_bDashiconSupported ? 'dashicons dashicons-minus' : '';
         $_sButtons              = 
@@ -196,7 +196,7 @@ 
                 . "</a>"                
             . "</div>";
         $_aJSArray              = json_encode( $aSettings );
-        $_sButtonsHTML          = '"' . $_sButtons . '"';
+        $_sButtonsHTML          = '"'.$_sButtons.'"';
         $_sScript               = <<<JAVASCRIPTS
 jQuery( document ).ready( function() {
     var _nodePositionIndicators = jQuery( '#{$sFieldsContainerID} .admin-page-framework-field .repeatable-field-buttons' );

Braces +2 added lines, -2 removed lines

@@ -159,7 +159,7 @@ 
                 self::$_bIsLoadedSScripts_Widget = true;
             }
             
-            if ( self::$_bIsLoadedSScripts ) { 
+            if ( self::$_bIsLoadedSScripts ) {
                 return; 
             }
             self::$_bIsLoadedSScripts = true;
@@ -223,7 +223,7 @@ 
      * 
      * @since 3.0.0
      */    
-    protected function _getSortableFieldEnablerScript( $sFieldsContainerID ) {        
+    protected function _getSortableFieldEnablerScript( $sFieldsContainerID ) {
     
         $_sScript = <<<JAVASCRIPTS
     jQuery( document ).ready( function() {

development/factory/_common/form/_view/generator/field/AdminPageFramework_Form_View___Generate_Field_Base.php

Doc Comments -1 removed lines

@@ -23,7 +23,6 @@
      * @internal
      * @since       3.5.3
      * @since       3.6.0       Moved from `AdminPageFramework_FormDefinition`.
-     * @param       array       $aFieldset     a field definition array.
      * @return      boolean
      */
     protected function _isSectionSet() {

development/factory/_common/form/_view/generator/field/AdminPageFramework_Form_View___Generate_FieldInputName.php

Doc Comments +1 added lines

@@ -60,6 +60,7 @@
         /**
          * Applies the subject string to the set callback filter function.
          * @since       3.6.0
+         * @param string $sSubject
          */
         protected function _getFiltered( $sSubject ) {
             return is_callable( $this->hfCallback )

Spacing +2 added lines, -2 removed lines

@@ -51,9 +51,9 @@
         $_sIndex = $this->getAOrB(
             '0' !== $this->sIndex && empty( $this->sIndex ),
             '',
-            "[" . $this->sIndex . "]"
+            "[".$this->sIndex."]"
         );        
-        return $this->_getFiltered( $this->_getFieldName() . $_sIndex );
+        return $this->_getFiltered( $this->_getFieldName().$_sIndex );
         
     }
     

development/factory/_common/form/_view/generator/section/AdminPageFramework_Form_View___Generate_Section_Base.php

Doc Comments +1 added lines

@@ -51,6 +51,7 @@
     /**
      * Applies the subject string to the set callback filter function.
      * @since       3.6.0
+     * @param string $sSubject
      */
     protected function _getFiltered( $sSubject ) {
         return is_callable( $this->hfCallback )

Spacing +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
             $this->hfCallback,
         );
         $this->aArguments = $_aParameters[ 0 ];        
-        $this->hfCallback  = $_aParameters[ 1 ];
+        $this->hfCallback = $_aParameters[ 1 ];
 
     }    
     
@@ -83,8 +83,8 @@ 
         
         // Extract the first part as it does not have braces
         $_sName = array_shift( $aParts );
-        foreach( $aParts as $_sPart ) {
-            $_sName .= '[' . $_sPart . ']';
+        foreach ( $aParts as $_sPart ) {
+            $_sName .= '['.$_sPart.']';
         }
         return $_sName;
         

development/factory/_common/form/_view/sectionset/AdminPageFramework_Form_View___Sectionsets.php

Doc Comments +4 added lines, -1 removed lines

@@ -161,6 +161,7 @@ 
     }
         /**
          * @since       DEVVER
+         * @param string $_sOutput
          * @return      string
          */
         private function _getSpinnerOutput( $_sOutput ) {
@@ -297,7 +298,7 @@ 
              * @param       array       $_aOutputs      Holds output elements - contents, section tab list, count of subsections
              * @param       string      $_sSectionsID   The container id of secitons.
              * @param       array       $_aSection
-             * @param       array       $_aFieldsInSections     A fieldsets array already divided by section tab.
+             * @param       array       $aFieldsInSections     A fieldsets array already divided by section tab.
              * @return      array       The updated sections table output array.
              */
             private function _getSectionsetTable( $_aOutputs, $_sSectionsID, array $_aSection, array $aFieldsInSections ) {
@@ -351,6 +352,7 @@ 
             }
                 /**
                  * @since       DEVVER
+                 * @param string $_sSectionsID
                  * @return      array
                  */
                 private function _getSubSections( $_aOutputs, $_sSectionsID, $_aSection, $_aSubSections ) {
@@ -499,6 +501,7 @@ 
              * @since       3.5.3
              * @since       3.6.0       Removed the `$sSectionID` parameter. Added the `$aSectionset` parameter.
              * @since       DEVVER      Moved from `AdminPageFramework_FormPart_Table`.
+             * @param string $sSectionsID
              * @return      string      The formatted sections table HTML output.
              */
             private function _getFormattedSectionsTablesOutput( array $aOutputs, $aSectionset, $sSectionsID, array $aCollapsible, $sSectionTabSlug ) {

Indentation +1 added lines, -1 removed lines

@@ -531,7 +531,7 @@
                  * @return      string      The generated section tab list as HTML.
                  */
                 private function _getSectionTabList( $sSectionTabSlug, array $aSectionTabList ) {
-                   return $sSectionTabSlug 
+                    return $sSectionTabSlug 
                         ? "<ul class='admin-page-framework-section-tabs nav-tab-wrapper'>" 
                             . implode( PHP_EOL, $aSectionTabList ) 
                             . "</ul>"

Spacing +42 added lines, -42 removed lines

@@ -126,16 +126,16 @@ 
      */
     public function get() {
         
-        $_oFormatSectionsetsByTab  = new AdminPageFramework_Form_View___Format_SectionsetsByTab(
+        $_oFormatSectionsetsByTab = new AdminPageFramework_Form_View___Format_SectionsetsByTab(
             $this->aStructure[ 'sectionsets' ],
             $this->aStructure[ 'fieldsets' ],
             $this->aArguments[ 'nested_depth' ]
         );
 
-        $_aOutput     = array();
-        foreach( $_oFormatSectionsetsByTab->getTabs() as $_sSectionTabSlug ) {
+        $_aOutput = array();
+        foreach ( $_oFormatSectionsetsByTab->getTabs() as $_sSectionTabSlug ) {
 
-            $_aOutput[] = $this->_getFormOutput(
+            $_aOutput[ ] = $this->_getFormOutput(
                 $_oFormatSectionsetsByTab->getSectionsets( $_sSectionTabSlug ),
                 $_oFormatSectionsetsByTab->getFieldsets( $_sSectionTabSlug ),
                 $_sSectionTabSlug,
@@ -149,7 +149,7 @@ 
 
         // Generate id for this output
         $_sOutput = implode( PHP_EOL, $_aOutput );
-        $_sElementID = "admin-page-framework-sectionsets-" . uniqid();
+        $_sElementID = "admin-page-framework-sectionsets-".uniqid();
         return $this->_getSpinnerOutput( $_sOutput )
             .   "<div id='{$_sElementID}' class='admin-page-framework-sctionsets admin-page-framework-form-js-on'>"
                 . $_sOutput
@@ -184,17 +184,17 @@ 
 
             // A sectionset is a set of sections.
             $_sSectionSet = $this->_getSectionsetsTables( 
-                $aSectionsets,  // sectionset definition (already devided by section tab)
-                $aFieldsets,    // fieldset definitions (already devided by section tab)
+                $aSectionsets, // sectionset definition (already devided by section tab)
+                $aFieldsets, // fieldset definitions (already devided by section tab)
                 $aCallbacks
             );
             return $_sSectionSet
-                ? "<div " . $this->getAttributes(
+                ? "<div ".$this->getAttributes(
                         array(
                             'class' => 'admin-page-framework-sectionset',
-                            'id'    => "sectionset-{$sSectionTabSlug}_" . md5( serialize( $aSectionsets ) ),
+                            'id'    => "sectionset-{$sSectionTabSlug}_".md5( serialize( $aSectionsets ) ),
                         ) 
-                    ) . ">"
+                    ).">"
                         . $_sSectionSet
                     . "</div>"
                 : '';
@@ -226,7 +226,7 @@ 
              * If no fields belonging to the section, return empty.
              * Otherwise, the sectionsets container gets rendered and its CSS rules such as margins give unwanted results.
              */
-            if ( ! count( $aFieldsets ) ) {
+            if ( !count( $aFieldsets ) ) {
                 return ''; 
             }           
 
@@ -238,12 +238,12 @@ 
                 'count_subsections' => 0,
             );
             $_sThisSectionID    = $_aFirstSectionset[ 'section_id' ];
-            $_sSectionsID       = 'sections-' . $_sThisSectionID;
+            $_sSectionsID       = 'sections-'.$_sThisSectionID;
             $_aCollapsible      = $this->_getCollapsibleArgumentForSections( 
                 $_aFirstSectionset 
             );
 
-            foreach( $aSectionsets as $_aSectionset ) {
+            foreach ( $aSectionsets as $_aSectionset ) {
            
                 $_sSectionTabSlug   = $_aSectionset[ 'section_tab_slug' ]; // needed outside the loop
                 $_aOutputs          = $this->_getSectionsetTable(
@@ -275,7 +275,7 @@ 
              * Changed the visibility scope to private. Changed the 1st parameter from `$aSection`.
              * @return      array
              */
-            private function _getCollapsibleArgumentForSections( array $aSectionset=array() ) {  
+            private function _getCollapsibleArgumentForSections( array $aSectionset = array() ) {  
                 
                 $_oArgumentFormater = new AdminPageFramework_Form_Model___Format_CollapsibleSection(
                     $aSectionset[ 'collapsible' ],
@@ -304,17 +304,17 @@ 
              */
             private function _getSectionsetTable( $_aOutputs, $_sSectionsID, array $_aSection, array $aFieldsInSections ) {
             
-                if ( ! $this->isSectionsetVisible( $_aSection ) ) {
+                if ( !$this->isSectionsetVisible( $_aSection ) ) {
 // var_dump( 'not visible: ' . $_aSection[ '_section_path' ] );
                     return $_aOutputs;
                 }
 
                 // If the 'save' argument is false, insert a flag that disables saving the section inputs.
-                $_aOutputs[ 'section_contents' ][] = $this->_getUnsetFlagSectionInputTag( $_aSection );
+                $_aOutputs[ 'section_contents' ][ ] = $this->_getUnsetFlagSectionInputTag( $_aSection );
                 
                 // For repeatable sections - sub-sections are divided field definition arrays by sub-section index, 
                 // not section definition arrays.
-                $_aSubSections      = $this->getIntegerKeyElements( 
+                $_aSubSections = $this->getIntegerKeyElements( 
                     $this->getElementAsArray(
                         $aFieldsInSections, // subject
                         $_aSection[ '_section_path' ], // $_aSection[ 'section_id' ],   // dimensional key
@@ -358,29 +358,29 @@ 
                 private function _getSubSections( $_aOutputs, $_sSectionsID, $_aSection, $_aSubSections ) {
                     
                     // Add the repeatable sections enabler script.
-                    if ( ! empty( $_aSection[ 'repeatable' ] ) ) {
-                        $_aOutputs[ 'section_contents' ][] = AdminPageFramework_Form_View___Script_RepeatableSection::getEnabler( 
+                    if ( !empty( $_aSection[ 'repeatable' ] ) ) {
+                        $_aOutputs[ 'section_contents' ][ ] = AdminPageFramework_Form_View___Script_RepeatableSection::getEnabler( 
                             $_sSectionsID, 
                             $_aOutputs[ 'count_subsections' ], 
                             $_aSection[ 'repeatable' ],
                             $this->oMsg
                         );
-                        $_aOutputs[ 'section_contents' ][] = $this->_getRepeatableSectionFlagTag( $_aSection );
+                        $_aOutputs[ 'section_contents' ][ ] = $this->_getRepeatableSectionFlagTag( $_aSection );
                     }
                     // Add the sortable sections enabler script. 3.6.0+
-                    if ( ! empty( $_aSection[ 'sortable' ] ) ) {
+                    if ( !empty( $_aSection[ 'sortable' ] ) ) {
 // @todo Change the name of the class to AdminPageFramework_Form_Script_...
-                        $_aOutputs[ 'section_contents' ][] = AdminPageFramework_Form_View___Script_SortableSection::getEnabler( 
+                        $_aOutputs[ 'section_contents' ][ ] = AdminPageFramework_Form_View___Script_SortableSection::getEnabler( 
                             $_sSectionsID, 
                             $_aSection[ 'sortable' ],
                             $this->oMsg
                         );
-                        $_aOutputs[ 'section_contents' ][] = $this->_getSortableSectionFlagTag( $_aSection );
+                        $_aOutputs[ 'section_contents' ][ ] = $this->_getSortableSectionFlagTag( $_aSection );
                     }
                     
                     // Get the section tables.
                     $_aSubSections = $this->numerizeElements( $_aSubSections ); // will include the main section as well.
-                    foreach( $_aSubSections as $_iIndex => $_aFields ) { 
+                    foreach ( $_aSubSections as $_iIndex => $_aFields ) { 
 
                         $_oEachSectionArguments = new AdminPageFramework_Form_Model___Format_EachSection(
                             $_aSection,
@@ -410,8 +410,8 @@ 
                         array(
                             'class'                     => 'element-address',
                             'type'                      => 'hidden',
-                            'name'                      => '__repeatable_elements_' . $aSection[ '_structure_type' ] 
-                                . '[' . $aSection[ 'section_id' ] . ']',
+                            'name'                      => '__repeatable_elements_'.$aSection[ '_structure_type' ] 
+                                . '['.$aSection[ 'section_id' ].']',
                             // @todo examine whether this value should include a section index.
                             'value' => $aSection[ 'section_id' ],                            
                         )
@@ -429,8 +429,8 @@ 
                         array(
                             'class'                     => 'element-address',
                             'type'                      => 'hidden',
-                            'name'                      => '__sortable_elements_' . $aSection[ '_structure_type' ] 
-                                . '[' . $aSection[ 'section_id' ] . ']',
+                            'name'                      => '__sortable_elements_'.$aSection[ '_structure_type' ] 
+                                . '['.$aSection[ 'section_id' ].']',
                             // @todo examine whether this value should include a section index.
                             'value' => $aSection[ 'section_id' ],                            
                         )
@@ -452,8 +452,8 @@ 
                         'input',
                         array(
                             'type'  => 'hidden',
-                            'name'  => '__unset_' .  $aSection[ '_structure_type' ] . '[' . $aSection[ 'section_id' ] . ']',
-                            'value' => "__dummy_option_key|" . $aSection[ 'section_id' ],
+                            'name'  => '__unset_'.$aSection[ '_structure_type' ].'['.$aSection[ 'section_id' ].']',
+                            'value' => "__dummy_option_key|".$aSection[ 'section_id' ],
                             'class' => 'unset-element-names element-address',
                         )
                     );            
@@ -469,7 +469,7 @@ 
                 private function _getSectionTableWithTabList( array $_aOutputs, array $aSectionset, $aFieldsetsPerSection ) {
                                         
                     // Tab list
-                    $_aOutputs[ 'section_tab_list' ][] = $this->_getTabList( 
+                    $_aOutputs[ 'section_tab_list' ][ ] = $this->_getTabList( 
                         $aSectionset, 
                         $aFieldsetsPerSection, 
                         $this->aCallbacks[ 'fieldset_output' ]
@@ -477,7 +477,7 @@ 
 
                     // Section container
                     $_oSectionTable = new AdminPageFramework_Form_View___Section(
-                        $this->aArguments,  // for nested sections
+                        $this->aArguments, // for nested sections
                         $aSectionset,
                         $this->aStructure,
                         $aFieldsetsPerSection,
@@ -487,7 +487,7 @@ 
                         $this->aCallbacks,
                         $this->oMsg
                     );
-                    $_aOutputs[ 'section_contents' ][] = $_oSectionTable->get();                    
+                    $_aOutputs[ 'section_contents' ][ ] = $_oSectionTable->get();                    
                    
                     return $_aOutputs;
                  
@@ -515,9 +515,9 @@ 
                         'section_index'     => null,
                         'collapsible'       => $aCollapsible,
                         'container_type'    => 'sections', // section or sections                    
-                        'sectionset'        => $aSectionset,    // 3.7.0+ for tooltip
+                        'sectionset'        => $aSectionset, // 3.7.0+ for tooltip
                     ),
-                    array(),            // fieldsets
+                    array(), // fieldsets
                     $this->aSavedData,   
                     $this->aFieldErrors, 
                     $this->aStructure[ 'field_type_definitions' ], 
@@ -534,7 +534,7 @@ 
                     $aOutputs[ 'count_subsections' ]
                 );
                 return $_oCollapsibleSectionTitle->get()
-                    . "<div " . $_oSectionsTablesContainerAttributes->get() . ">"
+                    . "<div ".$_oSectionsTablesContainerAttributes->get().">"
                         . $this->_getSectionTabList( $sSectionTabSlug, $aOutputs[ 'section_tab_list' ] )
                         . implode( PHP_EOL, $aOutputs[ 'section_contents' ] )
                     . "</div>";
@@ -565,21 +565,21 @@ 
              */
             private function _getTabList( array $aSection, array $aFields, $hfFieldCallback ) {
                                 
-                if ( ! $aSection[ 'section_tab_slug' ] ) {
+                if ( !$aSection[ 'section_tab_slug' ] ) {
                     return '';
                 }
                 
                 $iSectionIndex      = $aSection[ '_index' ];
 
-                $_sSectionTagID     = 'section-' . $aSection[ 'section_id' ] . '__' . $iSectionIndex;
+                $_sSectionTagID     = 'section-'.$aSection[ 'section_id' ].'__'.$iSectionIndex;
                 $_aTabAttributes    = $aSection[ 'attributes' ][ 'tab' ]
                     + array(
                         'class' => 'admin-page-framework-section-tab nav-tab',
                         'id'    => "section_tab-{$_sSectionTagID}",
                         'style' => null
                     );
-                $_aTabAttributes[ 'class' ] = $this->getClassAttribute( $_aTabAttributes[ 'class' ], $aSection[ 'class' ][ 'tab' ] );  // 3.3.1+
-                $_aTabAttributes[ 'style' ] = $this->getStyleAttribute( $_aTabAttributes[ 'style' ], $aSection[ 'hidden' ] ? 'display:none' : null );  // 3.3.1+
+                $_aTabAttributes[ 'class' ] = $this->getClassAttribute( $_aTabAttributes[ 'class' ], $aSection[ 'class' ][ 'tab' ] ); // 3.3.1+
+                $_aTabAttributes[ 'style' ] = $this->getStyleAttribute( $_aTabAttributes[ 'style' ], $aSection[ 'hidden' ] ? 'display:none' : null ); // 3.3.1+
                 
                 $_oSectionTitle = new AdminPageFramework_Form_View___SectionTitle(                    
                     array(
@@ -587,7 +587,7 @@ 
                         'tag'           => 'h4',
                         'section_index' => $iSectionIndex,
                         
-                        'sectionset'    => $aSection,   // 3.7.0+      for tooltip
+                        'sectionset'    => $aSection, // 3.7.0+      for tooltip
                     ),
                     $aFields,            
                     $this->aSavedData,   
@@ -597,7 +597,7 @@ 
                     $this->aCallbacks // field output element callables.                    
                 );                        
                 
-                return "<li " . $this->getAttributes( $_aTabAttributes ) . ">"
+                return "<li ".$this->getAttributes( $_aTabAttributes ).">"
                     . "<a href='#{$_sSectionTagID}'>"
                         . $_oSectionTitle->get()
                     ."</a>"

Braces +4 added lines, -4 removed lines

@@ -204,7 +204,7 @@ 
         private function _getSectionsetsTables( array $aSectionsets, array $aFieldsets, array $aCallbacks ) {
 
 
-            if ( empty( $aSectionsets ) ) { 
+            if ( empty( $aSectionsets ) ) {
                 return ''; 
             } 
             
@@ -258,7 +258,7 @@ 
              * Changed the visibility scope to private. Changed the 1st parameter from `$aSection`.
              * @return      array
              */
-            private function _getCollapsibleArgumentForSections( array $aSectionset=array() ) {  
+            private function _getCollapsibleArgumentForSections( array $aSectionset=array() ) {
                 
                 $_oArgumentFormater = new AdminPageFramework_Form_Model___Format_CollapsibleSection(
                     $aSectionset[ 'collapsible' ],
@@ -363,7 +363,7 @@ 
                     
                     // Get the section tables.
                     $_aSubSections = $this->numerizeElements( $_aSubSections ); // will include the main section as well.
-                    foreach( $_aSubSections as $_iIndex => $_aFields ) { 
+                    foreach( $_aSubSections as $_iIndex => $_aFields ) {
 
                         $_oEachSectionArguments = new AdminPageFramework_Form_Model___Format_EachSection(
                             $_aSection,
@@ -428,7 +428,7 @@ 
                  */
                 private function _getUnsetFlagSectionInputTag( array $aSection ) {
                     
-                    if ( false !== $aSection[ 'save' ] ) {                
+                    if ( false !== $aSection[ 'save' ] ) {
                         return '';
                     }
                     return $this->getHTMLTag( 

development/factory/_common/form/AdminPageFramework_Form_Controller.php

Doc Comments +2 added lines

@@ -121,6 +121,8 @@
     }
     /**
      * @since       DEVVER
+     * @param string $sKey
+     * @param string $sValue
      * @return      void
      */
     public function addResource( $sKey, $sValue ) {

Spacing +9 added lines, -9 removed lines

@@ -26,7 +26,7 @@ 
      * @param       string      $sType If empty, the method will check if a message exists in all types. Otherwise, it checks the existence of a message of the specified type.
      * @return      boolean     True if a setting notice is set; otherwise, false.
      */
-    public function hasSubmitNotice( $sType='' ) {
+    public function hasSubmitNotice( $sType = '' ) {
         return $this->oSubmitNotice->hasNotice( $sType );
     }
     
@@ -52,7 +52,7 @@ 
      * @param        boolean     $bOverride      (optional) If true, only one message will be shown in the next page load. false: do not override when there is a message of the same id. true: override the previous one.
      * @return       void
      */
-    public function setSubmitNotice( $sMessage, $sType='error', $asAttributes=array(), $bOverride=true ) {
+    public function setSubmitNotice( $sMessage, $sType = 'error', $asAttributes = array(), $bOverride = true ) {
         $this->oSubmitNotice->set(
             $sMessage, 
             $sType, 
@@ -79,7 +79,7 @@ 
         
         $this->aSectionsets[ $aSectionset[ 'section_id' ] ] = $aSectionset;    
         $this->aFieldsets[ $aSectionset[ 'section_id' ] ]   = $this->getElement(
-            $this->aFieldsets,  // subject array
+            $this->aFieldsets, // subject array
             $aSectionset[ 'section_id' ], // key
             array()      // default
         );                                
@@ -94,7 +94,7 @@ 
      */
     public function removeSection( $sSectionID ) {
         
-        if ( '_default' === $sSectionID ){ 
+        if ( '_default' === $sSectionID ) { 
             return; 
         }
         unset( 
@@ -124,7 +124,7 @@ 
      * @return      void
      */
     public function addResource( $sKey, $sValue ) {
-        self::$_aResources[ $sKey ][] = $sValue;
+        self::$_aResources[ $sKey ][ ] = $sValue;
     }
     
     /**
@@ -147,7 +147,7 @@ 
     public function addField( $asFieldset ) {
 
         // If it is a target section, update the property and return.
-        if ( ! $this->_isFieldsetDefinition( $asFieldset ) ) {
+        if ( !$this->_isFieldsetDefinition( $asFieldset ) ) {
             $this->_asTargetSectionID = $this->_getTargetSectionID( $asFieldset );
             return $this->_asTargetSectionID;
         }
@@ -156,13 +156,13 @@ 
         
         // Set the target section ID
         $this->_asTargetSectionID = $this->getElement(
-            $_aFieldset,  // subject array
+            $_aFieldset, // subject array
             'section_id', // key
             $this->_asTargetSectionID // default
         );                               
 
         // Required Keys
-        if ( ! isset( $_aFieldset[ 'field_id' ], $_aFieldset[ 'type' ] ) ) { 
+        if ( !isset( $_aFieldset[ 'field_id' ], $_aFieldset[ 'type' ] ) ) { 
             return null; 
         }         
                 
@@ -265,7 +265,7 @@ 
      */     
     public function removeField( $sFieldID ) {
                
-        foreach( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
+        foreach ( $this->aFieldsets as $_sSectionID => $_aSubSectionsOrFields ) {
 
             if ( array_key_exists( $sFieldID, $_aSubSectionsOrFields ) ) {
                 unset( $this->aFieldsets[ $_sSectionID ][ $sFieldID ] );

Braces +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
      */
     public function removeSection( $sSectionID ) {
         
-        if ( '_default' === $sSectionID ){ 
+        if ( '_default' === $sSectionID ) {
             return; 
         }
         unset( 
@@ -162,7 +162,7 @@ 
         );                               
 
         // Required Keys
-        if ( ! isset( $_aFieldset[ 'field_id' ], $_aFieldset[ 'type' ] ) ) { 
+        if ( ! isset( $_aFieldset[ 'field_id' ], $_aFieldset[ 'type' ] ) ) {
             return null; 
         }         
                 

development/factory/_common/form/AdminPageFramework_Form_Model.php

Doc Comments -2 removed lines

@@ -391,7 +391,6 @@ 
      * 
      * @since       DEVVER
      * @param       array       $aSavedData
-     * @param       boolean     $bOnlyFieldsets     Whether to format only the fieldsets. The taxonomy field factory uses this parameter.
      */
     protected function _formatElementDefinitions( array $aSavedData ) {
                 
@@ -427,7 +426,6 @@ 
      * Changed the name from `_getFieldErrors()`. 
      * @access      public      The field type class accesses this method to render nested fields.
      * @internal
-     * @param       boolean     $bDelete    whether or not the transient should be deleted after retrieving it. 
      * @return      array
      */
     public function getFieldErrors() {

Spacing +20 added lines, -20 removed lines

@@ -43,10 +43,10 @@ 
      * @since       3.7.0
      * @return      array
      */
-    public function getSubmittedData( array $aDataToParse, $bExtractFromFieldStructure=true, $bStripSlashes=true ) {
+    public function getSubmittedData( array $aDataToParse, $bExtractFromFieldStructure = true, $bStripSlashes = true ) {
                 
         // Extracts the form data from the subject data for parsing
-        $_aSubmittedFormData    = $bExtractFromFieldStructure
+        $_aSubmittedFormData = $bExtractFromFieldStructure
             ? $this->castArrayContents( 
                 $this->getDataStructureFromAddedFieldsets(), // form data (options) structure
                 $aDataToParse   // the subject data array, usually $_POST.
@@ -54,7 +54,7 @@ 
             : $aDataToParse;
 
         // 3.6.0 - sorts dynamic eleemnts.        
-        $_aSubmittedFormData    = $this->getSortedInputs( $_aSubmittedFormData ); 
+        $_aSubmittedFormData = $this->getSortedInputs( $_aSubmittedFormData ); 
         
         return $bStripSlashes
             ? stripslashes_deep( $_aSubmittedFormData ) // fixes magic quotes
@@ -79,12 +79,12 @@ 
             array_merge(
                 $this->getElementAsArray( 
                     $_POST,
-                    '__repeatable_elements_' . $this->aArguments[ 'structure_type' ],
+                    '__repeatable_elements_'.$this->aArguments[ 'structure_type' ],
                     array()
                 ),
                 $this->getElementAsArray( 
                     $_POST,
-                    '__sortable_elements_' . $this->aArguments[ 'structure_type' ],
+                    '__sortable_elements_'.$this->aArguments[ 'structure_type' ],
                     array()
                 )
             )
@@ -147,9 +147,9 @@ 
      * Changed the name from `getFieldsModel()`.
      * @return      array
      */
-    public function getDataStructureFromAddedFieldsets()  {
+    public function getDataStructureFromAddedFieldsets() {
                     
-        $_aFormDataStructure  = array();
+        $_aFormDataStructure = array();
         foreach ( $this->getAsArray( $this->aFieldsets ) as $_sSectionID => $_aFieldsets ) {
 
             if ( $_sSectionID != '_default' ) {                
@@ -158,7 +158,7 @@ 
             }
             
             // For default field items.
-            foreach( $_aFieldsets as $_sFieldID => $_aFieldset ) {
+            foreach ( $_aFieldsets as $_sFieldID => $_aFieldset ) {
                 $_aFormDataStructure[ $_aFieldset[ 'field_id' ] ] = $_aFieldset;
             }
 
@@ -190,7 +190,7 @@ 
             $aSubject,
             $this->getElementAsArray(
                 $_POST,
-                '__repeatable_elements_' . $this->aArguments[ 'structure_type' ]
+                '__repeatable_elements_'.$this->aArguments[ 'structure_type' ]
             )
         );
         return $_oFilterRepeatableElements->get();
@@ -203,13 +203,13 @@ 
     public function _replyToRegisterFormItems() {
 
         // Check if the form should be created or not.
-        if ( ! $this->isInThePage() ) {
+        if ( !$this->isInThePage() ) {
             return;
         }
                 
         // Load field type definitions.
-        $this->_setFieldTypeDefinitions( 'admin_page_framework' );      // site-wide
-        $this->_setFieldTypeDefinitions( $this->aArguments[ 'caller_id' ] );  // per class 
+        $this->_setFieldTypeDefinitions( 'admin_page_framework' ); // site-wide
+        $this->_setFieldTypeDefinitions( $this->aArguments[ 'caller_id' ] ); // per class 
         
         // Set the options array
         $this->aSavedData = $this->_getSavedData(
@@ -237,7 +237,7 @@ 
             $this->aArguments,
             $this->aFieldsets,
             self::$_aResources,
-            $this->aFieldTypeDefinitions,   // must be called after performing `_setFieldTypeDefinitions()`.
+            $this->aFieldTypeDefinitions, // must be called after performing `_setFieldTypeDefinitions()`.
             $this->aCallbacks
         );
         self::$_aResources = $_oFieldResources->get(); // updates the property
@@ -254,10 +254,10 @@ 
         $this->callBack(
             $this->aCallbacks[ 'handle_form_data' ],
             array(
-                $this->aSavedData,      // 1st parameter
-                $this->aArguments,      // 2nd parameter
-                $this->aSectionsets,    // 3rd parameter
-                $this->aFieldsets,      // 4th parameter
+                $this->aSavedData, // 1st parameter
+                $this->aArguments, // 2nd parameter
+                $this->aSectionsets, // 3rd parameter
+                $this->aFieldsets, // 4th parameter
             )
         );        
 
@@ -271,15 +271,15 @@ 
             $this->aSectionsets = $this->callBack(
                 $this->aCallbacks[ 'secitonsets_before_registration' ],
                 array(
-                    $this->aSectionsets,    // 1st parameter
+                    $this->aSectionsets, // 1st parameter
                 )
             );
             // Let the main routine modify the fieldsets definition array.
             $this->aFieldsets = $this->callBack(
                 $this->aCallbacks[ 'fieldsets_before_registration' ],
                 array(
-                    $this->aFieldsets,    // 1st parameter
-                    $this->aSectionsets,  // 2nd parameter
+                    $this->aFieldsets, // 1st parameter
+                    $this->aSectionsets, // 2nd parameter
                 )
             );
 

Braces +4 added lines, -4 removed lines

@@ -29,7 +29,7 @@ 
                 array( $this, '_replyToRegisterFormItems' ),
                 100 // priority - low value is set as meta boxes use the `current_screen` action hook for `setUp()`.
             );
-        } else {                
+        } else {
             add_action(
                 $this->aArguments[ 'action_hook_form_registration' ],
                 array( $this, '_replyToRegisterFormItems' )
@@ -147,12 +147,12 @@ 
      * Changed the name from `getFieldsModel()`.
      * @return      array
      */
-    public function getDataStructureFromAddedFieldsets()  {
+    public function getDataStructureFromAddedFieldsets() {
                     
         $_aFormDataStructure  = array();
         foreach ( $this->getAsArray( $this->aFieldsets ) as $_sSectionID => $_aFieldsets ) {
 
-            if ( $_sSectionID != '_default' ) {                
+            if ( $_sSectionID != '_default' ) {
                 $_aFormDataStructure[ $_sSectionID ] = $_aFieldsets;
                 continue;
             }
@@ -185,7 +185,7 @@ 
      * @param       array       $aSubject       The subject array to modify. Usually the saved option data.
      * @return      array       The modified options array.
      */
-    public function dropRepeatableElements( array $aSubject ) {        
+    public function dropRepeatableElements( array $aSubject ) {
         $_oFilterRepeatableElements = new AdminPageFramework_Form_Model___Modifier_FilterRepeatableElements( 
             $aSubject,
             $this->getElementAsArray(