init_prompts() - Code Metrics - Inspection of "Initial Update" - michaeljoseph/changes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#121)

unknown

created 2017-10-23 20:26 UTC

init_prompts() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	33
rs	8.8571

import os
import textwrap

import pytest
from plumbum.cmd import git
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3

from changes.commands import init
from .conftest import AUTH_TOKEN_ENVVAR


@pytest.fixture
def init_prompts(mocker):
    _ = mocker.patch(
        'changes.config.click.launch',
        autospec=True,
    )

    prompt = mocker.patch(
        'changes.config.click.prompt',
        autospec=True,
    )
    prompt.side_effect = [
        'foo',
        'docs/releases',
        'test_app/__init__.py',
        '.'
    ]

    prompt = mocker.patch(
        'changes.config.read_user_choices',
        autospec=True
    )
    prompt.return_value = ['enhancement', 'bug']

    saved_token = None
    if os.environ.get(AUTH_TOKEN_ENVVAR):
        saved_token = os.environ[AUTH_TOKEN_ENVVAR]
        del os.environ[AUTH_TOKEN_ENVVAR]

    yield

    if saved_token:
        os.environ[AUTH_TOKEN_ENVVAR] = saved_token


def test_init_prompts_for_auth_token_and_writes_tool_config(

    capsys,
    git_repo,
    patch_user_home_to_tmpdir_path,
    init_prompts,
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
):

    init.init()

    assert patch_user_home_to_tmpdir_path.exists()
    expected_config = textwrap.dedent(
        """\
        [changes]
        auth_token = "foo"
        """
    )
    assert expected_config == patch_user_home_to_tmpdir_path.read_text()

    expected_output = textwrap.dedent(
        """\
        No auth token found, asking for it...
        You need a Github Auth Token for changes to create a release.
        Indexing repository...
        """
    )
    out, _ = capsys.readouterr()
    assert expected_output == out


def test_init_finds_auth_token_in_environment(

    capsys,
    git_repo,
    with_auth_token_envvar,
    patch_user_home_to_tmpdir_path,
    with_releases_directory_and_bumpversion_file_prompt,
):

    init.init()

    assert patch_user_home_to_tmpdir_path.exists()
    expected_config = textwrap.dedent(
        """\
        [changes]
        auth_token = "foo"
        """
    )
    assert expected_config == patch_user_home_to_tmpdir_path.read_text()

    expected_output = textwrap.dedent(
        """\
        Found Github Auth Token in the environment...
        Indexing repository...
        """
    )
    out, _ = capsys.readouterr()
    assert expected_output == out


1			import os
2			import textwrap
3
4			import pytest
5			from plumbum.cmd import git
			0 ignored issues – show Configuration introduced 2017-10-16 12:36 UTC by Report Bug Copy Issue Report The import `plumbum.cmd` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6
7			from changes.commands import init
8			from .conftest import AUTH_TOKEN_ENVVAR
9
10
11			@pytest.fixture
12			def init_prompts(mocker):
13			_ = mocker.patch(
14			'changes.config.click.launch',
15			autospec=True,
16			)
17
18			prompt = mocker.patch(
19			'changes.config.click.prompt',
20			autospec=True,
21			)
22			prompt.side_effect = [
23			'foo',
24			'docs/releases',
25			'test_app/__init__.py',
26			'.'
27			]
28
29			prompt = mocker.patch(
30			'changes.config.read_user_choices',
31			autospec=True
32			)
33			prompt.return_value = ['enhancement', 'bug']
34
35			saved_token = None
36			if os.environ.get(AUTH_TOKEN_ENVVAR):
37			saved_token = os.environ[AUTH_TOKEN_ENVVAR]
38			del os.environ[AUTH_TOKEN_ENVVAR]
39
40			yield
41
42			if saved_token:
43			os.environ[AUTH_TOKEN_ENVVAR] = saved_token
44
45
46			def test_init_prompts_for_auth_token_and_writes_tool_config(
			0 ignored issues – show Coding Style Naming introduced 2017-10-18 06:53 UTC by Report Bug Copy Issue Report The name `test_init_prompts_for_au..._and_writes_tool_config` does not conform to the function naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
47			capsys,
48			git_repo,
49			patch_user_home_to_tmpdir_path,
50			init_prompts,
			0 ignored issues – show Comprehensibility Bug introduced 2017-10-18 06:53 UTC by Report Bug Copy Issue Report `init_prompts` is re-defining a name which is already available in the outer-scope (previously defined on line `12`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
51			):
52
53			init.init()
54
55			assert patch_user_home_to_tmpdir_path.exists()
56			expected_config = textwrap.dedent(
57			"""\
58			[changes]
59			auth_token = "foo"
60			"""
61			)
62			assert expected_config == patch_user_home_to_tmpdir_path.read_text()
63
64			expected_output = textwrap.dedent(
65			"""\
66			No auth token found, asking for it...
67			You need a Github Auth Token for changes to create a release.
68			Indexing repository...
69			"""
70			)
71			out, _ = capsys.readouterr()
72			assert expected_output == out
73
74
75			def test_init_finds_auth_token_in_environment(
			0 ignored issues – show Coding Style Naming introduced 2017-10-16 12:36 UTC by Report Bug Copy Issue Report The name `test_init_finds_auth_token_in_environment` does not conform to the function naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style Naming introduced 2017-10-18 06:53 UTC by Report Bug Copy Issue Report The name `with_releases_directory_...bumpversion_file_prompt` does not conform to the argument naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
76			capsys,
77			git_repo,
78			with_auth_token_envvar,
79			patch_user_home_to_tmpdir_path,
80			with_releases_directory_and_bumpversion_file_prompt,
81			):
82
83			init.init()
84
85			assert patch_user_home_to_tmpdir_path.exists()
86			expected_config = textwrap.dedent(
87			"""\
88			[changes]
89			auth_token = "foo"
90			"""
91			)
92			assert expected_config == patch_user_home_to_tmpdir_path.read_text()
93
94			expected_output = textwrap.dedent(
95			"""\
96			Found Github Auth Token in the environment...
97			Indexing repository...
98			"""
99			)
100			out, _ = capsys.readouterr()
101			assert expected_output == out
102

michaeljoseph / changes

Pull Request — master (#121)

init_prompts() B

Complexity

Size

Duplication

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files