Json::validateSyntax() - Code Metrics - Inspection of "Patch 1" - michaeldyrynda/laravel-make-user - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

unknown

created 2018-03-06 08:44 UTC

Json::validateSyntax() B

↳ Parent: Json

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	9
cts	9
cp	1
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	8
nc	4
nop	0
crap	5

<?php

namespace Dyrynda\Artisan\BulkImport\Handlers;

use Dyrynda\Artisan\Exceptions\ImportFileException;
use Dyrynda\Artisan\BulkImport\BulkImportFileHandler;

class Json extends Base implements BulkImportFileHandler
{
    public function getData()
    {
        return json_decode(file_get_contents($this->filePath), true, 512, JSON_BIGINT_AS_STRING);
    }

    protected function validateSyntax()
    {
        $data = json_decode(file_get_contents($this->filePath), true);

        if (json_last_error()) {
            throw ImportFileException::invalidSyntax($this->file->getFilename());
        }

        $fields = array_keys($data[0]);

        foreach ($data as $row) {
            if (count($fields) != count($row) || count(array_intersect($fields, array_keys($row))) != count($fields)) {
                throw ImportFileException::invalidSyntax($this->file->getFilename(), 'Fields not consistent');
            }
        }
    }

    /**
     * Get list of columns from the file.
     *
     * @return array
     */
    protected function getFields()
    {
        $data = json_decode(file_get_contents($this->filePath), true);

        return isset($data[0]) ? array_map('strtolower', array_map('trim', array_keys($data[0]))) : [];
    }
}


1		<?php
2
3		namespace Dyrynda\Artisan\BulkImport\Handlers;
4
5		use Dyrynda\Artisan\Exceptions\ImportFileException;
6		use Dyrynda\Artisan\BulkImport\BulkImportFileHandler;
7
8		class Json extends Base implements BulkImportFileHandler
9		{
10	9	public function getData()
11		{
12	9	return json_decode(file_get_contents($this->filePath), true, 512, JSON_BIGINT_AS_STRING);
13		}
14
15	12	protected function validateSyntax()
16		{
17	12	$data = json_decode(file_get_contents($this->filePath), true);
18
19	12	if (json_last_error()) {
20	3	throw ImportFileException::invalidSyntax($this->file->getFilename());
21		}
22
23	9	$fields = array_keys($data[0]);
24
25	9	foreach ($data as $row) {
26	9	if (count($fields) != count($row) \|\| count(array_intersect($fields, array_keys($row))) != count($fields)) {
27	9	throw ImportFileException::invalidSyntax($this->file->getFilename(), 'Fields not consistent');
28		}
29		}
30	9	}
31
32		/**
33		* Get list of columns from the file.
34		*
35		* @return array
36		*/
37		protected function getFields()
38		{
39		$data = json_decode(file_get_contents($this->filePath), true);
40
41		return isset($data[0]) ? array_map('strtolower', array_map('trim', array_keys($data[0]))) : [];
42		}
43		}
44

michaeldyrynda / laravel-make-user

Pull Request — master (#6)

Json::validateSyntax() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like