Issues in PollManager.php (master) - Issues in master - michaelcullum/voting-system - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AppBundle/Utils/PollManager.php (8 issues)

Labels

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace AppBundle\Utils;

use AppBundle\Entity\{
	Choice, Poll, PollType
};
use Doctrine\Common\Persistence\ManagerRegistry;

class PollManager
{
    protected $doctrineRegistry;
    protected $electionManager;

	/**
	 * Constructor.
	 *
	 * @param \Doctrine\Common\Persistence\ManagerRegistry $doctrineRegistry
	 * @param \AppBundle\Utils\ElectionManager             $electionManager
	 */
	public function __construct(ManagerRegistry $doctrineRegistry, ElectionManager $electionManager)
    {
        $this->doctrineRegistry = $doctrineRegistry;
        $this->electionManager = $electionManager;
    }

	public function getPolls($sort, boolean $current = false): array

	{
		// TODO: Implement sorts and getting polls from db

		if ($current) {
			return $this->getCurrentPolls();
		}

		return [];
	}

    /**
     * Get an array of current polls (objects).
     *
     * @return array
     */
    public function getCurrentPolls(): array
    {
	    $currentPolls = $this->doctrineRegistry->getManager()->getRepository('AppBundle:Poll')->findByActive(true);

        return $currentPolls;
    }

    /**
     * Get an array of eligible votes.
     *
     * @param AppBundle/Entity/PollType $type

     *
     * @return array
     */
    public function getEligibleVoters(PollType $type): array

    {
        return [];
    }

    /**
     * Get an array of all polls (objects).
     *
     * @return array
     */
    public function getAllPolls(): array
    {
	    $polls = $this->doctrineRegistry->getManager()->getRepository('AppBundle:Poll')->findAll();

        return $polls;
    }

    /**
     * Get poll statistics.
     *
     * @param Poll $poll
     *
     * @return array
     */
    public function getPollStats(Poll $poll): array

    {
        // If Poll is election then reject

        // Get standard stats
        return [];
    }

	/**
	 * Get the result of the poll (in terms of a choice).
	 *
	 * @param Poll $poll
	 *
	 * @return \AppBundle\Entity\Choice
	 */
    public function getPollResult(Poll $poll): Choice

    {
        // If election then call Election Manager

        // Calculate winning choice
        return;
    }

    public function getStandardPollVotes(Poll $poll): array

    {
        return [];
    }

    public function markPollClosed(Poll $poll)
    {
	    $poll->setActive(false);
	    $result = $this->generateResult($poll);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

	    return $result;
    }

	public function generateResult(Poll $poll)

	{

    }
}


1		<?php
2
3		namespace AppBundle\Utils;
4
5		use AppBundle\Entity\{
6		Choice, Poll, PollType
7		};
8		use Doctrine\Common\Persistence\ManagerRegistry;
9
10		class PollManager
11		{
12		protected $doctrineRegistry;
13		protected $electionManager;
14
15		/**
16		* Constructor.
17		*
18		* @param \Doctrine\Common\Persistence\ManagerRegistry $doctrineRegistry
19	1	* @param \AppBundle\Utils\ElectionManager $electionManager
20		*/
21	1	public function __construct(ManagerRegistry $doctrineRegistry, ElectionManager $electionManager)
22	1	{
23	1	$this->doctrineRegistry = $doctrineRegistry;
24	1	$this->electionManager = $electionManager;
25		}
26
27		public function getPolls($sort, boolean $current = false): array
		0 ignored issues – show Unused Code introduced 2016-11-10 06:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$sort` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
28		{
29		// TODO: Implement sorts and getting polls from db
30
31	1	if ($current) {
32		return $this->getCurrentPolls();
33	1	}
34
35	1	return [];
36		}
37
38		/**
39		* Get an array of current polls (objects).
40		*
41		* @return array
42		*/
43		public function getCurrentPolls(): array
44		{
45		$currentPolls = $this->doctrineRegistry->getManager()->getRepository('AppBundle:Poll')->findByActive(true);
46
47		return $currentPolls;
48		}
49
50		/**
51		* Get an array of eligible votes.
52		*
53		* @param AppBundle/Entity/PollType $type
		0 ignored issues – show Documentation introduced 2016-08-07 23:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `AppBundle/Entity/PollType` could not be parsed: Unknown type name "AppBundle/Entity/PollType" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
54		*
55	1	* @return array
56		*/
57	1	public function getEligibleVoters(PollType $type): array
		0 ignored issues – show Unused Code introduced 2016-08-07 23:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$type` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
58		{
59	1	return [];
60		}
61
62		/**
63		* Get an array of all polls (objects).
64		*
65		* @return array
66		*/
67		public function getAllPolls(): array
68		{
69		$polls = $this->doctrineRegistry->getManager()->getRepository('AppBundle:Poll')->findAll();
70
71		return $polls;
72		}
73
74		/**
75		* Get poll statistics.
76		*
77		* @param Poll $poll
78		*
79		* @return array
80		*/
81		public function getPollStats(Poll $poll): array
		0 ignored issues – show Unused Code introduced 2016-08-07 23:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$poll` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
82		{
83		// If Poll is election then reject
84
85		// Get standard stats
86		return [];
87		}
88
89		/**
90		* Get the result of the poll (in terms of a choice).
91		*
92		* @param Poll $poll
93		*
94		* @return \AppBundle\Entity\Choice
95		*/
96		public function getPollResult(Poll $poll): Choice
		0 ignored issues – show Unused Code introduced 2016-08-07 23:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$poll` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
97		{
98		// If election then call Election Manager
99
100		// Calculate winning choice
101		return;
102		}
103
104		public function getStandardPollVotes(Poll $poll): array
		0 ignored issues – show Unused Code introduced 2016-08-07 23:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$poll` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
105		{
106		return [];
107		}
108
109		public function markPollClosed(Poll $poll)
110		{
111		$poll->setActive(false);
112		$result = $this->generateResult($poll);
		0 ignored issues – show Bug introduced 2016-11-10 17:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$result` is correct as `$this->generateResult($poll)` (which targets `AppBundle\Utils\PollManager::generateResult()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
113
114		return $result;
115		}
116
117		public function generateResult(Poll $poll)
		0 ignored issues – show Unused Code introduced 2016-11-10 17:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$poll` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
118		{
119
120		}
121		}
122

michaelcullum / voting-system

Issues (18)

Security Analysis not enabled

src/AppBundle/Utils/PollManager.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like