VoteHandler - Code Metrics - Inspection of "Start on election runner" - michaelcullum/voting-system - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c698df...2bf777 )

by Michael

created 2016-08-08 22:38 UTC

VoteHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	1
dl	0
loc	49
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
B	step()	22	4
A	transferVotes()	4	1
A	getQuota()	4	1

<?php

namespace Michaelc\Voting\STV;

use Michaelc\Voting\STV\{Election, Candidate};
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class VoteHandler
{
	protected $election;
	protected $ballots;

	/**
	 * Constructor
	 *
	 * @param Election $election
	 */
	public function __construct(Election $election)
	{
		$this->election = $election;
		$this->ballots = $this->election->getBallots();
	}

	public function step($step)
	{
		foreach ($this->ballots as $i => $ballot)
		{
			$weight = $ballot->getWeight();
			$candidate = $ballot->getNextPreference();
			$election->getCandidate($candidate->getId())->addVotes($weight);

			$ballot->setLastUsedLevel(($step - 1));
		}

		$candidates = $election->getActiveCandidates();

		foreach ($candidates as $i => $candidate) {
			if ($candidate->getVotes() >= $this->getQuota())
			{
        		$candidate->setState(Candidate::ELECTED);
        		$surplus = $candidate->getVotes() - $quota;


        		$this->transferVotes($surplus, $candidate);
        	}
		}
	}

	protected function transferVotes(float $votes, Candidate $candidate)

	{

	}

	public function getQuota()
	{
		return floor(($election->getNumBallots() / ($election->getNumSeats() + 1)) + 1);

	}
}


1			<?php
2
3			namespace Michaelc\Voting\STV;
4
5			use Michaelc\Voting\STV\{Election, Candidate};
			0 ignored issues – show Bug introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Michaelc\Voting\STV\Election`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history... Bug introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Michaelc\Voting\STV\Candidate`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6
7			class VoteHandler
8			{
9			protected $election;
10			protected $ballots;
11
12			/**
13			* Constructor
14			*
15			* @param Election $election
16			*/
17			public function __construct(Election $election)
18			{
19			$this->election = $election;
20			$this->ballots = $this->election->getBallots();
21			}
22
23			public function step($step)
24			{
25			foreach ($this->ballots as $i => $ballot)
26			{
27			$weight = $ballot->getWeight();
28			$candidate = $ballot->getNextPreference();
29			$election->getCandidate($candidate->getId())->addVotes($weight);
			0 ignored issues – show Bug introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report The variable `$election` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
30			$ballot->setLastUsedLevel(($step - 1));
31			}
32
33			$candidates = $election->getActiveCandidates();
34
35			foreach ($candidates as $i => $candidate) {
36			if ($candidate->getVotes() >= $this->getQuota())
37			{
38			$candidate->setState(Candidate::ELECTED);
39			$surplus = $candidate->getVotes() - $quota;
			0 ignored issues – show Bug introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report The variable `$quota` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
40
41			$this->transferVotes($surplus, $candidate);
42			}
43			}
44			}
45
46			protected function transferVotes(float $votes, Candidate $candidate)
			0 ignored issues – show Unused Code introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report The parameter `$votes` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report The parameter `$candidate` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
47			{
48
49			}
50
51			public function getQuota()
52			{
53			return floor(($election->getNumBallots() / ($election->getNumSeats() + 1)) + 1);
			0 ignored issues – show Bug introduced 2016-08-08 22:41 UTC by Report Bug Copy Issue Report The variable `$election` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
54			}
55			}
56

michaelcullum / voting-system

Push — master ( c698df...2bf777 )

VoteHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like