InvitationToCodeTransformer::reverseTransform() - Code Metrics - Inspection of "Fix a bug, this needs fixing in upstream docs" - michaelcullum/voting-system - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc14f9...f9bab8 )

by Michael

created 2016-08-03 19:31 UTC

InvitationToCodeTransformer::reverseTransform() B

↳ Parent: InvitationToCodeTransformer

Complexity

Conditions	4
Paths	3

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	23
rs	8.7972
cc	4
eloc	13
nc	3
nop	1

<?php
namespace AppBundle\Form\DataTransformer;

use AppBundle\Entity\Invitation;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\Exception\UnexpectedTypeException;

/**
 * Transforms an Invitation to an invitation code.
 */
class InvitationToCodeTransformer implements DataTransformerInterface
{
    private $entityManager;

    public function __construct(EntityManager $entityManager)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
    }

    public function transform($value)
    {
        if (null === $value) {
            return null;
        }

        if (!$value instanceof Invitation) {
            throw new UnexpectedTypeException($value, 'AppBundle\Entity\Invitation');
        }

        return $value->getCode();
    }

    public function reverseTransform($value)
    {
        if (null === $value || '' === $value) {
            return null;
        }

        if (!is_string($value)) {
            throw new UnexpectedTypeException($value, 'string');
        }

        $dql = <<<DQL
SELECT i
FROM AppBundle:Invitation i
WHERE i.code = :code
AND NOT EXISTS(SELECT 1 FROM AppBundle:User u WHERE u.invitation = i)
DQL;

        return $this->entityManager
            ->createQuery($dql)
            ->setParameter('code', $value)
            ->setMaxResults(1)
            ->getOneOrNullResult();
    }
}


1			<?php
2			namespace AppBundle\Form\DataTransformer;
3
4			use AppBundle\Entity\Invitation;
5			use Doctrine\ORM\EntityManager;
6			use Symfony\Component\Form\DataTransformerInterface;
7			use Symfony\Component\Form\Exception\UnexpectedTypeException;
8
9			/**
10			* Transforms an Invitation to an invitation code.
11			*/
12			class InvitationToCodeTransformer implements DataTransformerInterface
13			{
14			private $entityManager;
15
16			public function __construct(EntityManager $entityManager)
			0 ignored issues – show Bug introduced 2016-08-03 19:33 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
17			{
18			$this->entityManager = $entityManager;
19			}
20
21			public function transform($value)
22			{
23			if (null === $value) {
24			return null;
25			}
26
27			if (!$value instanceof Invitation) {
28			throw new UnexpectedTypeException($value, 'AppBundle\Entity\Invitation');
29			}
30
31			return $value->getCode();
32			}
33
34			public function reverseTransform($value)
35			{
36			if (null === $value \|\| '' === $value) {
37			return null;
38			}
39
40			if (!is_string($value)) {
41			throw new UnexpectedTypeException($value, 'string');
42			}
43
44			$dql = <<<DQL
45			SELECT i
46			FROM AppBundle:Invitation i
47			WHERE i.code = :code
48			AND NOT EXISTS(SELECT 1 FROM AppBundle:User u WHERE u.invitation = i)
49			DQL;
50
51			return $this->entityManager
52			->createQuery($dql)
53			->setParameter('code', $value)
54			->setMaxResults(1)
55			->getOneOrNullResult();
56			}
57			}
58

michaelcullum / voting-system

Push — master ( cc14f9...f9bab8 )

InvitationToCodeTransformer::reverseTransform() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like