AppBundle\Utils\PollManager

Complexity

Total Complexity

10

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

52.38%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getPolls()	0	6	2
A	getCurrentPolls()	0	6	1
A	getEligibleVoters()	0	4	1
A	getAllPolls()	0	6	1
A	getPollStats()	0	7	1
A	getPollResult()	0	7	1
A	getStandardPollVotes()	0	4	1
A	markPollClosed()	0	4	1

<?php

namespace AppBundle\Utils;

use AppBundle\Entity\{
	Choice, Poll, PollType
};
use Doctrine\Common\Persistence\ManagerRegistry;

class PollManager
{
    protected $doctrineRegistry;
    protected $electionManager;

	/**
	 * Constructor.
	 *
	 * @param \Doctrine\Common\Persistence\ManagerRegistry $doctrineRegistry
	 * @param \AppBundle\Utils\ElectionManager             $electionManager
	 */
	public function __construct(ManagerRegistry $doctrineRegistry, ElectionManager $electionManager)
    {
        $this->doctrineRegistry = $doctrineRegistry;
        $this->electionManager = $electionManager;
    }

	public function getPolls($sort, boolean $current = false): array

The parameter $sort is not used and could be removed.

	{
		if ($current) {
			return $this->getCurrentPolls();
		}
	}

    /**
     * Get an array of current polls (objects).
     *
     * @return array
     */
    public function getCurrentPolls(): array
    {
        $currentPolls = $this->doctrineRegistry->getEntityManager()->getRepository('AppBundle:Poll')->findByActive(true);

It seems like you code against a concrete implementation and not the interface Doctrine\Common\Persistence\ManagerRegistry as the method getEntityManager() does only exist in the following implementations of said interface: Doctrine\Bundle\DoctrineBundle\Registry.

        return $currentPolls;
    }

    /**
     * Get an array of eligible votes.
     *
     * @param AppBundle/Entity/PollType $type

The doc-type AppBundle/Entity/PollType could not be parsed: Unknown type name "AppBundle/Entity/PollType" at position 0. (view supported doc-types)

     *
     * @return array
     */
    public function getEligibleVoters(PollType $type): array

The parameter $type is not used and could be removed.

    {
        return [];
    }

    /**
     * Get an array of all polls (objects).
     *
     * @return array
     */
    public function getAllPolls(): array
    {
	    $polls = $this->doctrineRegistry->getEntityManager()->getRepository('AppBundle:Poll')->findAll();

It seems like you code against a concrete implementation and not the interface Doctrine\Common\Persistence\ManagerRegistry as the method getEntityManager() does only exist in the following implementations of said interface: Doctrine\Bundle\DoctrineBundle\Registry.

        return $polls;
    }

    /**
     * Get poll statistics.
     *
     * @param Poll $poll
     *
     * @return array
     */
    public function getPollStats(Poll $poll): array

The parameter $poll is not used and could be removed.

    {
        // If Poll is election then reject

        // Get standard stats
        return [];
    }

	/**
	 * Get the result of the poll (in terms of a choice).
	 *
	 * @param Poll $poll
	 *
	 * @return \AppBundle\Entity\Choice
	 */
    public function getPollResult(Poll $poll): Choice

The parameter $poll is not used and could be removed.

    {
        // If election then call Election Manager

        // Calculate winning choice
        return;
    }

    public function getStandardPollVotes(Poll $poll): array

The parameter $poll is not used and could be removed.

    {
        return [];
    }

    public function markPollClosed(Poll $poll)

The parameter $poll is not used and could be removed.

    {
        return;
    }
}