Vote - Code Metrics - Inspection of "Change migrations" - michaelcullum/voting-system - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89f754...0e5042 )

by Michael

created 2016-08-07 00:49 UTC

Vote A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	9
lcom	0
cbo	0
dl	0
loc	148
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	getId()	4	1
A	setTime()	6	1
A	getTime()	4	1
A	setPoll()	6	1
A	getPoll()	4	1
A	setCaster()	6	1
A	getCaster()	4	1
A	setChoice()	6	1
A	getChoice()	4	1

<?php

namespace AppBundle\Entity;

use Doctrine\ORM\Mapping as ORM;
use AppBundle\Entity\User;
use AppBundle\Entity\Poll;
use AppBundle\Entity\Choice;
use Doctrine\Common\Collections\ArrayCollection;

/**
 * Vote
 *
 * @ORM\Table(name="votes")
 * @ORM\Entity(repositoryClass="AppBundle\Repository\VoteRepository")
 */
class Vote
{
    /**
     * @var int
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var \Poll
     *
     * @ORM\ManyToOne(targetEntity="Poll", inversedBy="votes")
     * @ORM\JoinColumn(name="poll_id", referencedColumnName="id")
     */
    private $poll;

    /**
     * @var \User
     *
     * @ORM\ManyToOne(targetEntity="User", inversedBy="votes")
     * @ORM\JoinColumn(name="caster_id", referencedColumnName="id")
     */
    private $caster;

    /**
     * @var \DateTime
     *
     * @ORM\Column(name="time", type="datetime")
     */
    private $time;

    /**
     * @var \Choice
     *
     * @ORM\ManyToOne(targetEntity="Choice", inversedBy="votes")
     * @ORM\JoinColumn(name="choice_id", referencedColumnName="id")
     */
    private $choice;

    /**
     * Get id
     *
     * @return integer
     */
    public function getId(): int
    {
        return $this->id;
    }

    /**
     * Set time
     *
     * @param \DateTime $time
     *
     * @return Vote
     */
    public function setTime(\DateTimeInterface $time)
    {
        $this->time = $time;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

        return $this;
    }

    /**
     * Get time
     *
     * @return \DateTime
     */
    public function getTime(): DateTime
    {
        return $this->time;
    }

    /**
     * Set poll
     *
     * @param \AppBundle\Entity\Poll $poll
     *
     * @return Vote
     */
    public function setPoll(Poll $poll = null)
    {
        $this->poll = $poll;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * Get poll
     *
     * @return \AppBundle\Entity\Poll
     */
    public function getPoll(): Poll
    {
        return $this->poll;
    }

    /**
     * Set caster
     *
     * @param \AppBundle\Entity\User $caster
     *
     * @return Vote
     */
    public function setCaster(User $caster = null)
    {
        $this->caster = $caster;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * Get caster
     *
     * @return \AppBundle\Entity\User
     */
    public function getCaster(): User
    {
        return $this->caster;
    }

    /**
     * Set choice
     *
     * @param \AppBundle\Entity\Choice $choice
     *
     * @return Vote
     */
    public function setChoice(Choice $choice = null)
    {
        $this->choice = $choice;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * Get choice
     *
     * @return \AppBundle\Entity\Choice
     */
    public function getChoice(): Choice
    {
        return $this->choice;
    }
}


1			<?php
2
3			namespace AppBundle\Entity;
4
5			use Doctrine\ORM\Mapping as ORM;
6			use AppBundle\Entity\User;
7			use AppBundle\Entity\Poll;
8			use AppBundle\Entity\Choice;
9			use Doctrine\Common\Collections\ArrayCollection;
10
11			/**
12			* Vote
13			*
14			* @ORM\Table(name="votes")
15			* @ORM\Entity(repositoryClass="AppBundle\Repository\VoteRepository")
16			*/
17			class Vote
18			{
19			/**
20			* @var int
21			*
22			* @ORM\Column(name="id", type="integer")
23			* @ORM\Id
24			* @ORM\GeneratedValue(strategy="AUTO")
25			*/
26			private $id;
27
28			/**
29			* @var \Poll
30			*
31			* @ORM\ManyToOne(targetEntity="Poll", inversedBy="votes")
32			* @ORM\JoinColumn(name="poll_id", referencedColumnName="id")
33			*/
34			private $poll;
35
36			/**
37			* @var \User
38			*
39			* @ORM\ManyToOne(targetEntity="User", inversedBy="votes")
40			* @ORM\JoinColumn(name="caster_id", referencedColumnName="id")
41			*/
42			private $caster;
43
44			/**
45			* @var \DateTime
46			*
47			* @ORM\Column(name="time", type="datetime")
48			*/
49			private $time;
50
51			/**
52			* @var \Choice
53			*
54			* @ORM\ManyToOne(targetEntity="Choice", inversedBy="votes")
55			* @ORM\JoinColumn(name="choice_id", referencedColumnName="id")
56			*/
57			private $choice;
58
59			/**
60			* Get id
61			*
62			* @return integer
63			*/
64			public function getId(): int
65			{
66			return $this->id;
67			}
68
69			/**
70			* Set time
71			*
72			* @param \DateTime $time
73			*
74			* @return Vote
75			*/
76			public function setTime(\DateTimeInterface $time)
77			{
78			$this->time = $time;
			0 ignored issues – show Documentation Bug introduced 2016-08-07 00:52 UTC by Report Bug Copy Issue Report `$time` is of type `object<DateTimeInterface>`, but the property `$time` was declared to be of type `object<DateTime>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
79
80			return $this;
81			}
82
83			/**
84			* Get time
85			*
86			* @return \DateTime
87			*/
88			public function getTime(): DateTime
89			{
90			return $this->time;
91			}
92
93			/**
94			* Set poll
95			*
96			* @param \AppBundle\Entity\Poll $poll
97			*
98			* @return Vote
99			*/
100			public function setPoll(Poll $poll = null)
101			{
102			$this->poll = $poll;
			0 ignored issues – show Documentation Bug introduced 2016-08-07 00:52 UTC by Report Bug Copy Issue Report It seems like `$poll` can also be of type `object<AppBundle\Entity\Poll>`. However, the property `$poll` is declared as type `object<Poll>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
103
104			return $this;
105			}
106
107			/**
108			* Get poll
109			*
110			* @return \AppBundle\Entity\Poll
111			*/
112			public function getPoll(): Poll
113			{
114			return $this->poll;
115			}
116
117			/**
118			* Set caster
119			*
120			* @param \AppBundle\Entity\User $caster
121			*
122			* @return Vote
123			*/
124			public function setCaster(User $caster = null)
125			{
126			$this->caster = $caster;
			0 ignored issues – show Documentation Bug introduced 2016-08-07 00:52 UTC by Report Bug Copy Issue Report It seems like `$caster` can also be of type `object<AppBundle\Entity\User>`. However, the property `$caster` is declared as type `object<User>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
127
128			return $this;
129			}
130
131			/**
132			* Get caster
133			*
134			* @return \AppBundle\Entity\User
135			*/
136			public function getCaster(): User
137			{
138			return $this->caster;
139			}
140
141			/**
142			* Set choice
143			*
144			* @param \AppBundle\Entity\Choice $choice
145			*
146			* @return Vote
147			*/
148			public function setChoice(Choice $choice = null)
149			{
150			$this->choice = $choice;
			0 ignored issues – show Documentation Bug introduced 2016-08-07 00:52 UTC by Report Bug Copy Issue Report It seems like `$choice` can also be of type `object<AppBundle\Entity\Choice>`. However, the property `$choice` is declared as type `object<Choice>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
151
152			return $this;
153			}
154
155			/**
156			* Get choice
157			*
158			* @return \AppBundle\Entity\Choice
159			*/
160			public function getChoice(): Choice
161			{
162			return $this->choice;
163			}
164			}
165

michaelcullum / voting-system

Push — master ( 89f754...0e5042 )

Vote A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like