FullName - Code Metrics - Inspection of "fix tests" - michael-rubel/laravel-value-objects - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 0df40c...ce1342 )

by Michael

created 2022-09-22 13:34 UTC

FullName A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	6
eloc	12
c	2
b	0
f	1
dl	0
loc	70
ccs	15
cts	15
cp	1
rs	10

6 Methods

Rating	Name	Size	Complexity
A	toArray()	6	1
A	value()	3	1
A	firstName()	3	1
A	__construct()	5	1
A	fullName()	3	1
A	lastName()	3	1

<?php

declare(strict_types=1);

namespace MichaelRubel\ValueObjects\Complex;

use Illuminate\Support\Collection;
use MichaelRubel\Formatters\Collection\FullNameFormatter;
use MichaelRubel\ValueObjects\ValueObject;

/**
 * @method static static make(string $taxNumber)
 */
class FullName extends ValueObject
{
    /**
     * @var Collection
     */
    protected Collection $split;

    /**
     * Create a new instance of the value object.
     *
     * @param  string|null  $fullName
     */
    public function __construct(protected ?string $fullName)
    {
        $this->fullName = format(FullNameFormatter::class, $this->fullName);

        $this->split = str($this->fullName)->split('/\s/');
    }

    /**
     * Get the full name.
     *
     * @return string
     */
    public function fullName(): string
    {
        return (string) $this->fullName;
    }

    /**
     * Get the first name.
     *
     * @return string
     */
    public function firstName(): string
    {
        return $this->split->first();
    }

    /**
     * Get the last name.
     *
     * @return string
     */
    public function lastName(): string
    {
        return $this->split->last();
    }

    /**
     * Get the object value.
     *
     * @return string
     */
    public function value(): string
    {
        return $this->fullName();
    }

    /**
     * Get an array representation of the value object.
     *
     * @return array
     */
    public function toArray(): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            'fullName'  => $this->fullName(),
            'firstName' => $this->firstName(),
            'lastName'  => $this->lastName(),
        ];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace MichaelRubel\ValueObjects\Complex;
6
7		use Illuminate\Support\Collection;
8		use MichaelRubel\Formatters\Collection\FullNameFormatter;
9		use MichaelRubel\ValueObjects\ValueObject;
10
11		/**
12		* @method static static make(string $taxNumber)
13		*/
14		class FullName extends ValueObject
15		{
16		/**
17		* @var Collection
18		*/
19		protected Collection $split;
20
21		/**
22		* Create a new instance of the value object.
23		*
24		* @param string\|null $fullName
25		*/
26	10	public function __construct(protected ?string $fullName)
27		{
28	10	$this->fullName = format(FullNameFormatter::class, $this->fullName);
29
30	10	$this->split = str($this->fullName)->split('/\s/');
31		}
32
33		/**
34		* Get the full name.
35		*
36		* @return string
37		*/
38	6	public function fullName(): string
39		{
40	6	return (string) $this->fullName;
41		}
42
43		/**
44		* Get the first name.
45		*
46		* @return string
47		*/
48	3	public function firstName(): string
49		{
50	3	return $this->split->first();
51		}
52
53		/**
54		* Get the last name.
55		*
56		* @return string
57		*/
58	2	public function lastName(): string
59		{
60	2	return $this->split->last();
61		}
62
63		/**
64		* Get the object value.
65		*
66		* @return string
67		*/
68	1	public function value(): string
69		{
70	1	return $this->fullName();
71		}
72
73		/**
74		* Get an array representation of the value object.
75		*
76		* @return array
77		*/
78	1	public function toArray(): array
79		{
80		return [
		0 ignored issues – show Bug Best Practice introduced 2022-09-21 13:00 UTC by Report Bug Copy Issue Report The expression `return array('fullName' ...' => $this->lastName())` returns the type `array<string,string>` which is incompatible with the return type mandated by `Illuminate\Contracts\Support\Arrayable::toArray()` of `Illuminate\Contracts\Support\TValue[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
81	1	'fullName' => $this->fullName(),
82	1	'firstName' => $this->firstName(),
83	1	'lastName' => $this->lastName(),
84		];
85		}
86		}
87

michael-rubel / laravel-value-objects

Push — main ( 0df40c...ce1342 )

FullName A

Complexity

Size/Duplication

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like