FullName::firstName() - Code Metrics - Inspection of "improve autocomplete" - michael-rubel/laravel-value-objects - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 01d627...8c0949 )

by Michael

created 2022-09-22 11:55 UTC

FullName::firstName() A

↳ Parent: FullName

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace MichaelRubel\ValueObjects\Complex;

use Illuminate\Support\Collection;
use Illuminate\Support\Traits\Conditionable;
use Illuminate\Support\Traits\Macroable;
use MichaelRubel\Formatters\Collection\FullNameFormatter;
use MichaelRubel\ValueObjects\ValueObject;

/**
 * @method static static make(string $taxNumber)
 */
class FullName extends ValueObject
{
    use Macroable, Conditionable;


    /**
     * @var Collection
     */
    protected Collection $split;

    /**
     * @param  string|null  $fullName
     */
    public function __construct(protected ?string $fullName)
    {
        $this->fullName = format(FullNameFormatter::class, $this->fullName);

        $this->split = str($this->fullName)->split('/\s/');
    }

    /**
     * Get the full name.
     *
     * @return string
     */
    public function fullName(): string
    {
        return (string) $this->fullName;
    }

    /**
     * Get the first name.
     *
     * @return string
     */
    public function firstName(): string
    {
        return $this->split->first();
    }

    /**
     * Get the last name.
     *
     * @return string
     */
    public function lastName(): string
    {
        return $this->split->last();
    }

    /**
     * @return string
     */
    public function value(): string
    {
        return $this->fullName();
    }

    /**
     * Get array representation of the value object.
     *
     * @return array
     */
    public function toArray(): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            'fullName'  => $this->fullName(),
            'firstName' => $this->firstName(),
            'lastName'  => $this->lastName(),
        ];
    }

    /**
     * Get string representation of the value object.
     *
     * @return string
     */
    public function __toString(): string
    {
        return $this->fullName();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace MichaelRubel\ValueObjects\Complex;
6
7		use Illuminate\Support\Collection;
8		use Illuminate\Support\Traits\Conditionable;
9		use Illuminate\Support\Traits\Macroable;
10		use MichaelRubel\Formatters\Collection\FullNameFormatter;
11		use MichaelRubel\ValueObjects\ValueObject;
12
13		/**
14		* @method static static make(string $taxNumber)
15		*/
16		class FullName extends ValueObject
17		{
18		use Macroable, Conditionable;
		0 ignored issues – show Bug introduced 2022-09-20 12:04 UTC by Report Bug Copy Issue Report The trait `Illuminate\Support\Traits\Macroable` requires the property `$name` which is not provided by `MichaelRubel\ValueObjects\Complex\FullName`. Loading history...
19
20		/**
21		* @var Collection
22		*/
23		protected Collection $split;
24
25		/**
26		* @param string\|null $fullName
27		*/
28	10	public function __construct(protected ?string $fullName)
29		{
30	10	$this->fullName = format(FullNameFormatter::class, $this->fullName);
31
32	10	$this->split = str($this->fullName)->split('/\s/');
33		}
34
35		/**
36		* Get the full name.
37		*
38		* @return string
39		*/
40	6	public function fullName(): string
41		{
42	6	return (string) $this->fullName;
43		}
44
45		/**
46		* Get the first name.
47		*
48		* @return string
49		*/
50	3	public function firstName(): string
51		{
52	3	return $this->split->first();
53		}
54
55		/**
56		* Get the last name.
57		*
58		* @return string
59		*/
60	2	public function lastName(): string
61		{
62	2	return $this->split->last();
63		}
64
65		/**
66		* @return string
67		*/
68		public function value(): string
69		{
70		return $this->fullName();
71		}
72
73		/**
74		* Get array representation of the value object.
75		*
76		* @return array
77		*/
78	1	public function toArray(): array
79		{
80		return [
		0 ignored issues – show Bug Best Practice introduced 2022-09-21 13:00 UTC by Report Bug Copy Issue Report The expression `return array('fullName' ...' => $this->lastName())` returns the type `array<string,string>` which is incompatible with the return type mandated by `Illuminate\Contracts\Support\Arrayable::toArray()` of `Illuminate\Contracts\Support\TValue[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
81	1	'fullName' => $this->fullName(),
82	1	'firstName' => $this->firstName(),
83	1	'lastName' => $this->lastName(),
84		];
85		}
86
87		/**
88		* Get string representation of the value object.
89		*
90		* @return string
91		*/
92	1	public function __toString(): string
93		{
94	1	return $this->fullName();
95		}
96		}
97

michael-rubel / laravel-value-objects

Push — main ( 01d627...8c0949 )

FullName::firstName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like