michael-rubel / laravel-couponables

src/Models/Traits/DefinesModelRelations.php

<?php

declare(strict_types=1);

namespace MichaelRubel\Couponables\Models\Traits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Database\Eloquent\Relations\MorphTo;
use MichaelRubel\Couponables\Models\Contracts\CouponPivotContract;

trait DefinesModelRelations
{
    /**
     * Fetch the latest couponables - redeemed coupon records.
     *
     * @return HasMany
     */
    public function couponables(): HasMany
    {
        $pivot = app(CouponPivotContract::class);

        return $this
            ->hasMany($pivot::class)

It seems like hasMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->orderBy($pivot->getRedeemedAtColumn(), 'desc');
    }

    /**
     * The only model allowed to redeem the coupon.
     *
     * @return MorphTo
     */
    public function redeemer(): MorphTo
    {
        return $this->morphTo();

It seems like morphTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}