miBadger\ActiveRecord\Traits\ManyToManyRelation

Complexity

Total Complexity

3

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Test Coverage

Coverage

91.67%

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createTableConstraints()	0	12	1
A	initManyToManyRelation()	0	25	2

<?php

namespace miBadger\ActiveRecord\Traits;

use miBadger\Query\Query;
use miBadger\ActiveRecord\ColumnProperty;
use miBadger\ActiveRecord\AbstractActiveRecord;
use miBadger\ActiveRecord\SchemaBuilder;

Trait ManyToManyRelation
{
	// These variables are relevant for internal bookkeeping (constraint generation etc)

	/** @var string The name of the left column of the relation. */
	private $_leftColumnName;

	/** @var string The name of the right column of the relation. */
	private $_rightColumnName;

	/** @var string The name of the left table of the relation. */
	private $_leftEntityTable;

	/** @var string The name of the right table of the relation. */
	private $_rightEntityTable;

	/** @var \PDO The PDO object. */
	protected $pdo;
	/**
	 * Initializes the the ManyToManyRelation trait on the included object
	 * 
	 * @param AbstractActiveRecord $leftEntity The left entity of the relation
	 * @param int $leftVariable The reference to the variable where the id for the left entity will be stored
	 * @param AbstractActiveRecord $rightEntity The left entity of the relation
	 * @param int $leftVariable The reference to the variable where the id for the right entity will be stored
	 * @return void
	 */
	protected function initManyToManyRelation(AbstractActiveRecord $leftEntity, &$leftVariable, AbstractActiveRecord $rightEntity, &$rightVariable)
	{
		$this->_leftEntityTable = $leftEntity->getTableName();
		$this->_rightEntityTable = $rightEntity->getTableName();

		if (get_class($leftEntity) === get_class($rightEntity)) {
			$this->_leftColumnName = sprintf("id_%s_left", $leftEntity->getTableName());
			$this->_rightColumnName = sprintf("id_%s_right", $rightEntity->getTableName());
		} else {
			$this->_leftColumnName = sprintf("id_%s", $leftEntity->getTableName());
			$this->_rightColumnName = sprintf("id_%s", $rightEntity->getTableName());
		}

		$this->extendTableDefinition($this->_leftColumnName, [
			'value' => &$leftVariable,
			'validate' => null,
			'type' => AbstractActiveRecord::COLUMN_TYPE_ID,
			'properties' => ColumnProperty::NOT_NULL
		]);

		$this->extendTableDefinition($this->_rightColumnName, [
			'value' => &$rightVariable,
			'validate' => null,
			'type' => AbstractActiveRecord::COLUMN_TYPE_ID,
			'properties' => ColumnProperty::NOT_NULL
		]);
	}

	/**
	 * Build the constraints for the many-to-many relation table
	 * @return void
	 */
	public function createTableConstraints()
	{
		$childTable = $this->getTableName();

Are you sure the assignment to $childTable is correct as $this->getTableName() targeting miBadger\ActiveRecord\Traits\ManyToManyRelation::getTableName() seems to always return null.

		$leftParentTable = $this->_leftEntityTable;
		$rightParentTable = $this->_rightEntityTable;

		$leftConstraint = SchemaBuilder::buildConstraintOnDeleteCascade($leftParentTable, 'id', $childTable, $this->_leftColumnName);

$childTable of type void is incompatible with the type string expected by parameter $childTable of miBadger\ActiveRecord\SchemaBuilder::buildConstraintOnDeleteCascade().

		$rightConstraint = SchemaBuilder::buildConstraintOnDeleteCascade($rightParentTable, 'id', $childTable, $this->_rightColumnName);

		$this->pdo->query($leftConstraint);
		$this->pdo->query($rightConstraint);
	}

	/**
	 * @return void
	 */	
	abstract public function getTableName();

	/**
	 * @return void
	 */
	abstract protected function extendTableDefinition(string $columnName, $definition);
	
	/**
	 * @return void
	 */
	abstract protected function registerSearchHook(string $columnName, $fn);

	/**
	 * @return void
	 */
	abstract protected function registerDeleteHook(string $columnName, $fn);

	/**
	 * @return void
	 */
	abstract protected function registerUpdateHook(string $columnName, $fn);

	/**
	 * @return void
	 */
	abstract protected function registerReadHook(string $columnName, $fn);

	/**
	 * @return void
	 */
	abstract protected function registerCreateHook(string $columnName, $fn);

}