|
1
|
|
|
<?php |
|
2
|
|
|
|
|
3
|
|
|
namespace MS\PHPMD\Tests\Unit\CleanCode; |
|
4
|
|
|
|
|
5
|
|
|
use MS\PHPMD\Rule\CleanCode\ClassNameSingleResponsibility; |
|
6
|
|
|
use MS\PHPMD\Tests\Unit\AbstractApplyTest; |
|
7
|
|
|
|
|
8
|
|
|
/** |
|
9
|
|
|
* Class ClassNameSingleResponsibilityTest |
|
10
|
|
|
* |
|
11
|
|
|
* @package MS\PHPMD\Tests\Unit\CleanCode |
|
12
|
|
|
*/ |
|
13
|
|
|
class ClassNameSingleResponsibilityTest extends AbstractApplyTest |
|
14
|
|
|
{ |
|
15
|
|
|
/** |
|
16
|
|
|
* @covers MS\PHPMD\Rule\CleanCode\ClassNameSingleResponsibility |
|
17
|
|
|
*/ |
|
18
|
|
View Code Duplication |
public function testApplyWithSingleResponsibilityClass() |
|
|
|
|
|
|
19
|
|
|
{ |
|
20
|
|
|
$className = 'UserConverter'; |
|
21
|
|
|
|
|
22
|
|
|
$classNode = \Mockery::mock('PHPMD\Node\ClassNode'); |
|
23
|
|
|
$classNode->shouldReceive('getImage')->andReturn($className); |
|
24
|
|
|
$classNode->shouldReceive('getName')->andReturn($className); |
|
25
|
|
|
|
|
26
|
|
|
$this->assertRule($classNode, 0); |
|
27
|
|
|
} |
|
28
|
|
|
|
|
29
|
|
|
/** |
|
30
|
|
|
* @covers MS\PHPMD\Rule\CleanCode\ClassNameSingleResponsibility |
|
31
|
|
|
*/ |
|
32
|
|
View Code Duplication |
public function testApplyWithManagerClass() |
|
|
|
|
|
|
33
|
|
|
{ |
|
34
|
|
|
$className = 'UserManager'; |
|
35
|
|
|
|
|
36
|
|
|
$classNode = \Mockery::mock('PHPMD\Node\ClassNode'); |
|
37
|
|
|
$classNode->shouldReceive('getImage')->andReturn($className); |
|
38
|
|
|
$classNode->shouldReceive('getName')->andReturn($className); |
|
39
|
|
|
|
|
40
|
|
|
$this->assertRule($classNode, 1); |
|
41
|
|
|
} |
|
42
|
|
|
|
|
43
|
|
|
/** |
|
44
|
|
|
* @return ClassNameSingleResponsibility |
|
45
|
|
|
*/ |
|
46
|
|
|
protected function getRule() |
|
47
|
|
|
{ |
|
48
|
|
|
$rule = new ClassNameSingleResponsibility(); |
|
49
|
|
|
$rule->addProperty('delimiter', ','); |
|
50
|
|
|
$rule->addProperty('suffixes', 'Manager,Handler'); |
|
51
|
|
|
|
|
52
|
|
|
return $rule; |
|
53
|
|
|
} |
|
54
|
|
|
} |
|
55
|
|
|
|
mi-schi /
phpmd-symfony2
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.