mi-schi /
phpmd-symfony2
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 9 |
| Code Lines | 6 |
| Lines | 9 |
| Ratio | 100 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 17 | public function testMeaninglessMethodNameRule() |
||
| 18 | { |
||
| 19 | $output = $this |
||
| 20 | ->runPhpmd('Service/GeneralManager.php', 'cleancode.xml') |
||
| 21 | ->getOutput(); |
||
| 22 | |||
| 23 | $this->assertContains('GeneralManager.php:15 Try to avoid meaningless method names like getData. Also getData,getInformation,setData,setInformation are meaningless. Find a name which is not so general.', $output); |
||
| 24 | $this->assertNotContains('GeneralManager.php:25 Try to avoid meaningless method names', $output); |
||
| 25 | } |
||
| 26 | } |
||
| 27 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.