ConstructorNewOperator::apply() - Code Metrics - mi-schi/phpmd-symfony2 - Measure and Improve Code Quality continuously with Scrutinizer

ConstructorNewOperator::apply() B
last analyzed 2016-07-31 19:19 UTC

↳ Parent: ConstructorNewOperator

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
c	3
b	0
f	2
dl	0
loc	16
ccs	11
cts	11
cp	1
rs	8.8571
cc	5
eloc	8
nc	4
nop	1
crap	5

<?php

namespace MS\PHPMD\Rule\Symfony2;

use PHPMD\AbstractNode;
use PHPMD\AbstractRule;
use PHPMD\Node\MethodNode;
use PHPMD\Rule\MethodAware;

/**
 * Class ConstructorNewOperator
 *
 * Resolve strong dependency by simply inject the new instance via DI. So your class is more flexible.
 *
 * @package MS\PHPMD\Rule\Symfony2
 */
class ConstructorNewOperator extends AbstractRule implements MethodAware
{
    /**
     * @param AbstractNode|MethodNode $node
     */
    public function apply(AbstractNode $node)
    {
        $classReferences = $node->findChildrenOfType('ClassReference');

        if ('__construct' !== $node->getImage() || 0 === count($classReferences)) {
            return;
        }

        $allowedClassNames = explode($this->getStringProperty('delimiter'), $this->getStringProperty('allowedClassNames'));

        foreach ($classReferences as $classReference) {
            if (false === $this->containsClassName($classReference->getImage(), $allowedClassNames)) {
                $this->addViolation($classReference);
            }
        }
    }

    /**
     * @param string $className
     * @param array  $allowedClassNames
     *
     * @return bool
     */
    private function containsClassName($className, array $allowedClassNames)
    {
        foreach ($allowedClassNames as $allowedClassName) {
            if (false !== stripos($className, $allowedClassName)) {
                return true;
            }
        }

        return false;
    }
}


1		<?php
2
3		namespace MS\PHPMD\Rule\Symfony2;
4
5		use PHPMD\AbstractNode;
6		use PHPMD\AbstractRule;
7		use PHPMD\Node\MethodNode;
8		use PHPMD\Rule\MethodAware;
9
10		/**
11		* Class ConstructorNewOperator
12		*
13		* Resolve strong dependency by simply inject the new instance via DI. So your class is more flexible.
14		*
15		* @package MS\PHPMD\Rule\Symfony2
16		*/
17		class ConstructorNewOperator extends AbstractRule implements MethodAware
18		{
19		/**
20		* @param AbstractNode\|MethodNode $node
21		*/
22	5	public function apply(AbstractNode $node)
23		{
24	5	$classReferences = $node->findChildrenOfType('ClassReference');
25
26	5	if ('__construct' !== $node->getImage() \|\| 0 === count($classReferences)) {
27	3	return;
28		}
29
30	2	$allowedClassNames = explode($this->getStringProperty('delimiter'), $this->getStringProperty('allowedClassNames'));
31
32	2	foreach ($classReferences as $classReference) {
33	2	if (false === $this->containsClassName($classReference->getImage(), $allowedClassNames)) {
34	1	$this->addViolation($classReference);
35	1	}
36	2	}
37	2	}
38
39		/**
40		* @param string $className
41		* @param array $allowedClassNames
42		*
43		* @return bool
44		*/
45	2	private function containsClassName($className, array $allowedClassNames)
46		{
47	2	foreach ($allowedClassNames as $allowedClassName) {
48	2	if (false !== stripos($className, $allowedClassName)) {
49	1	return true;
50		}
51	1	}
52
53	1	return false;
54		}
55		}
56

mi-schi / phpmd-symfony2

ConstructorNewOperator::apply() B last analyzed 2016-07-31 19:19 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ConstructorNewOperator::apply() B
last analyzed 2016-07-31 19:19 UTC