MS\PHPMD\Tests\Unit\AbstractApplyTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	74
Duplicated Lines	10.81 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	3
Bugs	1	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	4	1
	getRule()	0	1	?
A	assertRule()	0	6	1
A	getReport()	0	7	1
A	getMethodNode()	0	13	2
A	getNode()	8	8	1

<?php

namespace MS\PHPMD\Tests\Unit;

use PHPMD\AbstractNode;
use PHPMD\AbstractRule;
use PHPMD\Report;

/**
 * Class AbstractApplyTest
 *
 * @package MS\PHPMD\Tests\Unit
 */
abstract class AbstractApplyTest extends \PHPUnit_Framework_TestCase
{
    /**
     * close Mockery
     */
    public function tearDown()
    {
        \Mockery::close();
    }

    /**
     * @param AbstractNode $node
     * @param int          $violationNumber
     */
    protected function assertRule(AbstractNode $node, $violationNumber)
    {
        $rule = $this->getRule();
        $rule->setReport($this->getReport($violationNumber));

It seems like $this->getReport($violationNumber) targeting MS\PHPMD\Tests\Unit\AbstractApplyTest::getReport() can also be of type object<Mockery\MockInterface>; however, PHPMD\AbstractRule::setReport() does only seem to accept object<PHPMD\Report>, maybe add an additional type check?

        $rule->apply($node);
    }

    /**
     * @param int $violationNumber
     *
     * @return \Mockery\MockInterface|Report
     */
    protected function getReport($violationNumber)
    {
        $report = \Mockery::mock('PHPMD\Report');
        $report->shouldReceive('addRuleViolation')->times($violationNumber);

        return $report;
    }

    /**
     * @param string $className
     * @param string $methodName
     * @param array  $findChildrenOfType
     *
     * @return \Mockery\MockInterface
     */
    protected function getMethodNode($className, $methodName, array $findChildrenOfType = [])
    {
        $methodNode = \Mockery::mock('PHPMD\Node\MethodNode');
        $methodNode->shouldReceive('getImage')->andReturn($methodName);
        $methodNode->shouldReceive('getParentName')->andReturn($className);
        $methodNode->shouldReceive('getName')->andReturn($methodName);

        foreach ($findChildrenOfType as $argument => $return) {
            $methodNode->shouldReceive('findChildrenOfType')->with($argument)->andReturn($return);
        }

        return $methodNode;
    }

    /**
     * @param string $name
     *
     * @return \Mockery\MockInterface
     */
    protected function getNode($name)

This method seems to be duplicated in your project.

    {
        $node = \Mockery::mock('PHPMD\AbstractNode');
        $node->shouldReceive('getName')->andReturn($name);
        $node->shouldReceive('getImage')->andReturn($name);

        return $node;
    }

    /**
     * @return AbstractRule
     */
    abstract protected function getRule();
}