MS\PHPMD\Rule\CleanCode\MethodOneTryCatch

Complexity

Total Complexity

11

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	apply()	0	12	4
A	hasNotAllowedChildren()	0	20	4
A	isChildOfTry()	0	14	3

<?php

namespace MS\PHPMD\Rule\CleanCode;

use PHPMD\AbstractNode;
use PHPMD\AbstractRule;
use PHPMD\Node\MethodNode;
use PHPMD\Rule\MethodAware;

/**
 * Class MethodOneTryCatch
 *
 * Methods should only have one try statement. If not, swap out the try statement in an extra method. It increase the readability.
 *
 * @package MS\PHPMD\Rule\CleanCode
 */
class MethodOneTryCatch extends AbstractRule implements MethodAware
{
    /**
     * @param AbstractNode|MethodNode $node
     */
    public function apply(AbstractNode $node)
    {
        $countTry = count($node->findChildrenOfType('TryStatement'));

        if (1 < $countTry) {
            $this->addViolation($node);
        }

        if (1 === $countTry &&  true === $this->hasNotAllowedChildren($node)) {

$node of type object<PHPMD\AbstractNode> is not a sub-type of object<PHPMD\Node\MethodNode>. It seems like you assume a child class of the class PHPMD\AbstractNode to be always present.

            $this->addViolation($node);
        }
    }

    /**
     * @param MethodNode $node
     *
     * @return bool
     */
    private function hasNotAllowedChildren(MethodNode $node)
    {
        $children = $node->findChildrenOfType('ScopeStatement');

        $allowedChildren = explode(
            $this->getStringProperty('delimiter'),
            $this->getStringProperty('allowedChildren')
        );

        /** @var AbstractNode $child */
        foreach ($children as $child) {
            if (true === in_array($child->getImage(), $allowedChildren) || true === $this->isChildOfTry($child)) {
                continue;
            }

            return true;
        }

        return false;
    }

    /**
     * @param AbstractNode $node
     *
     * @return bool
     */
    private function isChildOfTry(AbstractNode $node)
    {
        $parent = $node->getParent();

        while (is_object($parent)) {
            if ($parent->isInstanceOf('TryStatement')) {
                return true;
            }

            $parent = $parent->getParent();
        }

        return false;
    }
}