ReturnStatement::apply() - Code Metrics - Inspection of "Move design rules to clean code rules and add desc..." - mi-schi/phpmd-extension - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( ea3c3c...758782 )

by Michael

created 2016-08-23 18:27 UTC

ReturnStatement::apply() A

↳ Parent: ReturnStatement

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.2
cc	4
eloc	9
nc	4
nop	1

<?php

namespace MS\PHPMD\Rule\CleanCode;

use PDepend\Source\AST\ASTReturnStatement;
use PHPMD\AbstractNode;
use PHPMD\AbstractRule;
use PHPMD\Node\MethodNode;
use PHPMD\Rule\MethodAware;

/**
 * To easy understand a return statement line, it should only have simple allocations.
 * Don't write your logical code in the return line.
 */
class ReturnStatement extends AbstractRule implements MethodAware
{
    /**
     * @param AbstractNode|MethodNode $node
     */
    public function apply(AbstractNode $node)
    {
        $allowedChildren = $this->getStringProperty('allowedChildren');
        $allowedClasses = $this->getAllowedClasses($allowedChildren);
        $returnStatements = $node->findChildrenOfType('ReturnStatement');

        /** @var AbstractNode|ASTReturnStatement $returnStatement */
        foreach ($returnStatements as $returnStatement) {
            foreach ($returnStatement->getChildren() as $child) {
                $reflectChild = new \ReflectionClass($child);

                if (false === in_array($reflectChild->getShortName(), $allowedClasses)) {
                    $this->addViolation($returnStatement, [$allowedChildren]);
                }
            }
        }
    }

    /**
     * @param string $allowedChildren
     *
     * @return array
     */
    private function getAllowedClasses($allowedChildren)
    {
        $allowedClasses = explode($this->getStringProperty('delimiter'), $allowedChildren);

        foreach ($allowedClasses as &$allowedClass) {
            $allowedClass = 'AST'.$allowedClass;
        }

        return $allowedClasses;
    }
}



1			<?php
2
3			namespace MS\PHPMD\Rule\CleanCode;
4
5			use PDepend\Source\AST\ASTReturnStatement;
6			use PHPMD\AbstractNode;
7			use PHPMD\AbstractRule;
8			use PHPMD\Node\MethodNode;
9			use PHPMD\Rule\MethodAware;
10
11			/**
12			* To easy understand a return statement line, it should only have simple allocations.
13			* Don't write your logical code in the return line.
14			*/
15			class ReturnStatement extends AbstractRule implements MethodAware
16			{
17			/**
18			* @param AbstractNode\|MethodNode $node
19			*/
20			public function apply(AbstractNode $node)
21			{
22			$allowedChildren = $this->getStringProperty('allowedChildren');
23			$allowedClasses = $this->getAllowedClasses($allowedChildren);
24			$returnStatements = $node->findChildrenOfType('ReturnStatement');
25
26			/** @var AbstractNode\|ASTReturnStatement $returnStatement */
27			foreach ($returnStatements as $returnStatement) {
28			foreach ($returnStatement->getChildren() as $child) {
29			$reflectChild = new \ReflectionClass($child);
30
31			if (false === in_array($reflectChild->getShortName(), $allowedClasses)) {
32			$this->addViolation($returnStatement, [$allowedChildren]);
33			}
34			}
35			}
36			}
37
38			/**
39			* @param string $allowedChildren
40			*
41			* @return array
42			*/
43			private function getAllowedClasses($allowedChildren)
44			{
45			$allowedClasses = explode($this->getStringProperty('delimiter'), $allowedChildren);
46
47			foreach ($allowedClasses as &$allowedClass) {
48			$allowedClass = 'AST'.$allowedClass;
49			}
50
51			return $allowedClasses;
52			}
53			}
54
55

mi-schi / phpmd-extension

GitHub Access Token became invalid

Push — master ( ea3c3c...758782 )

ReturnStatement::apply() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like