MemberPrimaryPrefix::apply() - Code Metrics - Inspection of "Move design rules to clean code rules and add desc..." - mi-schi/phpmd-extension - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( ea3c3c...758782 )

by Michael

created 2016-08-23 18:27 UTC

MemberPrimaryPrefix::apply() B

↳ Parent: MemberPrimaryPrefix

Complexity

Conditions	5
Paths	5

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	16
rs	8.8571
cc	5
eloc	8
nc	5
nop	1

<?php

namespace MS\PHPMD\Rule\CleanCode;

use MS\PHPMD\Guesser\TestGuesser;
use PHPMD\AbstractNode;
use PHPMD\AbstractRule;
use PHPMD\Node\ClassNode;
use PHPMD\Rule\ClassAware;

/**
 * Don't chain methods excessively. The code becomes hard to test and violate the law of demeter.
 */
class MemberPrimaryPrefix extends AbstractRule implements ClassAware
{
    use TestGuesser;

    /**
     * @param AbstractNode|ClassNode $node
     */
    public function apply(AbstractNode $node)
    {
        if (true === $this->isTest($node)) {

            return;
        }

        $maxChainCount = $this->getIntProperty('maxChainCount');

        foreach ($node->getMethods() as $method) {
            foreach ($method->findChildrenOfType('MemberPrimaryPrefix') as $memberPrimaryPrefix) {
                if (null !== $this->getMemberPrimaryPrefixWithChainCount($memberPrimaryPrefix, $maxChainCount)) {
                    $this->addViolation($memberPrimaryPrefix, [$maxChainCount]);
                }
            }
        }
    }

    /**
     * @param AbstractNode $memberPrimaryPrefix
     * @param int          $chainCount
     *
     * @return null|AbstractNode
     */
    private function getMemberPrimaryPrefixWithChainCount(AbstractNode $memberPrimaryPrefix, $chainCount)
    {
        for ($chain = 0; $chain < $chainCount; $chain++) {
            if (null === $memberPrimaryPrefix) {
                return null;
            }

            $memberPrimaryPrefix = $memberPrimaryPrefix->getFirstChildOfType('MemberPrimaryPrefix');
        }

        return $memberPrimaryPrefix;
    }
}


1			<?php
2
3			namespace MS\PHPMD\Rule\CleanCode;
4
5			use MS\PHPMD\Guesser\TestGuesser;
6			use PHPMD\AbstractNode;
7			use PHPMD\AbstractRule;
8			use PHPMD\Node\ClassNode;
9			use PHPMD\Rule\ClassAware;
10
11			/**
12			* Don't chain methods excessively. The code becomes hard to test and violate the law of demeter.
13			*/
14			class MemberPrimaryPrefix extends AbstractRule implements ClassAware
15			{
16			use TestGuesser;
17
18			/**
19			* @param AbstractNode\|ClassNode $node
20			*/
21			public function apply(AbstractNode $node)
22			{
23			if (true === $this->isTest($node)) {
			0 ignored issues – show Compatibility introduced 2016-08-23 18:30 UTC by Report Bug Copy Issue Report `$node` of type `object<PHPMD\AbstractNode>` is not a sub-type of `object<PHPMD\Node\ClassNode>`. It seems like you assume a child class of the class `PHPMD\AbstractNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
24			return;
25			}
26
27			$maxChainCount = $this->getIntProperty('maxChainCount');
28
29			foreach ($node->getMethods() as $method) {
30			foreach ($method->findChildrenOfType('MemberPrimaryPrefix') as $memberPrimaryPrefix) {
31			if (null !== $this->getMemberPrimaryPrefixWithChainCount($memberPrimaryPrefix, $maxChainCount)) {
32			$this->addViolation($memberPrimaryPrefix, [$maxChainCount]);
33			}
34			}
35			}
36			}
37
38			/**
39			* @param AbstractNode $memberPrimaryPrefix
40			* @param int $chainCount
41			*
42			* @return null\|AbstractNode
43			*/
44			private function getMemberPrimaryPrefixWithChainCount(AbstractNode $memberPrimaryPrefix, $chainCount)
45			{
46			for ($chain = 0; $chain < $chainCount; $chain++) {
47			if (null === $memberPrimaryPrefix) {
48			return null;
49			}
50
51			$memberPrimaryPrefix = $memberPrimaryPrefix->getFirstChildOfType('MemberPrimaryPrefix');
52			}
53
54			return $memberPrimaryPrefix;
55			}
56			}
57

mi-schi / phpmd-extension

GitHub Access Token became invalid

Push — master ( ea3c3c...758782 )

MemberPrimaryPrefix::apply() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like