MS\PHPMD\Rule\CleanCode\DataStructureConstants

Complexity

Total Complexity

3

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	apply()	0	10	3

<?php

namespace MS\PHPMD\Rule\CleanCode;

use PDepend\Source\AST\ASTClass;
use PHPMD\AbstractNode;
use PHPMD\Node\ClassNode;

/**
 * Don't contain constants in your data structure. Important information are distribute throughout the project.
 * You reduce the reusability.
 */
class DataStructureConstants extends AbstractDataStructure
{
    /**
     * @param AbstractNode|ClassNode|ASTClass $node
     */
    public function apply(AbstractNode $node)
    {
        if (false === $this->isDataStructure($node)) {

$node of type object<PHPMD\AbstractNode> is not a sub-type of object<PHPMD\Node\ClassNode>. It seems like you assume a child class of the class PHPMD\AbstractNode to be always present.

            return;
        }

        if (0 !== count($node->getConstants())) {
            $this->addViolation($node);
        }
    }
}