Mhor\MediaInfo\Builder\MediaInfoCommandBuilder

Complexity

Total Complexity

7

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

33.33%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	buildMediaInfoCommandRunner()	0	28	4
A	buildMediaInfoProcess()	0	27	3

<?php

namespace Mhor\MediaInfo\Builder;

use Mhor\MediaInfo\Runner\MediaInfoCommandRunner;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Process\Process;

class MediaInfoCommandBuilder
{
    /**
     * @param string $filePath
     * @param array  $configuration
     *
     * @throws \Exception
     *
     * @return MediaInfoCommandRunner
     */
    public function buildMediaInfoCommandRunner(string $filePath, array $configuration = []): MediaInfoCommandRunner
    {
        if (filter_var($filePath, FILTER_VALIDATE_URL) === false) {
            $fileSystem = new Filesystem();

            if (!$fileSystem->exists($filePath)) {
                throw new \Exception(sprintf('File "%s" does not exist', $filePath));
            }

            if (is_dir($filePath)) {
                throw new \Exception(sprintf(
                    'Expected a filename, got "%s", which is a directory',
                    $filePath
                ));
            }
        }

        $configuration = $configuration + [
            'command'                            => null,
            'use_oldxml_mediainfo_output_format' => true,
        ];

        return new MediaInfoCommandRunner($this->buildMediaInfoProcess(
            $filePath,
            $configuration['command'],
            $configuration['use_oldxml_mediainfo_output_format']
        ));
    }

    /**
     * @param string      $filePath
     * @param string|null $command
     * @param bool        $forceOldXmlOutput
     *
     * @return Process
     */
    private function buildMediaInfoProcess(string $filePath, string $command = null, array $arguments = null, bool $forceOldXmlOutput = true): Process

The parameter $arguments is not used and could be removed.

    {
        if ($command === null) {
            $command = MediaInfoCommandRunner::MEDIAINFO_COMMAND;
        }

        // arguments are given through ENV vars in order to have system escape them
        $arguments = [
            'MEDIAINFO_VAR_FILE_PATH'    => $filePath,
            'MEDIAINFO_VAR_FULL_DISPLAY' => MediaInfoCommandRunner::MEDIAINFO_FULL_DISPLAY_ARGUMENT,
            'MEDIAINFO_VAR_OUTPUT'       => MediaInfoCommandRunner::MEDIAINFO_OLDXML_OUTPUT_ARGUMENT,
        ];

        if ($forceOldXmlOutput === false) {
            $arguments['MEDIAINFO_VAR_OUTPUT'] = MediaInfoCommandRunner::MEDIAINFO_XML_OUTPUT_ARGUMENT;
        }

        $env = $arguments + [
            'LANG' => setlocale(LC_CTYPE, 0),
        ];

        return new Process(
            array_merge([$command], array_values($arguments)),
            null,
            $env
        );
    }
}