AttributeFactory::create() - Code Metrics - Inspection of "Undefined index/Invalid argument issues" - mhor/php-mediainfo - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#89)

unknown

created 2018-12-31 17:51 UTC

AttributeFactory::create() A

↳ Parent: AttributeFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	6
cts	7
cp	0.8571
rs	9.9
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3.0261

<?php

namespace Mhor\MediaInfo\Factory;

use Mhor\MediaInfo\Checker\AbstractAttributeChecker;
use Mhor\MediaInfo\Checker\CoverChecker;
use Mhor\MediaInfo\Checker\DateTimeChecker;
use Mhor\MediaInfo\Checker\DurationChecker;
use Mhor\MediaInfo\Checker\ModeChecker;
use Mhor\MediaInfo\Checker\RateChecker;
use Mhor\MediaInfo\Checker\RatioChecker;
use Mhor\MediaInfo\Checker\SizeChecker;

class AttributeFactory
{
    /**
     * @param $attribute
     * @param $value
     *
     * @return mixed
     */
    public static function create($attribute, $value)
    {
        $attributesType = self::getAllAttributeType();
        foreach ($attributesType as $attributeType) {
            if ($attributeType->isMember($attribute)) {
                return $attributeType->create($value);
            }
        }

        return $value;
    }

    /**
     * @return AbstractAttributeChecker[]
     */
    private static function getAllAttributeType()
    {
        return [
            new CoverChecker(),
            new DurationChecker(),
            new ModeChecker(),
            new RateChecker(),
            new RatioChecker(),
            new SizeChecker(),
            new DateTimeChecker(),
        ];
    }
}


1		<?php
2
3		namespace Mhor\MediaInfo\Factory;
4
5		use Mhor\MediaInfo\Checker\AbstractAttributeChecker;
6		use Mhor\MediaInfo\Checker\CoverChecker;
7		use Mhor\MediaInfo\Checker\DateTimeChecker;
8		use Mhor\MediaInfo\Checker\DurationChecker;
9		use Mhor\MediaInfo\Checker\ModeChecker;
10		use Mhor\MediaInfo\Checker\RateChecker;
11		use Mhor\MediaInfo\Checker\RatioChecker;
12		use Mhor\MediaInfo\Checker\SizeChecker;
13
14		class AttributeFactory
15		{
16		/**
17		* @param $attribute
18		* @param $value
19		*
20		* @return mixed
21		*/
22	9	public static function create($attribute, $value)
23		{
24	9	$attributesType = self::getAllAttributeType();
25	9	foreach ($attributesType as $attributeType) {
26	9	if ($attributeType->isMember($attribute)) {
27	9	return $attributeType->create($value);
28		}
29	8	}
30
31		return $value;
32		}
33
34		/**
35		* @return AbstractAttributeChecker[]
36		*/
37	9	private static function getAllAttributeType()
38		{
39		return [
40	9	new CoverChecker(),
41	9	new DurationChecker(),
42	9	new ModeChecker(),
43	9	new RateChecker(),
44	9	new RatioChecker(),
45	9	new SizeChecker(),
46	9	new DateTimeChecker(),
47	9	];
48		}
49		}
50

mhor / php-mediainfo

Pull Request — master (#89)

AttributeFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like