MediaInfoCommandRunner::wait() - Code Metrics - Inspection of "Update symfony/process component call" - mhor/php-mediainfo - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 6.0.x (#108)

by Maxime

created 2020-03-29 18:33 UTC

MediaInfoCommandRunner::wait() A

↳ Parent: MediaInfoCommandRunner

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	11
loc	11
ccs	5
cts	5
cp	1
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php

namespace Mhor\MediaInfo\Runner;

use Symfony\Component\Process\Process;

class MediaInfoCommandRunner
{
    const MEDIAINFO_COMMAND = 'mediainfo';
    const MEDIAINFO_OLDXML_OUTPUT_ARGUMENT = '--OUTPUT=OLDXML';
    const MEDIAINFO_XML_OUTPUT_ARGUMENT = '--OUTPUT=XML';
    const MEDIAINFO_FULL_DISPLAY_ARGUMENT = '-f';

    /**
     * @var Process
     */
    protected $process;

    /**
     * @param Process $process
     */
    public function __construct(Process $process)
    {
        $this->process = $process;
    }

    /**
     * @throws \RuntimeException
     *
     * @return string
     */
    public function run()
    {
        $this->process->run();
        if (!$this->process->isSuccessful()) {
            throw new \RuntimeException($this->process->getErrorOutput());
        }

        return $this->process->getOutput();
    }

    /**
     * Asynchronously start mediainfo operation.
     * Make call to MediaInfoCommandRunner::wait() afterwards to receive output.
     */
    public function start()
    {
        // just takes advantage of symfony's underlying Process framework
        // process runs in background
        $this->process->start();
    }

    /**
     * Blocks until call is complete.
     *
     * @throws \Exception        If this function is called before start()
     * @throws \RuntimeException
     *
     * @return string
     */
    public function wait()
    {
        // blocks here until process completes
        $this->process->wait();

        if (!$this->process->isSuccessful()) {
            throw new \RuntimeException($this->process->getErrorOutput());
        }

        return $this->process->getOutput();
    }
}


1			<?php
2
3			namespace Mhor\MediaInfo\Runner;
4
5			use Symfony\Component\Process\Process;
6
7			class MediaInfoCommandRunner
8			{
9			const MEDIAINFO_COMMAND = 'mediainfo';
10			const MEDIAINFO_OLDXML_OUTPUT_ARGUMENT = '--OUTPUT=OLDXML';
11			const MEDIAINFO_XML_OUTPUT_ARGUMENT = '--OUTPUT=XML';
12			const MEDIAINFO_FULL_DISPLAY_ARGUMENT = '-f';
13
14			/**
15			* @var Process
16			*/
17			protected $process;
18
19			/**
20			* @param Process $process
21			*/
22	8		public function __construct(Process $process)
23			{
24	8		$this->process = $process;
25	8		}
26
27			/**
28			* @throws \RuntimeException
29			*
30			* @return string
31			*/
32	2	View Code Duplication	public function run()
33			{
34	2		$this->process->run();
35	2		if (!$this->process->isSuccessful()) {
36	1		throw new \RuntimeException($this->process->getErrorOutput());
37			}
38
39	1		return $this->process->getOutput();
40			}
41
42			/**
43			* Asynchronously start mediainfo operation.
44			* Make call to MediaInfoCommandRunner::wait() afterwards to receive output.
45			*/
46	2		public function start()
47			{
48			// just takes advantage of symfony's underlying Process framework
49			// process runs in background
50	2		$this->process->start();
51	2		}
52
53			/**
54			* Blocks until call is complete.
55			*
56			* @throws \Exception If this function is called before start()
57			* @throws \RuntimeException
58			*
59			* @return string
60			*/
61	2	View Code Duplication	public function wait()
62			{
63			// blocks here until process completes
64	2		$this->process->wait();
65
66	2		if (!$this->process->isSuccessful()) {
67	1		throw new \RuntimeException($this->process->getErrorOutput());
68			}
69
70	1		return $this->process->getOutput();
71			}
72			}
73

mhor / php-mediainfo

Pull Request — 6.0.x (#108)

MediaInfoCommandRunner::wait() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like