TipController::updateAction() - Code Metrics - Inspection of "Add fixture load process to readme file" - mfuehrer82/symfony2-rest-example - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2d6625...c3ac0b )

by Marcel

created 2016-12-09 20:07 UTC

TipController::updateAction() A

↳ Parent: TipController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2
crap	1

<?php

namespace AppBundle\Controller;

use AppBundle\Entity\Tip;
use AppBundle\Form\Type\TipType;
use FOS\RestBundle\Controller\Annotations as FOSRest;
use Sensio\Bundle\FrameworkExtraBundle\Configuration as Sensio;
use Nelmio\ApiDocBundle\Annotation as Nelmio;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * Class TipController
 *
 * @package AppBundle\Controller
 *
 * @FOSRest\NamePrefix("api_")
 */
class TipController extends AbstractRestController
{
    /**
     * Returns a tip by given id.
     *
     * @param Tip $tip
     *
     * @Nelmio\ApiDoc(
     *    resource=true,
     *    section="Tip",
     *    description="Get tip by id.",
     *    requirements={
     *        {
     *            "name"="tip",
     *            "dataType"="integer",
     *            "requirement"="id",
     *            "description"="Id of tip"
     *        },
     *        {
     *            "name"="_format",
     *            "dataType"="string",
     *            "requirement"="json|xml",
     *            "pattern"="json",
     *            "description"="Format"
     *        }
     *     }
     * )
     *
     * @Sensio\ParamConverter("tip", class="AppBundle:Tip")
     *
     * @return Response
     */
    public function getAction(Tip $tip)
    {
        return $this->handleView($this->view($tip));
    }

    /**
     * Returns a collection of tips
     *
     * @param Request $request
     *
     * @Nelmio\ApiDoc(
     *    section="Tip",
     *    description="Get tips",
     *    requirements={
     *        {
     *            "name"="_format",
     *            "dataType"="string",
     *            "requirement"="json|xml",
     *            "pattern"="json",
     *            "description"="Format"
     *        }
     *     }
     * )
     *
     * @FOSRest\QueryParam(name="page", nullable=true, requirements="\d+", description="page number of
     * pagination (optional)")
     * @FOSRest\QueryParam(name="limit", nullable=true, requirements="\d+", description="number of entries
     * per page (optional)")
     *
     * @return Response
     */
    public function cgetAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $queryBuilder = $em->getRepository('AppBundle:Tip')->createQueryBuilder('t');

        $representation = $this->createRepresentation($request, $queryBuilder);
        $content = $this->get('serializer')->serialize($representation, $request->getRequestFormat());

        return new Response($content, Response::HTTP_OK, ['Content-Type' => 'application/hal+json']);
    }

    /**
     * @param Request $request
     *
     * @NELMIO\ApiDoc(
     *      section = "Tip",
     *      description="Create a new tip",
     *      statusCodes = {
     *          200 = "Returned when successful",
     *          400 = "Returned when request are not correct",
     *          403 = "Returned when the user is not authorized to create an tip",
     *          500 = "Returned when internal error"
     *      }
     * )
     *
     * @return Response
     *
     */
    public function newAction(Request $request)
    {
        return $this->handleRequestAction($request, new Tip());
    }

    /**
     * @param Request $request
     *
     * @FOSRest\Post("/tips")
     *
     * @NELMIO\ApiDoc(
     *      section = "Tip",
     *      description="Create a new tip",
     *      input = "AppBundle\Form\PageType",
     *      statusCodes = {
     *          200 = "Returned when successful",
     *          400 = "Returned when request are not correct",
     *          403 = "Returned when the user is not authorized to create an tip",
     *          500 = "Returned when internal error"
     *      }
     * )
     *
     * @return Response
     */
    public function createAction(Request $request)
    {
        return $this->handleRequestAction($request, new Tip());
    }

    /**
     * @param Request $request
     * @param Tip     $tip
     *
     * @FOSRest\Post
     *
     * @NELMIO\ApiDoc(
     *      section = "Tip",
     *      description="Update a tip by id.",
     *      input = "AppBundle\Form\PageType",
     *      statusCodes = {
     *          200 = "Returned when successful",
     *          400 = "Returned when request are not correct",
     *          403 = "Returned when the user is not authorized to create an tip",
     *          500 = "Returned when internal error"
     *      }
     * )
     *
     * @Sensio\ParamConverter("tip", class="AppBundle:Tip")
     *
     * @return Response
     */
    public function updateAction(Request $request, Tip $tip)
    {
        return $this->handleRequestAction($request, $tip);
    }

    /**
     * @param Tip $tip
     *
     * @Sensio\ParamConverter("tip", class="AppBundle:Tip")
     *
     * @return Response
     */
    public function deleteAction(Tip $tip)
    {
        $em = $this->getDoctrine()->getManager();
        $em->remove($tip);
        $em->flush();
    }

    /**
     * @FOSRest\NoRoute()
     *
     * @param Request $request
     * @param Tip     $tip
     *
     * @return Response
     */
    private function handleRequestAction(Request $request, Tip $tip)
    {
        $form = $this->createForm(TipType::class, $tip);
        $form->handleRequest($request);

        if (true === $form->isSubmitted() and $form->isValid()) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $em = $this->getDoctrine()->getManager();
            $em->persist($tip);
            $em->flush();

            $response = new Response($this->get('serializer')->serialize($tip, $request->getRequestFormat()));
            $response->headers->set('Location', $this->generateUrl('api_get_tip', ['tip' => $tip->getId()]));

            return $response;
        }

        return $this->view($form, 400);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


mfuehrer82 / symfony2-rest-example

Push — master ( 2d6625...c3ac0b )

TipController::updateAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like