Metaclassing\EnterpriseAuth\Exceptions\Handler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	3	1
A	unauthenticated()	0	10	3
A	report()	0	3	1

<?php

namespace Metaclassing\EnterpriseAuth\Exceptions;

use Exception;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;

class Handler extends ExceptionHandler
{
    /**
     * A list of the exception types that are not reported.
     *
     * @var array
     */
    protected $dontReport = [
        //
    ];

    /**
     * A list of the inputs that are never flashed for validation exceptions.
     *
     * @var array
     */
    protected $dontFlash = [
        'password',
        'password_confirmation',
    ];

    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception  $exception
     * @return void
     */
    public function report(Exception $exception)
    {
        parent::report($exception);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Exception  $exception
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $exception)
    {
        return parent::render($request, $exception);

The expression return parent::render($request, $exception) also could return the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Convert an authentication exception into a response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Illuminate\Auth\AuthenticationException  $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)
    {
        $middleware = \Route::getCurrentRoute()->computedMiddleware;
        if (in_array('api', $middleware) || $request->expectsJson()) {

It seems like $middleware can also be of type null; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

            $response = response()->json(['message' => 'Unauthenticated.'], 401);
        } else {
            $response = redirect()->guest(route('authentication.index'));
        }

        return $response;

The expression return $response returns the type Illuminate\Http\RedirectResponse|Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }
}