CPFValidator - Code Metrics - Inspection of "Validator deprecated fix" - merorafael/MeroBaseBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2bb920...810e98 )

by Rafael

created 2016-01-02 22:42 UTC

CPFValidator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	31.82 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	8
Bugs	3	Features	2

Metric	Value
wmc	9
c	8
b	3
f	2
lcom	1
cbo	2
dl	14
loc	44
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
D	validate()	14	38	9

How to fix Duplicated Code

<?php

namespace Mero\Bundle\BaseBundle\Validator\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Component\Validator\Exception\UnexpectedTypeException;

/**
 * @author Rafael Mello <[email protected]>
 *
 * @api
 */
class CPFValidator extends ConstraintValidator
{
    /**
     * {@inheritdoc}
     */
    public function validate($value, Constraint $constraint)
    {
        if (!$constraint instanceof CPF) {
            throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\CPF');
        }
        if (null === $value || '' === $value) {
            return;
        }
        $valueNumber = preg_replace('/[^0-9]/', '', $value);
        if (strlen($valueNumber) != 11) {

            $this->context->buildViolation($constraint->message)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setParameter('{{ value }}', $this->formatValue($value))
                ->addViolation();

            return;
        }
        if (!preg_match('/(?!(\d)\1{10})\d{11}/', $valueNumber)) {

            $this->context->buildViolation($constraint->message)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setParameter('{{ value }}', $this->formatValue($value))
                ->addViolation();

            return;
        }
        for ($t = 9; $t < 11; ++$t) {
            for ($d = 0, $c = 0; $c < $t; ++$c) {
                $d += $valueNumber{$c}
                * (($t + 1) - $c);
            }
            $d = ((10 * $d) % 11) % 10;
            if ($valueNumber{$c} != $d) {
                $this->context->buildViolation($constraint->message)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setParameter('{{ value }}', $this->formatValue($value))
                    ->addViolation();

                return;
            }
        }
    }
}


Push — master ( 2bb920...810e98 )

CPFValidator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Mero\Bundle\BaseBundle\Validator\Constraints;
4
5		use Symfony\Component\Validator\Constraint;
6		use Symfony\Component\Validator\ConstraintValidator;
7		use Symfony\Component\Validator\Exception\UnexpectedTypeException;
8
9		/**
10		* @author Rafael Mello <[email protected]>
11		*
12		* @api
13		*/
14		class CPFValidator extends ConstraintValidator
15		{
16		/**
17		* {@inheritdoc}
18		*/
19		public function validate($value, Constraint $constraint)
20		{
21		if (!$constraint instanceof CPF) {
22		throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\CPF');
23		}
24		if (null === $value \|\| '' === $value) {
25		return;
26		}
27		$valueNumber = preg_replace('/[^0-9]/', '', $value);
28	View Code Duplication	if (strlen($valueNumber) != 11) {
		0 ignored issues – show Duplication introduced 2015-12-14 13:20 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		$this->context->buildViolation($constraint->message)
		0 ignored issues – show Bug introduced 2015-12-14 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Valida...ecutionContextInterface` as the method `buildViolation()` does only exist in the following implementations of said interface: `Symfony\Component\Valida...ontext\ExecutionContext`, `Symfony\Component\Valida...\LegacyExecutionContext`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
30		->setParameter('{{ value }}', $this->formatValue($value))
31		->addViolation();
32
33		return;
34		}
35	View Code Duplication	if (!preg_match('/(?!(\d)\1{10})\d{11}/', $valueNumber)) {
		0 ignored issues – show Duplication introduced 2015-12-14 13:20 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		$this->context->buildViolation($constraint->message)
		0 ignored issues – show Bug introduced 2015-12-14 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Valida...ecutionContextInterface` as the method `buildViolation()` does only exist in the following implementations of said interface: `Symfony\Component\Valida...ontext\ExecutionContext`, `Symfony\Component\Valida...\LegacyExecutionContext`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37		->setParameter('{{ value }}', $this->formatValue($value))
38		->addViolation();
39
40		return;
41		}
42		for ($t = 9; $t < 11; ++$t) {
43		for ($d = 0, $c = 0; $c < $t; ++$c) {
44		$d += $valueNumber{$c}
45		* (($t + 1) - $c);
46		}
47		$d = ((10 * $d) % 11) % 10;
48		if ($valueNumber{$c} != $d) {
49		$this->context->buildViolation($constraint->message)
		0 ignored issues – show Bug introduced 2015-12-14 18:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Valida...ecutionContextInterface` as the method `buildViolation()` does only exist in the following implementations of said interface: `Symfony\Component\Valida...ontext\ExecutionContext`, `Symfony\Component\Valida...\LegacyExecutionContext`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
50		->setParameter('{{ value }}', $this->formatValue($value))
51		->addViolation();
52
53		return;
54		}
55		}
56		}
57		}
58

merorafael / MeroBaseBundle

Push — master ( 2bb920...810e98 )

CPFValidator A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like