Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | View Code Duplication | class CPFValidatorTest extends AbstractConstraintValidatorTest |
|
|
|||
13 | { |
||
14 | protected function getApiVersion() |
||
18 | |||
19 | protected function createValidator() |
||
23 | |||
24 | public function testNullIsValid() |
||
29 | |||
30 | public function testEmptyStringIsValid() |
||
35 | |||
36 | public function getInvalidCPFs() |
||
44 | |||
45 | /** |
||
46 | * @dataProvider getInvalidCPFs |
||
47 | */ |
||
48 | public function testInvalidCPFs($cpf) |
||
58 | |||
59 | public function getValidCPFs() |
||
67 | |||
68 | /** |
||
69 | * @dataProvider getValidCPFs |
||
70 | */ |
||
71 | public function testValidCPFs($cpf) |
||
76 | } |
||
77 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.