Merodiro\Settings\Commands\SettingsCache

Complexity

Total Complexity

6

Size/Duplication

Total Lines	60
Duplicated Lines	13.33 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	handle()	8	28	5

<?php

namespace Merodiro\Settings\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\Cache;
use Merodiro\Settings\Facades\Settings;

class SettingsCache extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'settings:cache {--model=}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Cache all settings';

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->comment('Caching all settings');
        $settings = Settings::all();
        $duration = config('settings.cache_duration');

        foreach ($settings as $key => $value) {
            $cache_key = Settings::cacheKey($key);

            Cache::put($cache_key, $value, $duration);
        }

        $model = $this->option('model');

        if (isset($model)) {
            $users = (new $model)->all();
            foreach ($users as $user) {

This code seems to be duplicated across your project.

                $settings = $user->allSettings();
                foreach ($settings as $key => $value) {
                    $cache_key = $user->settingsCacheKey($key);

                    Cache::put($cache_key, $value, $duration);
                }
            }
        }

        $this->info('Cached all settings');
    }
}