Friendable::addFriend() - Code Metrics - Inspection of "change return value of deleteFriend to boolean" - merodiro/Friendships - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 43c393...357e1b )

by Amr

created 2018-01-24 17:13 UTC

Friendable::addFriend() A

↳ Parent: Friendable

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	8
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	14
ccs	8
cts	8
cp	1
crap	2
rs	9.4285

<?php

namespace Merodiro\Friendships;

use Event;

trait Friendable
{
    public function checkFriendship($user)
    {
        if ($this->id == $user->id) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return 'same_user';
        }

        $friendship = Friendship::betweenUsers($this, $user)
            ->first();

        if (!$friendship) {
            return 'not_friends';
        }

        if ($friendship->status == 1) {
            return 'friends';
        }
        if ($friendship->requester == $this->id) {
            return 'waiting';
        }
        if ($friendship->user_requested == $this->id) {
            return 'pending';
        }
    }

    public function addFriend($recipient)
    {
        $friendshipStatus = $this->checkFriendship($recipient);

        if ($friendshipStatus == 'not_friends') {
            Event::fire('friendrequest.sent', [$this, $recipient]);

            Friendship::create([
                'requester'      => $this->id,
                'user_requested' => $recipient->id,
            ]);
        }
        return $friendshipStatus == 'not_friends';
    }

    public function acceptFriend($sender)
    {
        $friendshipStatus = $this->checkFriendship($sender);

        if ($friendshipStatus == 'pending') {
            Event::fire('friendrequest.accepted', [$this, $sender]);

            Friendship::betweenUsers($this, $sender)
                ->update(['status' => 1]);
        }
        return $friendshipStatus == 'pending';
    }

    public function deleteFriend($user)
    {
        $friendshipStatus = $this->checkFriendship($user);
        
        if ($friendshipStatus != 'not_friends') {
            Event::fire('friendship.deleted', [$this, $user]);

            Friendship::betweenUsers($this, $user)
                ->delete();
        }
        return $friendshipStatus != 'not_friends';
    }

    public function friends()
    {
        $recipients = Friendship::whereSender($this)
            ->accepted(1)
            ->get(['user_requested'])
            ->toArray();

        $senders = Friendship::whereRecipient($this)
            ->accepted(1)
            ->get(['requester'])
            ->toArray();

        $friendsIds = array_merge($recipients, $senders);

        return static::whereIn('id', $friendsIds)
            ->get();
    }

    public function friendRequestsReceived()

    {
        $senders = Friendship::whereRecipient($this)
            ->accepted(0)
            ->get(['requester'])
            ->toArray();

        return static::whereIn('id', $senders)
            ->get();
    }

    public function friendRequestsSent()

    {
        $recipients = Friendship::whereSender($this)
            ->accepted(0)
            ->get(['user_requested'])
            ->toArray();

        return static::whereIn('id', $recipients)
            ->get();
    }

    public function isFriendsWith($user)
    {
        $friendshipStatus = $this->checkFriendship($user);

        return $friendshipStatus === 'friends';
    }
}


1			<?php
2
3			namespace Merodiro\Friendships;
4
5			use Event;
6
7			trait Friendable
8			{
9	32		public function checkFriendship($user)
10			{
11	32		if ($this->id == $user->id) {
			0 ignored issues – show Bug introduced 2018-01-24 15:52 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
12	2		return 'same_user';
13			}
14
15	30		$friendship = Friendship::betweenUsers($this, $user)
16	30		->first();
17
18	30		if (!$friendship) {
19	30		return 'not_friends';
20			}
21
22	28		if ($friendship->status == 1) {
23	6		return 'friends';
24			}
25	28		if ($friendship->requester == $this->id) {
26	10		return 'waiting';
27			}
28	26		if ($friendship->user_requested == $this->id) {
29	26		return 'pending';
30			}
31			}
32
33	32		public function addFriend($recipient)
34			{
35	32		$friendshipStatus = $this->checkFriendship($recipient);
36
37	32		if ($friendshipStatus == 'not_friends') {
38	30		Event::fire('friendrequest.sent', [$this, $recipient]);
39
40	30		Friendship::create([
41	30		'requester' => $this->id,
42	30		'user_requested' => $recipient->id,
43			]);
44			}
45	32		return $friendshipStatus == 'not_friends';
46			}
47
48	20		public function acceptFriend($sender)
49			{
50	20		$friendshipStatus = $this->checkFriendship($sender);
51
52	20		if ($friendshipStatus == 'pending') {
53	18		Event::fire('friendrequest.accepted', [$this, $sender]);
54
55	18		Friendship::betweenUsers($this, $sender)
56	18		->update(['status' => 1]);
57			}
58	20		return $friendshipStatus == 'pending';
59			}
60
61	10		public function deleteFriend($user)
62			{
63	10		$friendshipStatus = $this->checkFriendship($user);
64
65	10		if ($friendshipStatus != 'not_friends') {
66	10		Event::fire('friendship.deleted', [$this, $user]);
67
68	10		Friendship::betweenUsers($this, $user)
69	10		->delete();
70			}
71	10		return $friendshipStatus != 'not_friends';
72			}
73
74	4		public function friends()
75			{
76	4		$recipients = Friendship::whereSender($this)
77	4		->accepted(1)
78	4		->get(['user_requested'])
79	4		->toArray();
80
81	4		$senders = Friendship::whereRecipient($this)
82	4		->accepted(1)
83	4		->get(['requester'])
84	4		->toArray();
85
86	4		$friendsIds = array_merge($recipients, $senders);
87
88	4		return static::whereIn('id', $friendsIds)
89	4		->get();
90			}
91
92	14	View Code Duplication	public function friendRequestsReceived()
			0 ignored issues – show Duplication introduced 2018-01-24 15:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93			{
94	14		$senders = Friendship::whereRecipient($this)
95	14		->accepted(0)
96	14		->get(['requester'])
97	14		->toArray();
98
99	14		return static::whereIn('id', $senders)
100	14		->get();
101			}
102
103	8	View Code Duplication	public function friendRequestsSent()
			0 ignored issues – show Duplication introduced 2018-01-24 15:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104			{
105	8		$recipients = Friendship::whereSender($this)
106	8		->accepted(0)
107	8		->get(['user_requested'])
108	8		->toArray();
109
110	8		return static::whereIn('id', $recipients)
111	8		->get();
112			}
113
114	4		public function isFriendsWith($user)
115			{
116	4		$friendshipStatus = $this->checkFriendship($user);
117
118	4		return $friendshipStatus === 'friends';
119			}
120			}
121

merodiro / Friendships

GitHub Access Token became invalid

Push — master ( 43c393...357e1b )

Friendable::addFriend() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like