Merodiro\Friendships\Friendable

Complexity

Total Complexity

18

Size/Duplication

Total Lines	129
Duplicated Lines	15.5 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

98.57%

Importance

Changes	5
Bugs	1	Features	2

10 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteFriend()	0	12	2
B	checkFriendship()	0	23	6
A	addFriend()	0	14	2
A	acceptFriend()	0	12	2
A	friends_ids()	0	13	1
A	friends()	0	8	1
A	friendRequestsReceived()	10	10	1
A	friendRequestsSent()	10	10	1
A	isFriendsWith()	0	6	1
A	mutualFriends()	0	9	1

<?php

namespace Merodiro\Friendships;

trait Friendable
{
    public function checkFriendship($user)
    {
        if ($this->id == $user->id) {

The property id does not exist. Did you maybe forget to declare it?

            return 'same_user';
        }

        $friendship = Friendship::betweenUsers($this, $user)
            ->first();

        if (!$friendship) {
            return 'not_friends';
        }

        if ($friendship->status == 1) {
            return 'friends';
        }
        if ($friendship->requester == $this->id) {
            return 'waiting';
        }
        if ($friendship->user_requested == $this->id) {
            return 'pending';
        }
    }

    public function addFriend($recipient)
    {
        $friendshipStatus = $this->checkFriendship($recipient);

        if ($friendshipStatus == 'not_friends') {
            Friendship::create([
                    'requester'      => $this->id,
                    'user_requested' => $recipient->id,
                ]);
            event('friendrequest.sent', [$this, $recipient]);
        }

        return $friendshipStatus == 'not_friends';
    }

    public function acceptFriend($sender)
    {
        $friendshipStatus = $this->checkFriendship($sender);

        if ($friendshipStatus == 'pending') {
            Friendship::betweenUsers($this, $sender)
                ->update(['status' => 1]);
            event('friendrequest.accepted', [$this, $sender]);
        }

        return $friendshipStatus == 'pending';
    }

    public function deleteFriend($user)
    {
        $friendshipStatus = $this->checkFriendship($user);

        if ($friendshipStatus != 'not_friends') {
            Friendship::betweenUsers($this, $user)
                ->delete();
            event('friendship.deleted', [$this, $user]);
        }

        return $friendshipStatus != 'not_friends';
    }

    public function friends_ids()
    {
        $friendsIds = Friendship::where(function ($query) {
            $query->whereSender($this);
        })->orWhere(function ($query) {
            $query->whereRecipient($this);
        })->accepted(1)->get(['user_requested', 'requester'])->toArray();

        $friendsIds = collect($friendsIds)->flatten()->unique()->reject(function ($id) {
            return $id == $this->id;
        });
        return $friendsIds;
    }

    public function friends()
    {
        $friendsIds = $this->friends_ids();

        return static::whereIn('id', $friendsIds)
            ->distinct()
            ->get();
    }

    public function friendRequestsReceived()

This method seems to be duplicated in your project.

    {
        $senders = Friendship::whereRecipient($this)
            ->accepted(0)
            ->get(['requester'])
            ->toArray();

        return static::whereIn('id', $senders)
            ->get();
    }

    public function friendRequestsSent()

This method seems to be duplicated in your project.

    {
        $recipients = Friendship::whereSender($this)
            ->accepted(0)
            ->get(['user_requested'])
            ->toArray();

        return static::whereIn('id', $recipients)
            ->get();
    }

    public function isFriendsWith($user)
    {
        $friendshipStatus = $this->checkFriendship($user);

        return $friendshipStatus === 'friends';
    }

    public function mutualFriends($user)
    {
        $userFriends = $user->friends_ids();
        $friends = $this->friends_ids();

        $mutualIds = $userFriends->intersect($friends);

        return static::whereIn('id', $mutualIds)->get();
    }
}