Friendable::ban() - Code Metrics - Inspection of "transform status to uppercase" - merodiro/Friendships - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e870d7...6c3b4a )

by Amr

created 2019-05-25 22:59 UTC

Friendable::ban() A

↳ Parent: Friendable

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Merodiro\Friendships;

trait Friendable
{
    public function checkFriendship($user)
    {
        if ($this->id == $user->id) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return 'SAME_USER';
        }

        $friendship = Friendship::betweenUsers($this, $user);


        if ($friendship->count() == 0) {
            return 'NOT_FRIENDS';
        } elseif ($friendship->count() == 2) {
            return 'FRIENDS';
        } elseif ($friendship->first()->user_id == $this->id) {
            return 'WAITING';
        } else {
            return 'PENDING';
        }
    }

    public function addFriend($recipient)
    {
        $friendshipStatus = $this->checkFriendship($recipient);

        if ($friendshipStatus == 'NOT_FRIENDS') {
            $this->friends()->attach($recipient);

            event('friendrequest.sent', [$this, $recipient]);

            return 'waiting';
        }
    }

    public function acceptFriend($sender)
    {
        $friendshipStatus = $this->checkFriendship($sender);

        if ($friendshipStatus == 'PENDING') {
            $this->friends()->attach($sender, ['status' => 1]);
            $sender->friends()->updateExistingPivot($this, ['status' => 1]);

            event('friendrequest.accepted', [$this, $sender]);

            return 'friends';
        }
    }

    public function deleteFriend($user)
    {
        $friendshipStatus = $this->checkFriendship($user);

        if ($friendshipStatus != 'NOT_FRIENDS') {
            $this->friends()->detach($user);
            $user->friends()->detach($this);

            event('friendship.deleted', [$this, $user]);

            return 'NOT_FRIENDS';
        }
    }

    public function ban($user)
    {
        $friendshipStatus = $this->checkFriendship($user);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


    }

    public function friends()
    {
        return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'user_id', 'friend_id')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where('status', 1);
    }

    public function friendRequestsReceived()
    {
        return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'friend_id', 'user_id')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where('status', 0);
    }

    public function friendRequestsSent()
    {
        return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'user_id', 'friend_id')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where('status', 0);
    }

    public function isFriendsWith($user)
    {
        return $this->friends->contains($user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function mutualFriendsCount($user)
    {
        $userFriends = $user->friends->pluck('id');
        $friends = $this->friends->pluck('id');

        return $userFriends->intersect($friends)->count();
    }

    public function mutualFriends($user)
    {
        $userFriends = $user->friends->pluck('id');
        $friends = $this->friends->pluck('id');

        $mutualIds = $userFriends->intersect($friends);

        return static::whereIn('id', $mutualIds)->get();
    }
}


1		<?php
2
3		namespace Merodiro\Friendships;
4
5		trait Friendable
6		{
7	34	public function checkFriendship($user)
8		{
9	34	if ($this->id == $user->id) {
		0 ignored issues – show Bug introduced 2018-01-24 15:52 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10	2	return 'SAME_USER';
11		}
12
13	32	$friendship = Friendship::betweenUsers($this, $user);
		0 ignored issues – show Bug introduced 2018-11-05 13:30 UTC by Report Bug Copy Issue Report The method `betweenUsers()` does not exist on `Merodiro\Friendships\Friendship`. Did you maybe mean `scopeBetweenUsers()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
14
15	32	if ($friendship->count() == 0) {
16	32	return 'NOT_FRIENDS';
17	28	} elseif ($friendship->count() == 2) {
18	8	return 'FRIENDS';
19	28	} elseif ($friendship->first()->user_id == $this->id) {
20	8	return 'WAITING';
21		} else {
22	26	return 'PENDING';
23		}
24		}
25
26	34	public function addFriend($recipient)
27		{
28	34	$friendshipStatus = $this->checkFriendship($recipient);
29
30	34	if ($friendshipStatus == 'NOT_FRIENDS') {
31	32	$this->friends()->attach($recipient);
32
33	32	event('friendrequest.sent', [$this, $recipient]);
34
35	32	return 'waiting';
36		}
37	6	}
38
39	22	public function acceptFriend($sender)
40		{
41	22	$friendshipStatus = $this->checkFriendship($sender);
42
43	22	if ($friendshipStatus == 'PENDING') {
44	20	$this->friends()->attach($sender, ['status' => 1]);
45	20	$sender->friends()->updateExistingPivot($this, ['status' => 1]);
46
47	20	event('friendrequest.accepted', [$this, $sender]);
48
49	20	return 'friends';
50		}
51	4	}
52
53	10	public function deleteFriend($user)
54		{
55	10	$friendshipStatus = $this->checkFriendship($user);
56
57	10	if ($friendshipStatus != 'NOT_FRIENDS') {
58	10	$this->friends()->detach($user);
59	10	$user->friends()->detach($this);
60
61	10	event('friendship.deleted', [$this, $user]);
62
63	10	return 'NOT_FRIENDS';
64		}
65		}
66
67		public function ban($user)
68		{
69		$friendshipStatus = $this->checkFriendship($user);
		0 ignored issues – show Unused Code introduced 2019-05-25 23:08 UTC by Report Bug Copy Issue Report `$friendshipStatus` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70
71
72		}
73
74	32	public function friends()
75		{
76	32	return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'user_id', 'friend_id')
		0 ignored issues – show Bug introduced 2018-05-16 03:50 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
77	32	->where('status', 1);
78		}
79
80	14	public function friendRequestsReceived()
81		{
82	14	return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'friend_id', 'user_id')
		0 ignored issues – show Bug introduced 2018-05-16 03:50 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
83	14	->where('status', 0);
84		}
85
86	8	public function friendRequestsSent()
87		{
88	8	return $this->belongsToMany(config('friendships.user_model'), 'friendships', 'user_id', 'friend_id')
		0 ignored issues – show Bug introduced 2018-05-16 03:50 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
89	8	->where('status', 0);
90		}
91
92	4	public function isFriendsWith($user)
93		{
94	4	return $this->friends->contains($user);
		0 ignored issues – show Bug introduced 2018-05-16 19:09 UTC by Report Bug Copy Issue Report The property `friends` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
95		}
96
97	2	public function mutualFriendsCount($user)
98		{
99	2	$userFriends = $user->friends->pluck('id');
100	2	$friends = $this->friends->pluck('id');
101
102	2	return $userFriends->intersect($friends)->count();
103		}
104
105	2	public function mutualFriends($user)
106		{
107	2	$userFriends = $user->friends->pluck('id');
108	2	$friends = $this->friends->pluck('id');
109
110	2	$mutualIds = $userFriends->intersect($friends);
111
112	2	return static::whereIn('id', $mutualIds)->get();
113		}
114		}
115

merodiro / Friendships

GitHub Access Token became invalid

Push — develop ( e870d7...6c3b4a )

Friendable::ban() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like