Kaloa\Filesystem\ExtensionFilter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	accept()	0	16	2

<?php

/*
 * This file is part of the kaloa/filesystem package.
 *
 * For full copyright and license information, please view the LICENSE file
 * that was distributed with this source code.
 */

namespace Kaloa\Filesystem;

use FilterIterator;
use Iterator;
use SplFileInfo;

/**
 * Example:
 *
 * <pre>
 * $path      = '/a/directory';
 * $whitelist = array('txt'); // List of file extensions to filter
 *
 * $iterator = new ExtensionFilterIterator(
 *                 new RecursiveIteratorIterator(
 *                     new RecursiveDirectoryIterator($path)),
 *                 $whitelist);
 *
 * foreach ($iterator as $file) {
 *     echo $file, "<br />";
 * }
 * </pre>
 *
 * @author Marc Ermshaus <marc@ermshaus.org>
 */
final class ExtensionFilter extends FilterIterator
{
    /**
     * List of allowed file extensions
     *
     * @var array
     */
    private $whitelist;

    /**
     *
     * @param Iterator $iterator
     * @param array $whitelist
     */
    public function __construct(Iterator $iterator, array $whitelist)
    {
        parent::__construct($iterator);
        $this->whitelist = array_flip($whitelist);
    }

    /**
     *
     * @return boolean
     */
    public function accept()
    {
        /* @var $fileInfo SplFileInfo */
        $fileInfo = parent::current();

It seems like you call parent on a different method (current() instead of accept()). Are you sure this is correct? If so, you might want to change this to $this->current().

        // Allow only files
        if (!$fileInfo->isFile()) {
            return false;
        }

        // Only allow file extensions from $whitelist

        $pi = pathinfo($fileInfo->getFilename());

        return (isset($this->whitelist[strtolower($pi['extension'])]));
    }
}