eloquentFilter\QueryFilter\Detection\DetectorCondition

Complexity

Total Complexity

15

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	detect()	0	12	4
A	__construct()	0	14	3
A	checkSetWhiteListFields()	0	8	3
A	handelListFields()	0	9	5

<?php

namespace eloquentFilter\QueryFilter\Detection;

use eloquentFilter\QueryFilter\Detection\Contract\DetectorConditionsContract;
use eloquentFilter\QueryFilter\Exceptions\EloquentFilterException;
use Exception;

/**
 * Class DetectorConditions.
 */
class DetectorCondition
{
    protected $errorExceptionWhileList = "You must set %s in whiteListFilter in %s
         or create a override method with name %s or call ignoreRequest function for ignore %s.";
    /**
     * @var
     */
    private $detector;

    /**
     * DetectorConditions constructor.
     *
     * @param array $detector
     */
    public function __construct(array $detector)
    {
        $detector_collect = collect($detector);

$detector of type array is incompatible with the type Illuminate\Contracts\Support\Arrayable expected by parameter $value of collect().

        $detector_collect->map(function ($detector_obj) {
            if (!empty($detector_obj)) {
                $reflect = new \ReflectionClass($detector_obj);
                if ($reflect->implementsInterface(DetectorConditionsContract::class)) {
                    return $detector_obj;
                }
            }
        })->toArray();

        $this->detector = $detector_collect;
    }

    /**
     * @param string $field
     * @param $params
     * @param null $model

Are you sure the doc-type for parameter $model is correct as it would always require null to be passed?

     *
     * @return string|null
     * @throws Exception
     *
     */
    public function detect(string $field, $params, $model = null): ?string
    {
        foreach ($this->detector as $detector_obj) {
            if ($this->handelListFields($field, $model->getWhiteListFilter(), $model->checkModelHasOverrideMethod($field), $model)) {

The method getWhiteListFilter() does not exist on null.

                $out = $detector_obj::detect($field, $params, $model->checkModelHasOverrideMethod($field));
                if (!empty($out)) {
                    return $out;
                }
            }
        }

        return null;
    }

    /**
     * @param string $field
     * @param array|null $list_white_filter_model
     * @param bool $has_method
     * @param $model_class
     *
     * @return bool
     * @throws Exception
     *
     */
    private function handelListFields(string $field, ?array $list_white_filter_model, bool $has_method, $model_class): bool
    {
        if ($this->checkSetWhiteListFields($field, $list_white_filter_model) || ($field == 'f_params' || $field == 'or') || $has_method) {
            return true;
        }

        $class_name = class_basename($model_class);

        throw new EloquentFilterException(sprintf($this->errorExceptionWhileList, $field, $class_name, $field, $field), 1);
    }

    /**
     * @param string $field
     * @param array|null $query
     *
     * @return bool
     */
    private function checkSetWhiteListFields(string $field, ?array $query): bool
    {
        if (in_array($field, $query) ||
            $query[0] == '*') {
            return true;
        }

        return false;
    }
}