Meema\MediaRecognition\Traits\CanRecognizeVideos

Complexity

Total Complexity

6

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	startDetectingLabels()	0	15	2
A	setVideoSettings()	0	29	2
A	startDetectingFaces()	0	15	2

<?php

namespace Meema\MediaRecognition\Traits;

use Exception;

trait CanRecognizeVideos
{
    /**
     * Sets the video to be analyzed.
     *
     * @param $type - used to create a readable identifier.

The doc comment - at position 0 could not be parsed: Unknown type name '-' at position 0 in -.

     * @return void
     * @throws \Exception
     */
    protected function setVideoSettings($type): void
    {
        $disk = $this->disk ?? config('media-recognition.disk');
        $bucketName = config("filesystems.disks.$disk.bucket");

        if (! $bucketName) {
            throw new Exception('Please make sure to set a S3 bucket name.');
        }

        $this->settings['Video'] = [

The property settings does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'S3Object' => [
                'Bucket' => $bucketName,
                'Name' => $this->path,
            ],
        ];

        $this->settings['NotificationChannel'] = [
            'RoleArn' => config('media-recognition.iam_arn'),
            'SNSTopicArn' => config('media-recognition.sns_topic_arn'),
        ];

        $uniqueId = $type.'_'.$this->mediaId;
        // Idempotent token used to identify the start request.
        // If you use the same token with multiple StartCelebrityRecognition requests, the same JobId is returned.
        // Use ClientRequestToken to prevent the same job from being accidentally started more than once.
        $this->settings['ClientRequestToken'] = $uniqueId;

        // the JobTag is set to be the media id, so we can adjust the media record with the results once the webhook comes in
        $this->settings['JobTag'] = $uniqueId;
    }

    /**
     * Starts the detection of labels/objects in a video.
     *
     * @param int $mediaId
     * @param int|null $minConfidence
     * @param int $maxResults
     * @return \Aws\Result
     * @throws \Exception
     */
    public function startDetectingLabels(int $mediaId, $minConfidence = null, $maxResults = 1000)
    {
        $this->mediaId = $mediaId;

The property mediaId does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->setVideoSettings('labels');
        $this->settings['MinConfidence'] = $minConfidence ?? config('media-recognition.min_confidence');

The property settings does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->settings['MaxResults'] = $maxResults;

        $results = $this->client->startLabelDetection($this->settings);

        if ($results['JobId']) {
            $this->updateJobId($results['JobId'], 'labels');

It seems like updateJobId() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $results;
    }

    /**
     * Starts the detection of faces in a video.
     *
     * @param int $mediaId
     * @param array $attributes
     * @return \Aws\Result
     * @throws \Exception
     */
    public function startDetectingFaces($mediaId = null, $attributes = ['DEFAULT'])

The parameter $attributes is not used and could be removed.

    {
        $this->mediaId = $mediaId;

The property mediaId does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->setVideoSettings('faces');

        $this->settings['MinConfidence'] = $minConfidence ?? config('media-recognition.min_confidence');

The property settings does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

The variable $minConfidence seems to never exist and therefore isset should always be false.

        $results = $this->client->startFaceDetection($this->settings);

        if ($results['JobId']) {
            $this->updateJobId($results['JobId'], 'faces');
        }

        return $results;
    }
}