Conditions | 1 |
Paths | 1 |
Total Lines | 58 |
Code Lines | 39 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
7 | public function testGettersSetters() |
||
8 | { |
||
9 | $media = new Media(); |
||
10 | |||
11 | $this->assertInstanceOf(\DateTime::class, $media->getCreatedAt()); |
||
12 | $this->assertInstanceOf(\DateTime::class, $media->getUpdatedAt()); |
||
13 | |||
14 | $media->setId(1); |
||
15 | $this->assertEquals(1, $media->getId()); |
||
16 | $this->assertEquals(1, $media->getSlug()); |
||
17 | |||
18 | $media->setTitle('Title'); |
||
19 | $this->assertEquals('Title', $media->getTitle()); |
||
20 | |||
21 | $media->setDescription('Description'); |
||
22 | $this->assertEquals('Description', $media->getDescription()); |
||
23 | |||
24 | $media->setProvider('provider'); |
||
25 | $this->assertEquals('provider', $media->getProvider()); |
||
26 | |||
27 | $media->setType('type'); |
||
28 | $this->assertEquals('type', $media->getType()); |
||
29 | |||
30 | $media->setProviderReference('referece'); |
||
31 | $this->assertEquals('referece', $media->getProviderReference()); |
||
32 | |||
33 | $media->setProviderMetaData(['metadata']); |
||
34 | $this->assertEquals(['metadata'], $media->getProviderMetaData()); |
||
35 | |||
36 | $media->setImage('image'); |
||
37 | $this->assertEquals('image', $media->getImage()); |
||
38 | |||
39 | $media->setImageMetaData(['image_metadata']); |
||
40 | $this->assertEquals(['image_metadata'], $media->getImageMetaData()); |
||
41 | |||
42 | $this->assertEquals('50-50', $media->getFocalPoint()); |
||
43 | $media->setFocalPoint('70-30'); |
||
44 | $this->assertEquals('70-30', $media->getFocalPoint()); |
||
45 | |||
46 | $media->setCopyright('MediaMonks'); |
||
47 | $this->assertEquals('MediaMonks', $media->getCopyright()); |
||
48 | |||
49 | $media->setAuthorName('MediaMonks'); |
||
50 | $this->assertEquals('MediaMonks', $media->getAuthorName()); |
||
51 | |||
52 | $media->setBinaryContent('content'); |
||
53 | $this->assertEquals('content', $media->getBinaryContent()); |
||
54 | |||
55 | $createdAt = new \DateTime; |
||
56 | $media->setCreatedAt($createdAt); |
||
57 | $this->assertEquals($createdAt, $media->getCreatedAt()); |
||
58 | |||
59 | $updatedAt = new \DateTime; |
||
60 | $media->setUpdatedAt($updatedAt); |
||
61 | $this->assertEquals($updatedAt, $media->getUpdatedAt()); |
||
62 | |||
63 | $this->assertEquals('Title (type)', (string)$media); |
||
64 | } |
||
65 | } |
||
66 |