AbstractBaseFunctionTest::getSonataFormValues() - Code Metrics - Inspection of "Migrate to different folder structure" - mediamonks/symfony-sonata-media-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7de777...9be641 )

unknown

created 2017-06-20 10:01 UTC

AbstractBaseFunctionTest::getSonataFormValues() A

↳ Parent: AbstractBaseFunctionTest

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1

<?php

namespace MediaMonks\SonataMediaBundle\Tests\Functional;

use Liip\FunctionalTestBundle\Test\WebTestCase;
use Symfony\Component\DomCrawler\Form;
use Symfony\Bundle\FrameworkBundle\Client;
use Symfony\Component\Finder\Finder;

abstract class AbstractBaseFunctionTest extends WebTestCase
{
    protected function setUp()
    {
        if (version_compare(PHP_VERSION, '5.6.0', '<')) {
            $this->markTestSkipped('Functional tests only run on PHP 5.6+');
        }

        parent::setUp();

        $this->emptyFolder($this->getMediaPathPublic());
        $this->emptyFolder($this->getMediaPathPrivate());

        \VCR\VCR::configure()
            ->setCassettePath($this->getFixturesPath())
            ->enableLibraryHooks(['curl'])
            ->setStorage('json');

        \VCR\VCR::turnOn();
    }

    /**
     * @return string
     */
    protected function getMediaPathPublic()
    {
        return __DIR__.'/web/media/';
    }

    /**
     * @return string
     */
    protected function getMediaPathPrivate()
    {
        return __DIR__.'/var/media/';
    }

    /**
     * @return string
     */
    protected function getFixturesPath()
    {
        return __DIR__.'/var/fixtures/';
    }

    /**
     * @param int $amount
     * @param string $path
     */
    protected function assertNumberOfFilesInPath($amount, $path)
    {
        $finder = new Finder();
        $finder->files()->in($path);
        $this->assertEquals($amount, $finder->count());
    }

    /**
     * @param string $path
     * @return bool
     */
    protected function emptyFolder($path)
    {
        if (file_exists($path)) {
            $di = new \RecursiveDirectoryIterator($path, \FilesystemIterator::SKIP_DOTS);
            $ri = new \RecursiveIteratorIterator($di, \RecursiveIteratorIterator::CHILD_FIRST);
            foreach ($ri as $file) {
                $file->isDir() ? rmdir($file) : unlink($file);
            }
        } else {
            @mkdir($path);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        return true;
    }

    /**
     * @return Client
     */
    protected function getAuthenticatedClient()
    {
        return $this->makeClient(true);
    }

    /**
     * @param Form $form
     * @param array $asserts
     */
    protected function assertSonataFormValues(Form $form, array $asserts)
    {
        foreach ($form->getValues() as $formKey => $formValue) {
            foreach ($asserts as $assertKey => $assertValue) {
                if (strpos($formKey, sprintf('[%s]', $assertKey)) !== false) {
                    $this->assertEquals($assertValue, $formValue);
                }
            }
        }
    }

    /**
     * @param Form $form
     * @return array
     */
    protected function getSonataFormValues(Form $form)
    {
        $values = [];
        foreach ($form->getValues() as $k => $v) {
            if (preg_match('~\[(.*)\]~', $k, $matches)) {
                $values[$matches[1]] = $v;
            }
        }

        return $values;
    }

    /**
     * @param Form $form
     * @param array $updates
     */
    protected function updateSonataFormValues(Form $form, array $updates)
    {
        foreach ($form->getValues() as $formKey => $formValue) {
            foreach ($updates as $updateKey => $updateValue) {
                if (strpos($formKey, sprintf('[%s]', $updateKey)) !== false) {
                    $form[$formKey] = $updateValue;
                }
            }
        }
    }

    /**
     * @param Form $form
     * @return mixed
     */
    protected function getSonataFormBaseKey(Form $form)
    {
        foreach ($form->getValues() as $k => $v) {
            if (preg_match('~(.*)\[(.*)\]~', $k, $matches)) {
                return $matches[1];
            }
        }

        throw new \Exception('Could not find Sonata base key in form');
    }

    /**
     * @param Form $form
     * @param string $file
     * @throws \Exception
     */
    protected function setFormBinaryContent(Form $form, $file)
    {
        $baseKey = $this->getSonataFormBaseKey($form);
        $key = sprintf('%s[binaryContent]', $baseKey);
        if (!file_exists($file)) {
            throw new \Exception('Upload file does not exist at: '.$file);
        }
        $form[$key]->upload($file);
    }
}


1			<?php
2
3			namespace MediaMonks\SonataMediaBundle\Tests\Functional;
4
5			use Liip\FunctionalTestBundle\Test\WebTestCase;
6			use Symfony\Component\DomCrawler\Form;
7			use Symfony\Bundle\FrameworkBundle\Client;
8			use Symfony\Component\Finder\Finder;
9
10			abstract class AbstractBaseFunctionTest extends WebTestCase
11			{
12			protected function setUp()
13			{
14			if (version_compare(PHP_VERSION, '5.6.0', '<')) {
15			$this->markTestSkipped('Functional tests only run on PHP 5.6+');
16			}
17
18			parent::setUp();
19
20			$this->emptyFolder($this->getMediaPathPublic());
21			$this->emptyFolder($this->getMediaPathPrivate());
22
23			\VCR\VCR::configure()
24			->setCassettePath($this->getFixturesPath())
25			->enableLibraryHooks(['curl'])
26			->setStorage('json');
27
28			\VCR\VCR::turnOn();
29			}
30
31			/**
32			* @return string
33			*/
34			protected function getMediaPathPublic()
35			{
36			return __DIR__.'/web/media/';
37			}
38
39			/**
40			* @return string
41			*/
42			protected function getMediaPathPrivate()
43			{
44			return __DIR__.'/var/media/';
45			}
46
47			/**
48			* @return string
49			*/
50			protected function getFixturesPath()
51			{
52			return __DIR__.'/var/fixtures/';
53			}
54
55			/**
56			* @param int $amount
57			* @param string $path
58			*/
59			protected function assertNumberOfFilesInPath($amount, $path)
60			{
61			$finder = new Finder();
62			$finder->files()->in($path);
63			$this->assertEquals($amount, $finder->count());
64			}
65
66			/**
67			* @param string $path
68			* @return bool
69			*/
70			protected function emptyFolder($path)
71			{
72			if (file_exists($path)) {
73			$di = new \RecursiveDirectoryIterator($path, \FilesystemIterator::SKIP_DOTS);
74			$ri = new \RecursiveIteratorIterator($di, \RecursiveIteratorIterator::CHILD_FIRST);
75			foreach ($ri as $file) {
76			$file->isDir() ? rmdir($file) : unlink($file);
77			}
78			} else {
79			@mkdir($path);
			0 ignored issues – show Security Best Practice introduced 2017-06-20 10:12 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
80			}
81
82			return true;
83			}
84
85			/**
86			* @return Client
87			*/
88			protected function getAuthenticatedClient()
89			{
90			return $this->makeClient(true);
91			}
92
93			/**
94			* @param Form $form
95			* @param array $asserts
96			*/
97			protected function assertSonataFormValues(Form $form, array $asserts)
98			{
99			foreach ($form->getValues() as $formKey => $formValue) {
100			foreach ($asserts as $assertKey => $assertValue) {
101			if (strpos($formKey, sprintf('[%s]', $assertKey)) !== false) {
102			$this->assertEquals($assertValue, $formValue);
103			}
104			}
105			}
106			}
107
108			/**
109			* @param Form $form
110			* @return array
111			*/
112			protected function getSonataFormValues(Form $form)
113			{
114			$values = [];
115			foreach ($form->getValues() as $k => $v) {
116			if (preg_match('~\[(.*)\]~', $k, $matches)) {
117			$values[$matches[1]] = $v;
118			}
119			}
120
121			return $values;
122			}
123
124			/**
125			* @param Form $form
126			* @param array $updates
127			*/
128			protected function updateSonataFormValues(Form $form, array $updates)
129			{
130			foreach ($form->getValues() as $formKey => $formValue) {
131			foreach ($updates as $updateKey => $updateValue) {
132			if (strpos($formKey, sprintf('[%s]', $updateKey)) !== false) {
133			$form[$formKey] = $updateValue;
134			}
135			}
136			}
137			}
138
139			/**
140			* @param Form $form
141			* @return mixed
142			*/
143			protected function getSonataFormBaseKey(Form $form)
144			{
145			foreach ($form->getValues() as $k => $v) {
146			if (preg_match('~(.)\[(.)\]~', $k, $matches)) {
147			return $matches[1];
148			}
149			}
150
151			throw new \Exception('Could not find Sonata base key in form');
152			}
153
154			/**
155			* @param Form $form
156			* @param string $file
157			* @throws \Exception
158			*/
159			protected function setFormBinaryContent(Form $form, $file)
160			{
161			$baseKey = $this->getSonataFormBaseKey($form);
162			$key = sprintf('%s[binaryContent]', $baseKey);
163			if (!file_exists($file)) {
164			throw new \Exception('Upload file does not exist at: '.$file);
165			}
166			$form[$key]->upload($file);
167			}
168			}
169

mediamonks / symfony-sonata-media-bundle

Push — master ( 7de777...9be641 )

AbstractBaseFunctionTest::getSonataFormValues() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like