UrlGenerator::generate() - Code Metrics - Inspection of "Add a few tests" - mediamonks/symfony-sonata-media-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11d5f2...dfaaf8 )

unknown

created 2017-01-20 11:04 UTC

UrlGenerator::generate() A

↳ Parent: UrlGenerator

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	17
c	0
b	0
f	0
ccs	8
cts	8
cp	1
rs	9.4285
cc	2
eloc	12
nc	2
nop	4
crap	2

<?php

namespace MediaMonks\SonataMediaBundle\Generator;

use MediaMonks\SonataMediaBundle\Model\MediaInterface;
use MediaMonks\SonataMediaBundle\Handler\ParameterHandlerInterface;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

class UrlGenerator
{
    /**
     * @var Router
     */
    private $router;

    /**
     * @var ParameterHandlerInterface
     */
    private $parameterHandler;

    /**
     * @var string
     */
    private $defaultRouteName;

    /**
     * @param Router $router
     * @param ParameterHandlerInterface $parameterHandler
     * @param $defaultRouteName
     */
    public function __construct(Router $router, ParameterHandlerInterface $parameterHandler, $defaultRouteName)
    {
        $this->router = $router;
        $this->parameterHandler = $parameterHandler;
        $this->defaultRouteName = $defaultRouteName;
    }

    /**
     * @param MediaInterface $media
     * @param array $parameters
     * @param null $routeName
     * @param int $referenceType
     * @return string
     */
    public function generate(
        MediaInterface $media,
        array $parameters,
        $routeName = null,
        $referenceType = UrlGeneratorInterface::ABSOLUTE_PATH
    ) {

        if (empty($routeName)) {
            $routeName = $this->defaultRouteName;
        }

        return $this->router->generate(
                $routeName,
                ['id' => $media->getId()],
                $referenceType
            ).'?'.$this->parameterHandler->getQueryString($media, $parameters);
    }
}


1		<?php
2
3		namespace MediaMonks\SonataMediaBundle\Generator;
4
5		use MediaMonks\SonataMediaBundle\Model\MediaInterface;
6		use MediaMonks\SonataMediaBundle\Handler\ParameterHandlerInterface;
7		use Symfony\Bundle\FrameworkBundle\Routing\Router;
8		use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
9
10		class UrlGenerator
11		{
12		/**
13		* @var Router
14		*/
15		private $router;
16
17		/**
18		* @var ParameterHandlerInterface
19		*/
20		private $parameterHandler;
21
22		/**
23		* @var string
24		*/
25		private $defaultRouteName;
26
27		/**
28		* @param Router $router
29		* @param ParameterHandlerInterface $parameterHandler
30		* @param $defaultRouteName
31		*/
32	1	public function __construct(Router $router, ParameterHandlerInterface $parameterHandler, $defaultRouteName)
33		{
34	1	$this->router = $router;
35	1	$this->parameterHandler = $parameterHandler;
36	1	$this->defaultRouteName = $defaultRouteName;
37	1	}
38
39		/**
40		* @param MediaInterface $media
41		* @param array $parameters
42		* @param null $routeName
43		* @param int $referenceType
44		* @return string
45		*/
46	1	public function generate(
47		MediaInterface $media,
48		array $parameters,
49		$routeName = null,
50		$referenceType = UrlGeneratorInterface::ABSOLUTE_PATH
51		) {
52
53	1	if (empty($routeName)) {
54	1	$routeName = $this->defaultRouteName;
55	1	}
56
57	1	return $this->router->generate(
58	1	$routeName,
59	1	['id' => $media->getId()],
60		$referenceType
61	1	).'?'.$this->parameterHandler->getQueryString($media, $parameters);
62		}
63		}
64

mediamonks / symfony-sonata-media-bundle

Push — master ( 11d5f2...dfaaf8 )

UrlGenerator::generate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like