MediaExtension - Code Metrics - Inspection of "Start on "file" provider" - mediamonks/symfony-sonata-media-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 26278b...61e1ff )

unknown

created 2017-01-20 16:14 UTC

MediaExtension A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	170
Duplicated Lines	27.06 %

Coupling/Cohesion

Components	2
Dependencies	7

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	8
lcom	2
cbo	7
dl	46
loc	170
ccs	0
cts	104
cp	0
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getName()	0	4	1
B	getFilters()	0	26	1
A	media()	0	17	1
A	mediaImage()	23	23	1
A	mediaDownload()	23	23	1
A	mediaType()	0	4	1
A	getProviderByMedia()	0	4	1

How to fix Duplicated Code

<?php

namespace MediaMonks\SonataMediaBundle\Twig\Extension;

use MediaMonks\SonataMediaBundle\Generator\UrlGenerator;
use MediaMonks\SonataMediaBundle\Provider\ProviderInterface;
use MediaMonks\SonataMediaBundle\Provider\ProviderPool;
use MediaMonks\SonataMediaBundle\Model\MediaInterface;

class MediaExtension extends \Twig_Extension
{
    /**
     * @var ProviderPool
     */
    private $providerPool;

    /**
     * @var UrlGenerator
     */
    private $urlGenerator;

    /**
     * @param ProviderPool $providerPool
     * @param UrlGenerator $urlGenerator
     */
    public function __construct(ProviderPool $providerPool, UrlGenerator $urlGenerator)
    {
        $this->providerPool = $providerPool;
        $this->urlGenerator = $urlGenerator;
    }

    /**
     * @return string
     */
    public function getName()
    {
        return 'media';
    }

    /**
     * @return array
     */
    public function getFilters()
    {
        return [
            new \Twig_SimpleFilter(
                'media', [$this, 'media'], [
                    'needs_environment' => true,
                    'is_safe'           => ['html'],
                ]
            ),
            new \Twig_SimpleFilter(
                'media_image', [$this, 'mediaImage'], [
                    'needs_environment' => true,
                    'is_safe'           => ['html'],
                ]
            ),
            new \Twig_SimpleFilter(
                'media_download', [$this, 'mediaDownload'], [
                    'needs_environment' => true,
                    'is_safe'           => ['html'],
                ]
            ),
            new \Twig_SimpleFilter(
                'media_type', [$this, 'mediaType']
            ),
        ];
    }

    /**
     * @param \Twig_Environment $environment
     * @param MediaInterface $media
     * @param $width
     * @param $height
     * @param array $parameters
     * @return string
     */
    public function media(
        \Twig_Environment $environment,
        MediaInterface $media,
        $width,
        $height,
        array $parameters = []
    ) {
        return $environment->render(
            $this->getProviderByMedia($media)->getMediaTemplate(),
            [
                'media'      => $media,
                'width'      => $width,
                'height'     => $height,
                'parameters' => $parameters,
            ]
        );
    }

    /**
     * @param \Twig_Environment $environment
     * @param MediaInterface $media
     * @param $width
     * @param $height
     * @param array $parameters
     * @param null $routeName
     * @return string
     */
    public function mediaImage(

        \Twig_Environment $environment,
        MediaInterface $media,
        $width,
        $height,
        array $parameters = [],
        $routeName = null
    ) {
        $parameters += [
            'w' => $width,
            'h' => $height,
        ];

        return $environment->render(
            'MediaMonksSonataMediaBundle:Image:image.html.twig',
            [
                'src'    => $this->urlGenerator->generate($media, $parameters, $routeName),
                'width'  => $width,
                'height' => $height,
                'title'  => $media->getTitle(),
            ]
        );
    }

    /**
     * @param \Twig_Environment $environment
     * @param MediaInterface $media
     * @param $width
     * @param $height
     * @param array $parameters
     * @param null $routeName
     * @return string
     */
    public function mediaDownload(

        \Twig_Environment $environment,
        MediaInterface $media,
        $width,
        $height,
        array $parameters = [],
        $routeName = null
    ) {
        $parameters += [
            'w' => $width,
            'h' => $height,
        ];

        return $environment->render(
            'MediaMonksSonataMediaBundle:Image:file.html.twig',
            [
                'src'    => $this->urlGenerator->generate($media, $parameters, $routeName),
                'width'  => $width,
                'height' => $height,
                'title'  => $media->getTitle(),
            ]
        );
    }

    /**
     * @param MediaInterface $media
     * @return string
     */
    public function mediaType(MediaInterface $media)
    {
        return $this->getProviderByMedia($media)->getName();
    }

    /**
     * @param MediaInterface $media
     * @return ProviderInterface
     */
    private function getProviderByMedia(MediaInterface $media)
    {
        return $this->providerPool->getProvider($media->getProviderName());
    }
}


1		<?php
2
3		namespace MediaMonks\SonataMediaBundle\Twig\Extension;
4
5		use MediaMonks\SonataMediaBundle\Generator\UrlGenerator;
6		use MediaMonks\SonataMediaBundle\Provider\ProviderInterface;
7		use MediaMonks\SonataMediaBundle\Provider\ProviderPool;
8		use MediaMonks\SonataMediaBundle\Model\MediaInterface;
9
10		class MediaExtension extends \Twig_Extension
11		{
12		/**
13		* @var ProviderPool
14		*/
15		private $providerPool;
16
17		/**
18		* @var UrlGenerator
19		*/
20		private $urlGenerator;
21
22		/**
23		* @param ProviderPool $providerPool
24		* @param UrlGenerator $urlGenerator
25		*/
26		public function __construct(ProviderPool $providerPool, UrlGenerator $urlGenerator)
27		{
28		$this->providerPool = $providerPool;
29		$this->urlGenerator = $urlGenerator;
30		}
31
32		/**
33		* @return string
34		*/
35		public function getName()
36		{
37		return 'media';
38		}
39
40		/**
41		* @return array
42		*/
43		public function getFilters()
44		{
45		return [
46		new \Twig_SimpleFilter(
47		'media', [$this, 'media'], [
48		'needs_environment' => true,
49		'is_safe' => ['html'],
50		]
51		),
52		new \Twig_SimpleFilter(
53		'media_image', [$this, 'mediaImage'], [
54		'needs_environment' => true,
55		'is_safe' => ['html'],
56		]
57		),
58		new \Twig_SimpleFilter(
59		'media_download', [$this, 'mediaDownload'], [
60		'needs_environment' => true,
61		'is_safe' => ['html'],
62		]
63		),
64		new \Twig_SimpleFilter(
65		'media_type', [$this, 'mediaType']
66		),
67		];
68		}
69
70		/**
71		* @param \Twig_Environment $environment
72		* @param MediaInterface $media
73		* @param $width
74		* @param $height
75		* @param array $parameters
76		* @return string
77		*/
78		public function media(
79		\Twig_Environment $environment,
80		MediaInterface $media,
81		$width,
82		$height,
83		array $parameters = []
84		) {
85		return $environment->render(
86		$this->getProviderByMedia($media)->getMediaTemplate(),
87		[
88		'media' => $media,
89		'width' => $width,
90		'height' => $height,
91		'parameters' => $parameters,
92		]
93		);
94		}
95
96		/**
97		* @param \Twig_Environment $environment
98		* @param MediaInterface $media
99		* @param $width
100		* @param $height
101		* @param array $parameters
102		* @param null $routeName
103		* @return string
104		*/
105	View Code Duplication	public function mediaImage(
		0 ignored issues – show Duplication introduced 2017-01-17 15:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		\Twig_Environment $environment,
107		MediaInterface $media,
108		$width,
109		$height,
110		array $parameters = [],
111		$routeName = null
112		) {
113		$parameters += [
114		'w' => $width,
115		'h' => $height,
116		];
117
118		return $environment->render(
119		'MediaMonksSonataMediaBundle:Image:image.html.twig',
120		[
121		'src' => $this->urlGenerator->generate($media, $parameters, $routeName),
122		'width' => $width,
123		'height' => $height,
124		'title' => $media->getTitle(),
125		]
126		);
127		}
128
129		/**
130		* @param \Twig_Environment $environment
131		* @param MediaInterface $media
132		* @param $width
133		* @param $height
134		* @param array $parameters
135		* @param null $routeName
136		* @return string
137		*/
138	View Code Duplication	public function mediaDownload(
		0 ignored issues – show Duplication introduced 2017-01-20 16:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		\Twig_Environment $environment,
140		MediaInterface $media,
141		$width,
142		$height,
143		array $parameters = [],
144		$routeName = null
145		) {
146		$parameters += [
147		'w' => $width,
148		'h' => $height,
149		];
150
151		return $environment->render(
152		'MediaMonksSonataMediaBundle:Image:file.html.twig',
153		[
154		'src' => $this->urlGenerator->generate($media, $parameters, $routeName),
155		'width' => $width,
156		'height' => $height,
157		'title' => $media->getTitle(),
158		]
159		);
160		}
161
162		/**
163		* @param MediaInterface $media
164		* @return string
165		*/
166		public function mediaType(MediaInterface $media)
167		{
168		return $this->getProviderByMedia($media)->getName();
169		}
170
171		/**
172		* @param MediaInterface $media
173		* @return ProviderInterface
174		*/
175		private function getProviderByMedia(MediaInterface $media)
176		{
177		return $this->providerPool->getProvider($media->getProviderName());
178		}
179		}
180

mediamonks / symfony-sonata-media-bundle

Push — master ( 26278b...61e1ff )

MediaExtension A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like