for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace MediaMonks\SonataMediaBundle\Controller;
use Sonata\AdminBundle\Controller\CRUDController;
use Symfony\Component\HttpFoundation\Request;
class MediaAdminController extends CRUDController
{
/**
* @return \Symfony\Component\HttpFoundation\Response
*/
public function createAction()
if (!$this->getRequest()->get('provider') && $this->getRequest()->isMethod('get')) {
return $this->render(
'@MediaMonksSonataMedia/MediaAdmin/select_provider.html.twig',
[
'providers' => $this->get('mediamonks.sonata_media.provider.pool')->getProviders(),
'base_template' => $this->getBaseTemplate(),
'admin' => $this->admin,
'action' => 'create',
]
);
}
return parent::createAction();
* @param Request $request
* @param int $id
* @return \Symfony\Component\HttpFoundation\RedirectResponse
public function imageRedirectAction(Request $request, $id)
$media = $this->getDoctrine()->getManager()->find('MediaMonksSonataMediaBundle:Media', $id);
$media
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.