Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class CRUDController extends BaseCRUDController |
||
13 | { |
||
14 | /** |
||
15 | * @return \Symfony\Component\HttpFoundation\Response |
||
16 | */ |
||
17 | 12 | public function createAction() |
|
33 | |||
34 | /** |
||
35 | * @param Request $request |
||
36 | * @param $id |
||
37 | * @return StreamedResponse |
||
38 | */ |
||
39 | 1 | View Code Duplication | public function downloadAction(Request $request, $id) |
47 | |||
48 | /** |
||
49 | * @param Request $request |
||
50 | * @param int $id |
||
51 | * @return RedirectResponse |
||
52 | */ |
||
53 | 4 | View Code Duplication | public function imageAction(Request $request, $id, $width, $height) |
61 | } |
||
62 |