Complex classes like FileProvider often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FileProvider, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
11 | class FileProvider extends AbstractProvider implements ProviderInterface, DownloadableProviderInterface |
||
12 | { |
||
13 | /** |
||
14 | * @var array |
||
15 | */ |
||
16 | private $fileConstraintOptions = []; |
||
17 | |||
18 | /** |
||
19 | * @param array $fileConstraintOptions |
||
20 | */ |
||
21 | 15 | public function __construct(array $fileConstraintOptions = []) |
|
25 | |||
26 | /** |
||
27 | * @param FormMapper $formMapper |
||
28 | */ |
||
29 | 4 | public function buildProviderCreateForm(FormMapper $formMapper) |
|
33 | |||
34 | /** |
||
35 | * @param FormMapper $formMapper |
||
36 | */ |
||
37 | 2 | public function buildProviderEditFormBefore(FormMapper $formMapper) |
|
41 | |||
42 | /** |
||
43 | * @param AbstractMedia $media |
||
44 | * @param bool $providerReferenceUpdated |
||
45 | */ |
||
46 | 2 | public function update(AbstractMedia $media, $providerReferenceUpdated) |
|
60 | |||
61 | /** |
||
62 | * @return string |
||
63 | */ |
||
64 | 12 | public function getIcon(): string |
|
68 | |||
69 | /** |
||
70 | * @return string |
||
71 | */ |
||
72 | 13 | public function getName(): string |
|
76 | |||
77 | /** |
||
78 | * @return string |
||
79 | */ |
||
80 | 4 | public function getType(): string |
|
84 | |||
85 | /** |
||
86 | * @param AbstractMedia $media |
||
87 | */ |
||
88 | 2 | protected function setFileImage(AbstractMedia $media) |
|
106 | |||
107 | /** |
||
108 | * @param FormMapper $formMapper |
||
109 | * @param string $name |
||
110 | * @param string $label |
||
111 | * @param array $options |
||
112 | */ |
||
113 | 2 | public function addFileField(FormMapper $formMapper, $name, $label, $options = []) |
|
117 | |||
118 | /** |
||
119 | * @param FormMapper $formMapper |
||
120 | * @param string $name |
||
121 | * @param string $label |
||
122 | * @param array $options |
||
123 | */ |
||
124 | 4 | public function addRequiredFileField(FormMapper $formMapper, $name, $label, $options = []) |
|
128 | |||
129 | /** |
||
130 | * @param array $options |
||
131 | * @return array |
||
132 | */ |
||
133 | 4 | private function getFileFieldConstraints(array $options): array |
|
140 | |||
141 | /** |
||
142 | * @param array $options |
||
143 | * @return array |
||
144 | */ |
||
145 | 4 | protected function getFileConstraintOptions(array $options = []): array |
|
152 | |||
153 | /** |
||
154 | * @param $object |
||
155 | * @param ExecutionContextInterface $context |
||
156 | */ |
||
157 | 4 | public function validateExtension($object, ExecutionContextInterface $context) |
|
170 | |||
171 | /** |
||
172 | * @param $extension |
||
173 | * @return string |
||
174 | */ |
||
175 | 3 | protected function getImageByExtension($extension): string |
|
210 | |||
211 | /** |
||
212 | * @return string[] |
||
213 | */ |
||
214 | 3 | protected function getArchiveExtensions(): array |
|
218 | |||
219 | /** |
||
220 | * @return string[] |
||
221 | */ |
||
222 | 3 | protected function getAudioExtensions(): array |
|
226 | |||
227 | /** |
||
228 | * @return string[] |
||
229 | */ |
||
230 | 3 | protected function getCodeExtensions(): array |
|
234 | |||
235 | /** |
||
236 | * @return string[] |
||
237 | */ |
||
238 | 3 | protected function getSpreadsheetExtensions(): array |
|
242 | |||
243 | /** |
||
244 | * @return string[] |
||
245 | */ |
||
246 | 3 | protected function getImageExtensions(): array |
|
250 | |||
251 | /** |
||
252 | * @return string[] |
||
253 | */ |
||
254 | 3 | protected function getMovieExtensions(): array |
|
258 | |||
259 | /** |
||
260 | * @return string[] |
||
261 | */ |
||
262 | 3 | protected function getPdfExtensions(): array |
|
266 | |||
267 | /** |
||
268 | * @return string[] |
||
269 | */ |
||
270 | 3 | protected function getPresentationExtensions(): array |
|
274 | |||
275 | /** |
||
276 | * @return string[] |
||
277 | */ |
||
278 | 3 | protected function getTextExtensions(): array |
|
282 | |||
283 | /** |
||
284 | * @return string[] |
||
285 | */ |
||
286 | 1 | protected function getWordExtensions(): array |
|
290 | |||
291 | /** |
||
292 | * @param $imageFilename |
||
293 | * @return string |
||
294 | */ |
||
295 | 2 | protected function getImageLocation($imageFilename): string |
|
304 | } |
||
305 |