MediaMonks\CrawlerBundle\MediaMonksCrawlerBundle

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

55.56%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	build()	0	5	1
A	getContainerExtension()	0	8	2

<?php

namespace MediaMonks\CrawlerBundle;

use MediaMonks\CrawlerBundle\DependencyInjection\Compiler\UrlMatcherPass;
use MediaMonks\CrawlerBundle\DependencyInjection\Compiler\UrlNormalizerPass;
use MediaMonks\CrawlerBundle\DependencyInjection\MediaMonksCrawlerExtension;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Bundle\Bundle;

/**
 * @author Robert Slootjes <robert@mediamonks.com>
 */
class MediaMonksCrawlerBundle extends Bundle
{
    /**
     * @param ContainerBuilder $container
     */
    public function build(ContainerBuilder $container)
    {
        $container->addCompilerPass(new UrlMatcherPass());
        $container->addCompilerPass(new UrlNormalizerPass());
    }

    /**
     * @inheritdoc
     */
    public function getContainerExtension()
    {
        if (null === $this->extension) {
            $this->extension = new MediaMonksCrawlerExtension();
        }

        return $this->extension;

The expression $this->extension; of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|false adds false to the return on line 34 which is incompatible with the return type declared by the interface Symfony\Component\HttpKernel\Bundle\BundleInterface::getContainerExtension of type Symfony\Component\DependencyInjection\Extension\ExtensionInterface|null. It seems like you forgot to handle an error condition.

    }
}