Issues in RouteEventSubscriber.php (8.x-1.x) - Issues in 8.x-1.x - mediamonks/drupal-controller-annotations - Measure and Improve Code Quality continuously with Scrutinizer

Issues (22)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/EventSubscriber/RouteEventSubscriber.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Drupal\controller_annotations\EventSubscriber;

use Doctrine\Common\Annotations\AnnotationRegistry;
use Drupal\Core\Routing\RouteBuildEvent;
use Drupal\Core\Routing\RoutingEvents;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Routing\Loader\AnnotationDirectoryLoader;
use Symfony\Component\Routing\Route;

class RouteEventSubscriber implements EventSubscriberInterface
{
    /**
     * @var AnnotationDirectoryLoader
     */
    private $annotationDirectoryLoader;

    /**
     * @var string
     */
    private $rootPath;

    /**
     * @param AnnotationDirectoryLoader $annotationDirectoryLoader
     * @param string $rootPath
     */
    public function __construct(AnnotationDirectoryLoader $annotationDirectoryLoader, string $rootPath)
    {
        $this->registerAnnotations();
        $this->annotationDirectoryLoader = $annotationDirectoryLoader;
        $this->rootPath = $rootPath;
    }

    /**
     * Configure the annotation registry to make routing annotations available
     */
    private function registerAnnotations()
    {
        AnnotationRegistry::registerLoader('class_exists');

    }

    /**
     * @param RouteBuildEvent $event
     * @throws \Exception
     */
    public function onRoutes(RouteBuildEvent $event)
    {
        /**
         * @var $route Route
         */
        foreach ($event->getRouteCollection() as $name => $route) {
            if ($route->hasOption('type')
                && $route->getOption('type') === 'annotation'
            ) {
                $routeCollection = $this->annotationDirectoryLoader->load($this->rootPath.$this->getRoutePath($route));
                $routeCollection->addPrefix($route->getPath());

                $event->getRouteCollection()->addCollection($routeCollection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $event->getRouteCollection()->remove($name);
            }
        }
    }

    /**
     * @return array
     */
    public static function getSubscribedEvents()
    {
        return [
            RoutingEvents::DYNAMIC => [
                ['onRoutes', 0],
            ],
        ];
    }

    /**
     * @param Route $route
     * @return string
     * @throws \Exception
     */
    protected function getRoutePath(Route $route)
    {
        if ($route->hasOption('path')) {
            $path = $route->getOption('path');
        } elseif ($route->hasOption('module')) {
            $path = sprintf('/%s/src/Controller', drupal_get_path('module', $route->getOption('module')));
        } else {
            throw new \Exception(
                'Either the "resource" or "module"  option is required to load from annotations'
            );
        }

        return $path;
    }
}


1		<?php
2
3		namespace Drupal\controller_annotations\EventSubscriber;
4
5		use Doctrine\Common\Annotations\AnnotationRegistry;
6		use Drupal\Core\Routing\RouteBuildEvent;
7		use Drupal\Core\Routing\RoutingEvents;
8		use Symfony\Component\EventDispatcher\EventSubscriberInterface;
9		use Symfony\Component\Routing\Loader\AnnotationDirectoryLoader;
10		use Symfony\Component\Routing\Route;
11
12		class RouteEventSubscriber implements EventSubscriberInterface
13		{
14		/**
15		* @var AnnotationDirectoryLoader
16		*/
17		private $annotationDirectoryLoader;
18
19		/**
20		* @var string
21		*/
22		private $rootPath;
23
24		/**
25		* @param AnnotationDirectoryLoader $annotationDirectoryLoader
26		* @param string $rootPath
27		*/
28	11	public function __construct(AnnotationDirectoryLoader $annotationDirectoryLoader, string $rootPath)
29		{
30	11	$this->registerAnnotations();
31	11	$this->annotationDirectoryLoader = $annotationDirectoryLoader;
32	11	$this->rootPath = $rootPath;
33	11	}
34
35		/**
36		* Configure the annotation registry to make routing annotations available
37		*/
38	11	private function registerAnnotations()
39		{
40	11	AnnotationRegistry::registerLoader('class_exists');
		0 ignored issues – show Deprecated Code introduced 2019-03-06 08:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Doctrine\Common\Annotati...istry::registerLoader()` has been deprecated with message: this method is deprecated and will be removed in doctrine/annotations 2.0 autoloading should be deferred to the globally registered autoloader by then. For now, use @example AnnotationRegistry::registerLoader('class_exists') This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
41	11	}
42
43		/**
44		* @param RouteBuildEvent $event
45		* @throws \Exception
46		*/
47	11	public function onRoutes(RouteBuildEvent $event)
48		{
49		/**
50		* @var $route Route
51		*/
52	11	foreach ($event->getRouteCollection() as $name => $route) {
53	10	if ($route->hasOption('type')
54	10	&& $route->getOption('type') === 'annotation'
55		) {
56	9	$routeCollection = $this->annotationDirectoryLoader->load($this->rootPath.$this->getRoutePath($route));
57	8	$routeCollection->addPrefix($route->getPath());
58
59	8	$event->getRouteCollection()->addCollection($routeCollection);
		0 ignored issues – show Documentation introduced 2019-03-05 20:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$routeCollection` is of type `object<Symfony\Component\Routing\RouteCollection>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60	9	$event->getRouteCollection()->remove($name);
61		}
62		}
63	10	}
64
65		/**
66		* @return array
67		*/
68	7	public static function getSubscribedEvents()
69		{
70		return [
71	7	RoutingEvents::DYNAMIC => [
72		['onRoutes', 0],
73		],
74		];
75		}
76
77		/**
78		* @param Route $route
79		* @return string
80		* @throws \Exception
81		*/
82	9	protected function getRoutePath(Route $route)
83		{
84	9	if ($route->hasOption('path')) {
85	1	$path = $route->getOption('path');
86	8	} elseif ($route->hasOption('module')) {
87	7	$path = sprintf('/%s/src/Controller', drupal_get_path('module', $route->getOption('module')));
88		} else {
89	1	throw new \Exception(
90	1	'Either the "resource" or "module" option is required to load from annotations'
91		);
92		}
93
94	8	return $path;
95		}
96		}
97

mediamonks / drupal-controller-annotations

Issues (22)

Security Analysis not enabled

src/EventSubscriber/RouteEventSubscriber.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like