Issues in Title.php (8.x-1.x) - Issues in 8.x-1.x - mediamonks/drupal-controller-annotations - Measure and Improve Code Quality continuously with Scrutinizer

Issues (22)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Configuration/Title.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Drupal\controller_annotations\Configuration;

use Symfony\Component\Routing\Route as RoutingRoute;

/**
 * @Annotation
 */
class Title extends ConfigurationAnnotation implements RouteModifierMethodInterface, RouteModifierClassInterface
{
    /**
     * @var string
     */
    protected $value;

    /**
     * @var array
     */
    protected $arguments;

    /**
     * @var array
     */
    protected $context;

    /**
     * @var string
     */
    protected $callback;

    /**
     * @param $title
     */
    public function setValue($title)
    {
        $this->setTitle($title);
    }

    /**
     * @return bool
     */
    public function hasTitle()
    {
        return !empty($this->value);
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return $this->value;
    }

    /**
     * @param string $title
     */
    public function setTitle($title)
    {
        $this->value = $title;
    }

    /**
     * @return bool
     */
    public function hasArguments()
    {
        return !empty($this->arguments);
    }

    /**
     * @return array
     */
    public function getArguments()
    {
        return $this->arguments;
    }

    /**
     * @param array $arguments
     */
    public function setArguments(array $arguments)
    {
        $this->arguments = $arguments;
    }

    /**
     * @return bool
     */
    public function hasContext()
    {
        return !empty($this->context);
    }

    /**
     * @return array
     */
    public function getContext()
    {
        return $this->context;
    }

    /**
     * @param array $context
     */
    public function setContext(array $context)
    {
        $this->context = $context;
    }

    /**
     * @return bool
     */
    public function hasCallback()
    {
        return !empty($this->callback);
    }

    /**
     * @return string
     */
    public function getCallback()
    {
        return $this->callback;
    }

    /**
     * @param string $callback
     */
    public function setCallback($callback)
    {
        $this->callback = $callback;
    }

    /**
     * @return string
     */
    public function getAliasName()
    {
        return 'title';
    }

    /**
     * @return bool
     */
    public function allowArray()
    {
        return false;
    }

    /**
     * @param RoutingRoute $route
     * @param \ReflectionClass $class
     * @param \ReflectionMethod $method
     */
    public function modifyRouteClass(RoutingRoute $route, \ReflectionClass $class, \ReflectionMethod $method)
    {
        $this->modifyRoute($route, $class);
    }

    /**
     * @param RoutingRoute $route
     * @param \ReflectionClass $class
     * @param \ReflectionMethod $method
     */
    public function modifyRouteMethod(RoutingRoute $route, \ReflectionClass $class, \ReflectionMethod $method)
    {
        $this->modifyRoute($route, $class);
    }

    /**
     * @param RoutingRoute $route
     * @param \ReflectionClass $class
     */
    protected function modifyRoute(RoutingRoute $route, \ReflectionClass $class)
    {
        if ($this->hasTitle()) {
            $route->setDefault('_title', $this->getTitle());
        }
        if ($this->hasArguments()) {
            $route->setDefault('_title_arguments', $this->getArguments());
        }
        if ($this->hasContext()) {
            $route->setDefault('_title_context', $this->getContext());
        }

        $this->registerCallback($route, $class);
    }

    /**
     * @param RoutingRoute $route
     * @param \ReflectionClass $class
     */
    protected function registerCallback(RoutingRoute $route, \ReflectionClass $class)

    {
        if ($this->hasCallback()) {
            if (strpos($this->getCallback(), '::') === false && $class->hasMethod($this->getCallback())) {
                $this->setCallback(sprintf('%s::%s', $class->getName(), $this->getCallback()));

            }
            $route->setDefault('_title_callback', $this->getCallback());
        }
    }
}


1			<?php
2
3			namespace Drupal\controller_annotations\Configuration;
4
5			use Symfony\Component\Routing\Route as RoutingRoute;
6
7			/**
8			* @Annotation
9			*/
10			class Title extends ConfigurationAnnotation implements RouteModifierMethodInterface, RouteModifierClassInterface
11			{
12			/**
13			* @var string
14			*/
15			protected $value;
16
17			/**
18			* @var array
19			*/
20			protected $arguments;
21
22			/**
23			* @var array
24			*/
25			protected $context;
26
27			/**
28			* @var string
29			*/
30			protected $callback;
31
32			/**
33			* @param $title
34			*/
35	8		public function setValue($title)
36			{
37	8		$this->setTitle($title);
38	8		}
39
40			/**
41			* @return bool
42			*/
43	9		public function hasTitle()
44			{
45	9		return !empty($this->value);
46			}
47
48			/**
49			* @return string
50			*/
51	8		public function getTitle()
52			{
53	8		return $this->value;
54			}
55
56			/**
57			* @param string $title
58			*/
59	8		public function setTitle($title)
60			{
61	8		$this->value = $title;
62	8		}
63
64			/**
65			* @return bool
66			*/
67	9		public function hasArguments()
68			{
69	9		return !empty($this->arguments);
70			}
71
72			/**
73			* @return array
74			*/
75	8		public function getArguments()
76			{
77	8		return $this->arguments;
78			}
79
80			/**
81			* @param array $arguments
82			*/
83	8		public function setArguments(array $arguments)
84			{
85	8		$this->arguments = $arguments;
86	8		}
87
88			/**
89			* @return bool
90			*/
91	9		public function hasContext()
92			{
93	9		return !empty($this->context);
94			}
95
96			/**
97			* @return array
98			*/
99	1		public function getContext()
100			{
101	1		return $this->context;
102			}
103
104			/**
105			* @param array $context
106			*/
107	1		public function setContext(array $context)
108			{
109	1		$this->context = $context;
110	1		}
111
112			/**
113			* @return bool
114			*/
115	9		public function hasCallback()
116			{
117	9		return !empty($this->callback);
118			}
119
120			/**
121			* @return string
122			*/
123	9		public function getCallback()
124			{
125	9		return $this->callback;
126			}
127
128			/**
129			* @param string $callback
130			*/
131	9		public function setCallback($callback)
132			{
133	9		$this->callback = $callback;
134	9		}
135
136			/**
137			* @return string
138			*/
139	1		public function getAliasName()
140			{
141	1		return 'title';
142			}
143
144			/**
145			* @return bool
146			*/
147	1		public function allowArray()
148			{
149	1		return false;
150			}
151
152			/**
153			* @param RoutingRoute $route
154			* @param \ReflectionClass $class
155			* @param \ReflectionMethod $method
156			*/
157	1		public function modifyRouteClass(RoutingRoute $route, \ReflectionClass $class, \ReflectionMethod $method)
158			{
159	1		$this->modifyRoute($route, $class);
160	1		}
161
162			/**
163			* @param RoutingRoute $route
164			* @param \ReflectionClass $class
165			* @param \ReflectionMethod $method
166			*/
167	8		public function modifyRouteMethod(RoutingRoute $route, \ReflectionClass $class, \ReflectionMethod $method)
168			{
169	8		$this->modifyRoute($route, $class);
170	8		}
171
172			/**
173			* @param RoutingRoute $route
174			* @param \ReflectionClass $class
175			*/
176	9		protected function modifyRoute(RoutingRoute $route, \ReflectionClass $class)
177			{
178	9		if ($this->hasTitle()) {
179	8		$route->setDefault('_title', $this->getTitle());
180			}
181	9		if ($this->hasArguments()) {
182	8		$route->setDefault('_title_arguments', $this->getArguments());
183			}
184	9		if ($this->hasContext()) {
185	1		$route->setDefault('_title_context', $this->getContext());
186			}
187
188	9		$this->registerCallback($route, $class);
189	9		}
190
191			/**
192			* @param RoutingRoute $route
193			* @param \ReflectionClass $class
194			*/
195	9	View Code Duplication	protected function registerCallback(RoutingRoute $route, \ReflectionClass $class)
			0 ignored issues – show Duplication introduced 2017-08-11 09:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
196			{
197	9		if ($this->hasCallback()) {
198	9		if (strpos($this->getCallback(), '::') === false && $class->hasMethod($this->getCallback())) {
199	8		$this->setCallback(sprintf('%s::%s', $class->getName(), $this->getCallback()));
			0 ignored issues – show Bug introduced 2017-08-11 09:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using `$class->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
200			}
201	9		$route->setDefault('_title_callback', $this->getCallback());
202			}
203	9		}
204			}
205

mediamonks / drupal-controller-annotations

Issues (22)

Security Analysis not enabled

src/Configuration/Title.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like