1 | <?php |
||
14 | class ParamConverterManager |
||
15 | { |
||
16 | /** |
||
17 | * @var array |
||
18 | */ |
||
19 | protected $converters = []; |
||
20 | |||
21 | /** |
||
22 | * @var array |
||
23 | */ |
||
24 | protected $namedConverters = []; |
||
25 | |||
26 | /** |
||
27 | * Applies all converters to the passed configurations and stops when a |
||
28 | * converter is applied it will move on to the next configuration and so on. |
||
29 | * |
||
30 | * @param Request $request |
||
31 | * @param array|object $configurations |
||
32 | */ |
||
33 | 12 | public function apply(Request $request, $configurations) |
|
34 | { |
||
35 | 12 | if (is_object($configurations)) { |
|
36 | 1 | $configurations = [$configurations]; |
|
37 | } |
||
38 | |||
39 | 12 | foreach ($configurations as $configuration) { |
|
40 | 6 | $this->applyConverter($request, $configuration); |
|
41 | } |
||
42 | 10 | } |
|
43 | |||
44 | /** |
||
45 | * Apply converter on request based on the given configuration. |
||
46 | * |
||
47 | * @param Request $request |
||
48 | * @param ConfigurationInterface $configuration |
||
49 | */ |
||
50 | 6 | protected function applyConverter(Request $request, ConfigurationInterface $configuration) |
|
91 | |||
92 | /** |
||
93 | * Adds a parameter converter. |
||
94 | * |
||
95 | * Converters match either explicitly via $name or by iteration over all |
||
96 | * converters with a $priority. If you pass a $priority = null then the |
||
97 | * added converter will not be part of the iteration chain and can only |
||
98 | * be invoked explicitly. |
||
99 | * |
||
100 | * @param ParamConverterInterface $converter A ParamConverterInterface instance |
||
101 | * @param int $priority The priority (between -10 and 10). |
||
102 | * @param string $name Name of the converter. |
||
103 | */ |
||
104 | 12 | public function add(ParamConverterInterface $converter, $priority = 0, $name = null) |
|
118 | |||
119 | /** |
||
120 | * Returns all registered param converters. |
||
121 | * |
||
122 | * @return array An array of param converters |
||
123 | */ |
||
124 | 3 | public function all() |
|
135 | } |
||
136 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: