Issues in HttpImposter.php (master) - Issues in master - meare/juggler - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Imposter/HttpImposter.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Meare\Juggler\Imposter;


use Meare\Juggler\Exception\Client\NotFoundException;
use Meare\Juggler\Imposter\Stub\Predicate\IPredicate;
use Meare\Juggler\Imposter\Stub\Response\IResponse;

class HttpImposter extends Imposter
{
    /**
     * @var string
     */
    protected $protocol = self::PROTOCOL_HTTP;

    /**
     * @var Stub\Stub[]
     */
    private $stubs = [];

    /**
     * @return array
     */
    public function jsonSerialize()
    {
        return \Meare\Juggler\array_filter_null([
            'port'     => $this->getPort(),
            'protocol' => $this->getProtocol(),
            'name'     => $this->getName(),
            'requests' => $this->hasRequests() ? $this->serializeRequests() : null,
            'stubs'    => $this->jsonSerializeStubs(),
        ]);
    }

    /**
     * @return array
     */
    private function serializeRequests()
    {
        $requests = $this->requests;
        foreach ($requests as $key => $request) {
            if (isset($request['query'])) {

                $requests[$key]['query'] = \Meare\Juggler\json_object($request['query']);
            }
            if (isset($request['headers'])) {

                $requests[$key]['headers'] = \Meare\Juggler\json_object($request['headers']);
            }
        }

        return $requests;
    }

    /**
     * @return array
     */
    private function jsonSerializeStubs()
    {
        $stubs = [];
        foreach ($this->stubs as $stub) {
            $stubs[] = $stub->jsonSerialize();
        }

        return $stubs;
    }

    /**
     * @param IResponse[]|IResponse   $responses
     * @param IPredicate[]|IPredicate $predicates
     * @return Stub\Stub
     */
    public function createStub($responses = null, $predicates = null)
    {
        $stub = new Stub\Stub($responses, $predicates);

        $this->addStub($stub);

        return $stub;
    }

    /**
     * @param Stub\Stub $stub
     */
    public function addStub(Stub\Stub $stub)
    {
        $this->stubs[] = $stub;
    }

    /**
     * @return Stub\Stub[]
     */
    public function getStubs()
    {
        return $this->stubs;
    }

    /**
     * @param Stub\Stub[] $stubs
     */
    public function setStubs(array $stubs)
    {
        $this->clearStubs();
        $this->addStubs($stubs);
    }

    public function clearStubs()
    {
        $this->stubs = [];
    }

    /**
     * @param Stub\Stub[] $stubs
     */
    public function addStubs(array $stubs)
    {
        foreach ($stubs as $stub) {
            $this->addStub($stub);
        }
    }

    /**
     * @param Stub\Stub $stub
     * @throws NotFoundException
     */
    public function removeStub(Stub\Stub $stub)
    {
        foreach ($this->stubs as $key => $s) {
            if ($s === $stub) {
                unset($this->stubs[$key]);

                return;
            }
        }
        throw new NotFoundException('Unable to find stub');
    }

    /**
     * @param array $criteria
     * @return Stub\Stub
     * @throws NotFoundException
     */
    public function findStubByPredicates($criteria)
    {
        foreach ($this->stubs as $stub) {
            if ($stub->isPredicatesMatch($criteria)) {
                return $stub;
            }
        }
        throw new NotFoundException('Unable to find stub');
    }
}


1			<?php
2
3			namespace Meare\Juggler\Imposter;
4
5
6			use Meare\Juggler\Exception\Client\NotFoundException;
7			use Meare\Juggler\Imposter\Stub\Predicate\IPredicate;
8			use Meare\Juggler\Imposter\Stub\Response\IResponse;
9
10			class HttpImposter extends Imposter
11			{
12			/**
13			* @var string
14			*/
15			protected $protocol = self::PROTOCOL_HTTP;
16
17			/**
18			* @var Stub\Stub[]
19			*/
20			private $stubs = [];
21
22			/**
23			* @return array
24			*/
25	8		public function jsonSerialize()
26			{
27	8		return \Meare\Juggler\array_filter_null([
28	8		'port' => $this->getPort(),
29	8		'protocol' => $this->getProtocol(),
30	8		'name' => $this->getName(),
31	8		'requests' => $this->hasRequests() ? $this->serializeRequests() : null,
32	8		'stubs' => $this->jsonSerializeStubs(),
33	8		]);
34			}
35
36			/**
37			* @return array
38			*/
39	3		private function serializeRequests()
40			{
41	3		$requests = $this->requests;
42	3		foreach ($requests as $key => $request) {
43	3	View Code Duplication	if (isset($request['query'])) {
			0 ignored issues – show Duplication introduced 2016-08-16 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44	1		$requests[$key]['query'] = \Meare\Juggler\json_object($request['query']);
45	1		}
46	3	View Code Duplication	if (isset($request['headers'])) {
			0 ignored issues – show Duplication introduced 2016-08-16 22:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47	1		$requests[$key]['headers'] = \Meare\Juggler\json_object($request['headers']);
48	1		}
49	3		}
50
51	3		return $requests;
52			}
53
54			/**
55			* @return array
56			*/
57	8		private function jsonSerializeStubs()
58			{
59	8		$stubs = [];
60	8		foreach ($this->stubs as $stub) {
61	1		$stubs[] = $stub->jsonSerialize();
62	8		}
63
64	8		return $stubs;
65			}
66
67			/**
68			* @param IResponse[]\|IResponse $responses
69			* @param IPredicate[]\|IPredicate $predicates
70			* @return Stub\Stub
71			*/
72	1		public function createStub($responses = null, $predicates = null)
73			{
74	1		$stub = new Stub\Stub($responses, $predicates);
			0 ignored issues – show Bug introduced 2016-12-27 22:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$responses` defined by parameter `$responses` on line 72 can also be of type `null`; however, `Meare\Juggler\Imposter\Stub\Stub::__construct()` does only seem to accept `object<Meare\Juggler\Imp...ub\Response\IResponse>>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
75	1		$this->addStub($stub);
76
77	1		return $stub;
78			}
79
80			/**
81			* @param Stub\Stub $stub
82			*/
83	7		public function addStub(Stub\Stub $stub)
84			{
85	7		$this->stubs[] = $stub;
86	7		}
87
88			/**
89			* @return Stub\Stub[]
90			*/
91	3		public function getStubs()
92			{
93	3		return $this->stubs;
94			}
95
96			/**
97			* @param Stub\Stub[] $stubs
98			*/
99	2		public function setStubs(array $stubs)
100			{
101	2		$this->clearStubs();
102	2		$this->addStubs($stubs);
103	2		}
104
105	2		public function clearStubs()
106			{
107	2		$this->stubs = [];
108	2		}
109
110			/**
111			* @param Stub\Stub[] $stubs
112			*/
113	2		public function addStubs(array $stubs)
114			{
115	2		foreach ($stubs as $stub) {
116	2		$this->addStub($stub);
117	2		}
118	2		}
119
120			/**
121			* @param Stub\Stub $stub
122			* @throws NotFoundException
123			*/
124	2		public function removeStub(Stub\Stub $stub)
125			{
126	2		foreach ($this->stubs as $key => $s) {
127	1		if ($s === $stub) {
128	1		unset($this->stubs[$key]);
129
130	1		return;
131			}
132	1		}
133	1		throw new NotFoundException('Unable to find stub');
134			}
135
136			/**
137			* @param array $criteria
138			* @return Stub\Stub
139			* @throws NotFoundException
140			*/
141	2		public function findStubByPredicates($criteria)
142			{
143	2		foreach ($this->stubs as $stub) {
144	1		if ($stub->isPredicatesMatch($criteria)) {
145	1		return $stub;
146			}
147	2		}
148	1		throw new NotFoundException('Unable to find stub');
149			}
150			}
151

meare / juggler

Issues (7)

Security Analysis no request data

src/Imposter/HttpImposter.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like